From 89a668344fc2ef07f1f86ee98bb8e10852212123 Mon Sep 17 00:00:00 2001 From: Robin Millette Date: Sun, 25 Jan 2009 19:16:19 +0000 Subject: [PATCH 1/5] added group rss action --- actions/grouprss.php | 153 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 153 insertions(+) create mode 100644 actions/grouprss.php diff --git a/actions/grouprss.php b/actions/grouprss.php new file mode 100644 index 0000000000..1a7b858b1e --- /dev/null +++ b/actions/grouprss.php @@ -0,0 +1,153 @@ +. + * + * @category Group + * @package Laconica + * @author Evan Prodromou + * @author Sarven Capadisli + * @copyright 2008-2009 Control Yourself, Inc. + * @license http://www.fsf.org/licensing/licenses/agpl-3.0.html GNU Affero General Public License version 3.0 + * @link http://laconi.ca/ + */ + +if (!defined('LACONICA')) { + exit(1); +} + +require_once INSTALLDIR.'/lib/rssaction.php'; + +define('MEMBERS_PER_SECTION', 81); + +/** + * Group RSS feed + * + * @category Group + * @package Laconica + * @author Evan Prodromou + * @license http://www.fsf.org/licensing/licenses/agpl-3.0.html GNU Affero General Public License version 3.0 + * @link http://laconi.ca/ + */ + +class groupRssAction extends Rss10Action +{ + /** group we're viewing. */ + var $group = null; + + /** + * Is this page read-only? + * + * @return boolean true + */ + + function isReadOnly() + { + return true; + } + + /** + * Prepare the action + * + * Reads and validates arguments and instantiates the attributes. + * + * @param array $args $_REQUEST args + * + * @return boolean success flag + */ + + function prepare($args) + { + parent::prepare($args); + + if (!common_config('inboxes','enabled')) { + $this->serverError(_('Inboxes must be enabled for groups to work')); + return false; + } + + $nickname_arg = $this->arg('nickname'); + $nickname = common_canonical_nickname($nickname_arg); + + // Permanent redirect on non-canonical nickname + + if ($nickname_arg != $nickname) { + $args = array('nickname' => $nickname); + common_redirect(common_local_url('showgroup', $args), 301); + return false; + } + + if (!$nickname) { + $this->clientError(_('No nickname'), 404); + return false; + } + + $this->group = User_group::staticGet('nickname', $nickname); + + if (!$this->group) { + $this->clientError(_('No such group'), 404); + return false; + } + + return true; + } + + function getNotices($limit=0) + { + + $group = $this->group; + + if (is_null($group)) { + return null; + } + + $notice = $group->getNotices(0, ($limit == 0) ? NOTICES_PER_PAGE : $limit); + + while ($notice->fetch()) { + $notices[] = clone($notice); + } + + return $notices; + } + + function getChannel() + { + $group = $this->group; + $c = array('url' => common_local_url('grouprss', + array('nickname' => + $group->nickname)), + 'title' => $group->nickname, + 'link' => common_local_url('showgroup', array('nickname' => $group->nickname)), + 'description' => sprintf(_('Microblog by %s group'), $group->nickname)); + return $c; + } + + function getImage() + { + return $this->group->homepage_logo; + } + + # override parent to add X-SUP-ID URL + + function initRss($limit=0) + { + $url = common_local_url('sup', null, $this->group->id); + header('X-SUP-ID: '.$url); + parent::initRss($limit); + } +} From 68f5afd7911ecb47204313c7392acd265e8c3abe Mon Sep 17 00:00:00 2001 From: Sarven Capadisli Date: Mon, 26 Jan 2009 06:01:24 +0000 Subject: [PATCH 2/5] Minor facebook app style fixes --- theme/base/css/facebookapp.css | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/theme/base/css/facebookapp.css b/theme/base/css/facebookapp.css index 0d8c879cd6..e614898aed 100644 --- a/theme/base/css/facebookapp.css +++ b/theme/base/css/facebookapp.css @@ -2,3 +2,19 @@ @import url("../../identica/css/display.css"); span.facebook-button { border: 2px solid #777; padding: 5px; display: block; float: left; margin-right: 20px; -moz-border-radius: 4px; border-radius:4px; -webkit-border-radius:4px; font-weight: bold; background-color:#A9BF4F; color:#fff; font-size:1.2em } + +span.facebook-button a { color:#fff } + +.notice div.entry-content dl, +.notice div.entry-content dt, +.notice div.entry-content dd { +margin-right:5px; +} + +#content_inner p { +margin-bottom:18px; +} + +#content_inner ul { +list-style-type:none; +} From ff22b095c8b70dfda786934acf469b08c17d2272 Mon Sep 17 00:00:00 2001 From: Sarven Capadisli Date: Mon, 26 Jan 2009 06:20:44 +0000 Subject: [PATCH 3/5] Facebook guide style --- theme/base/css/facebookapp.css | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/theme/base/css/facebookapp.css b/theme/base/css/facebookapp.css index e614898aed..ec0ff78c3b 100644 --- a/theme/base/css/facebookapp.css +++ b/theme/base/css/facebookapp.css @@ -18,3 +18,8 @@ margin-bottom:18px; #content_inner ul { list-style-type:none; } + +.facebook_guide p { +font-size:1.3em; +font-weight:bold; +} From b2e67db8337d94aee86adbfb8c1b61ad3e5a3b8d Mon Sep 17 00:00:00 2001 From: Sarven Capadisli Date: Mon, 26 Jan 2009 06:28:30 +0000 Subject: [PATCH 4/5] Facebook form_settings label style --- theme/base/css/facebookapp.css | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/theme/base/css/facebookapp.css b/theme/base/css/facebookapp.css index ec0ff78c3b..af188ad7a1 100644 --- a/theme/base/css/facebookapp.css +++ b/theme/base/css/facebookapp.css @@ -20,6 +20,11 @@ list-style-type:none; } .facebook_guide p { +margin-bottom:18px; font-size:1.3em; font-weight:bold; } + +.form_settings label { +margin-right:18px; +} From 55a4fac6a62a0997f15120432314d55df8994132 Mon Sep 17 00:00:00 2001 From: Zach Copley Date: Mon, 26 Jan 2009 06:31:25 +0000 Subject: [PATCH 5/5] trac750 Better permissions workflow and styling hooks --- actions/facebookhome.php | 24 ++++++++++++++++-------- lib/facebookaction.php | 6 +++++- 2 files changed, 21 insertions(+), 9 deletions(-) diff --git a/actions/facebookhome.php b/actions/facebookhome.php index 3558cf671b..e17c0f8137 100644 --- a/actions/facebookhome.php +++ b/actions/facebookhome.php @@ -43,11 +43,11 @@ class FacebookhomeAction extends FacebookAction function handle($args) { parent::handle($args); - + // If the user has opted not to initially allow the app to have // Facebook status update permission, store that preference. Only // promt the user the first time she uses the app - if ($this->arg('skip')) { + if ($this->arg('skip') || $args['fb_sig_request_method'] == 'GET') { $this->facebook->api_client->data_setUserPreference( FACEBOOK_PROMPTED_UPDATE_PREF, 'true'); } @@ -191,7 +191,7 @@ class FacebookhomeAction extends FacebookAction $this->showStylesheets(); - $this->elementStart('div', array('class' => 'content')); + $this->elementStart('div', array('class' => 'facebook_guide')); $instructions = sprintf(_('If you would like the %s app to automatically update ' . 'your Facebook status with your latest notice, you need ' . @@ -207,11 +207,19 @@ class FacebookhomeAction extends FacebookAction $this->elementStart('ul', array('id' => 'fb-permissions-list')); $this->elementStart('li', array('id' => 'fb-permissions-item')); - $this->elementStart('fb:prompt-permission', array('perms' => 'status_update', - 'next_fbjs' => 'document.setLocation(\'' . "$this->app_uri/index.php" . '\')')); - $this->element('span', array('class' => 'facebook-button'), - sprintf(_('Allow %s to update my Facebook status'), $this->app_name)); - $this->elementEnd('fb:prompt-permission'); + + $next = urlencode("$this->app_uri/index.php"); + $api_key = common_config('facebook', 'apikey'); + + $auth_url = 'http://www.facebook.com/authorize.php?api_key=' . + $api_key . '&v=1.0&ext_perm=status_update&next=' . $next . + '&next_cancel=' . $next . '&submit=skip'; + + $this->elementStart('span', array('class' => 'facebook-button')); + $this->element('a', array('href' => $auth_url), + sprintf(_('Okay, do it!'), $this->app_name)); + $this->elementEnd('span'); + $this->elementEnd('li'); $this->elementStart('li', array('id' => 'fb-permissions-item')); diff --git a/lib/facebookaction.php b/lib/facebookaction.php index c781b86f40..a12c7d6f94 100644 --- a/lib/facebookaction.php +++ b/lib/facebookaction.php @@ -276,6 +276,8 @@ class FacebookAction extends Action function showInstructions() { + $this->elementStart('div', array('class' => 'facebook_guide')); + $this->elementStart('dl', array('class' => 'system_notice')); $this->element('dt', null, 'Page Notice'); @@ -292,6 +294,9 @@ class FacebookAction extends Action $this->text($loginmsg_part2); $this->elementEnd('dd'); $this->elementEnd('dl'); + + $this->elementEnd('div'); + } @@ -315,7 +320,6 @@ class FacebookAction extends Action 'action' => 'index.php')); $this->elementStart('fieldset'); - $this->element('legend', null, _('Login to site')); $this->elementStart('ul', array('class' => 'form_datas')); $this->elementStart('li');