Fixed: The installer checks if the avatar and background directories are writable, but fails to check the file directory used for attachments.

Thanks brion

http://laconi.ca/trac/ticket/1703
This commit is contained in:
Craig Andrews 2009-07-21 13:59:34 -04:00
parent a9613e999f
commit 22466530ef
2 changed files with 17 additions and 15 deletions

11
README
View File

@ -262,13 +262,16 @@ especially if you've previously installed PHP/MySQL packages.
that user's default group instead. As a last resort, you can create that user's default group instead. As a last resort, you can create
a new group like "mublog" and add the Web server's user to the group. a new group like "mublog" and add the Web server's user to the group.
4. You should also take this moment to make your avatar subdirectory 4. You should also take this moment to make your avatar, background, and
writeable by the Web server. An insecure way to do this is: file subdirectories writeable by the Web server. An insecure way to do
this is:
chmod a+w /var/www/mublog/avatar chmod a+w /var/www/mublog/avatar
chmod a+w /var/www/mublog/background
chmod a+w /var/www/mublog/file
You can also make the avatar directory writeable by the Web server You can also make the avatar, background, and file directories
group, as noted above. writeable by the Web server group, as noted above.
5. Create a database to hold your microblog data. Something like this 5. Create a database to hold your microblog data. Something like this
should work: should work:

View File

@ -70,17 +70,16 @@ function checkPrereqs()
$pass = false; $pass = false;
} }
if (!is_writable(INSTALLDIR.'/avatar/')) { // Check the subdirs used for file uploads
?><p class="error">Cannot write avatar directory: <code><?php echo INSTALLDIR; ?>/avatar/</code></p> $fileSubdirs = array('avatar', 'background', 'file');
<p>On your server, try this command: <code>chmod a+w <?php echo INSTALLDIR; ?>/avatar/</code></p> foreach ($fileSubdirs as $fileSubdir) {
$fileFullPath = INSTALLDIR."/$fileSubdir/";
if (!is_writable($fileFullPath)) {
?><p class="error">Cannot write <?php echo $fileSubdir; ?> directory: <code><?php echo $fileFullPath; ?></code></p>
<p>On your server, try this command: <code>chmod a+w <?php echo $fileFullPath; ?></code></p>
<? <?
$pass = false; $pass = false;
} }
if (!is_writable(INSTALLDIR.'/background/')) {
?><p class="error">Cannot write background directory: <code><?php echo INSTALLDIR; ?>/background/</code></p>
<p>On your server, try this command: <code>chmod a+w <?php echo INSTALLDIR; ?>/background/</code></p>
<?
$pass = false;
} }
return $pass; return $pass;