From e93807d0e47266805fcf26738a11f23b5e689d18 Mon Sep 17 00:00:00 2001 From: sarven Date: Sat, 17 Jan 2009 20:48:09 +0000 Subject: [PATCH 1/3] Removed notice-options text labels :( --- theme/base/css/display.css | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/theme/base/css/display.css b/theme/base/css/display.css index b0a41cede8..15377a7b58 100644 --- a/theme/base/css/display.css +++ b/theme/base/css/display.css @@ -784,6 +784,12 @@ margin-right:11px; .notice-options .notice_reply dt { display:none; } + +.notice-options input, +.notice-options a { +text-indent:-9999px; +} + .notice-options .notice_reply a, .notice-options form input.submit { display:block; From 5a81b6d04ea7e2f7c5e5799ada8a611ec9406317 Mon Sep 17 00:00:00 2001 From: sarven Date: Sat, 17 Jan 2009 20:57:48 +0000 Subject: [PATCH 2/3] Added @title to input submit (reusing $label value until we really need to make it custom) --- lib/favorform.php | 4 ++-- lib/htmloutputter.php | 3 ++- lib/noticelist.php | 4 ++-- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/lib/favorform.php b/lib/favorform.php index 977f191838..519b305b6f 100644 --- a/lib/favorform.php +++ b/lib/favorform.php @@ -111,7 +111,7 @@ class FavorForm extends Form */ function formLegend() { - $this->out->element('legend', null, _('Delete this notice')); + $this->out->element('legend', null, _('Favor this notice')); } @@ -137,7 +137,7 @@ class FavorForm extends Form function formActions() { $this->out->submit('favor-submit-' . $this->notice->id, - _('Favorite')); + _('Favor this notice')); } /** diff --git a/lib/htmloutputter.php b/lib/htmloutputter.php index 71f17604ba..f83998bc27 100644 --- a/lib/htmloutputter.php +++ b/lib/htmloutputter.php @@ -319,7 +319,8 @@ class HTMLOutputter extends XMLOutputter 'id' => $id, 'name' => ($name) ? $name : $id, 'class' => $cls, - 'value' => $label)); + 'value' => $label, + 'title' => $label)); } /** diff --git a/lib/noticelist.php b/lib/noticelist.php index 1283e43e4a..9c433f81a0 100644 --- a/lib/noticelist.php +++ b/lib/noticelist.php @@ -442,7 +442,7 @@ class NoticeListItem extends Widget $this->out->element('dt', null, _('Reply to this notice')); $this->out->elementStart('dd'); $this->out->element('a', array('href' => $reply_url, - 'title' => _('reply')), _('Reply')); + 'title' => _('Reply to this notice')), _('Reply')); $this->out->elementEnd('dd'); $this->out->elementEnd('dl'); } @@ -463,7 +463,7 @@ class NoticeListItem extends Widget $this->out->element('dt', null, _('Delete this notice')); $this->out->elementStart('dd'); $this->out->element('a', array('href' => $deleteurl, - 'title' => _('delete')), _('Delete')); + 'title' => _('Delete this notice')), _('Delete')); $this->out->elementEnd('dd'); $this->out->elementEnd('dl'); } From 91475ca33f27be5116268415d80513bba6cfbd13 Mon Sep 17 00:00:00 2001 From: sarven Date: Sat, 17 Jan 2009 21:09:42 +0000 Subject: [PATCH 3/3] Update. Added separate $title param for input submit --- lib/favorform.php | 2 +- lib/htmloutputter.php | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/favorform.php b/lib/favorform.php index 519b305b6f..37e13fb1c5 100644 --- a/lib/favorform.php +++ b/lib/favorform.php @@ -137,7 +137,7 @@ class FavorForm extends Form function formActions() { $this->out->submit('favor-submit-' . $this->notice->id, - _('Favor this notice')); + _('Favor'), 'submit', null, _('Favor this notice')); } /** diff --git a/lib/htmloutputter.php b/lib/htmloutputter.php index f83998bc27..1e164933ce 100644 --- a/lib/htmloutputter.php +++ b/lib/htmloutputter.php @@ -313,14 +313,14 @@ class HTMLOutputter extends XMLOutputter * @todo add a $name parameter */ - function submit($id, $label, $cls='submit', $name=null) + function submit($id, $label, $cls='submit', $name=null, $title=null) { $this->element('input', array('type' => 'submit', 'id' => $id, 'name' => ($name) ? $name : $id, 'class' => $cls, 'value' => $label, - 'title' => $label)); + 'title' => $title)); } /**