bad URL is a clientError

This commit is contained in:
Mikael Nordfeldth 2015-04-03 20:58:12 +02:00
parent 94d3f50aee
commit 3cf5fe8795

View File

@ -46,8 +46,7 @@ class OembedAction extends Action
$url = $this->trimmed('url'); $url = $this->trimmed('url');
if (substr(strtolower($url),0,strlen(common_root_url())) !== strtolower(common_root_url())) { if (substr(strtolower($url),0,strlen(common_root_url())) !== strtolower(common_root_url())) {
// TRANS: Error message displaying attachments. %s is the site's base URL. // TRANS: Error message displaying attachments. %s is the site's base URL.
// FIXME: 404 not found?! (this will automatically become a 500 because it's not a serverError!) $this->clientError(sprintf(_('oEmbed data will only be provided for %s URLs.'), common_root_url()), 400);
$this->serverError(sprintf(_('Only %s URLs over plain HTTP please.'), common_root_url()), 404);
} }
$path = substr($url,strlen(common_root_url())); $path = substr($url,strlen(common_root_url()));