wamo/gnu-social
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Potential SQL injection in Local_group::setNickname()

Browse Source 
This change escapes a parameter in Local_group::setNickname(). Review
of the code paths that call this function sanitize the parameter
higher up the stack, but it's escaped here to prevent mistakes later.

Note that nickname parameters are normally alphanum strings, so
there's not much danger in double-escaping them.
This commit is contained in:
Joshua Wise 2013-07-16 10:09:16 -07:00 committed by Evan Prodromou
parent 4092ee1bd1
commit 3fb2c06cba
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
classes/Local_group.php
View File

@ -44,7 +44,7 @@ class Local_group extends Managed_DataObject
function setNickname($nickname) function setNickname($nickname)
{ {
$this->decache(); $this->decache();
$qry = 'UPDATE local_group set nickname = "'.$nickname.'" where group_id = ' . $this->group_id; $qry = 'UPDATE local_group set nickname = "'.$this->escape($nickname).'" where group_id = ' . $this->group_id;
$result = $this->query($qry); $result = $this->query($qry);