wamo/gnu-social
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge branch 'mention_branch' into 'nightly'

Browse Source 
correct mentions if parent mentions multiple users with same nickname (don't use first one for all)



See merge request !82
This commit is contained in:
mmn 2016-01-26 21:15:25 +00:00
commit 42545c6625
1 changed files with 17 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
lib/util.php
View File

@ -725,14 +725,13 @@ function common_find_mentions($text, Profile $sender, Notice $parent=null)
if (Event::handle('StartFindMentions', array($sender, $text, &$mentions))) { if (Event::handle('StartFindMentions', array($sender, $text, &$mentions))) {
// Get the context of the original notice, if any // Get the context of the original notice, if any
$origMentions = array(); $origMentions = array();
// Does it have a parent notice for context? // Does it have a parent notice for context?
if ($parent instanceof Notice) { if ($parent instanceof Notice) {
foreach ($parent->getAttentionProfiles() as $repliedTo) { foreach ($parent->getAttentionProfiles() as $repliedTo) {
if (!$repliedTo->isPerson()) { if (!$repliedTo->isPerson()) {
continue; continue;
} }
$origMentions[$repliedTo->getNickname()] = $repliedTo; $origMentions[$repliedTo->id] = $repliedTo;
} }
} }
@ -746,15 +745,24 @@ function common_find_mentions($text, Profile $sender, Notice $parent=null)
continue; continue;
} }
// Try to get a profile for this nickname. // primarily mention the profiles mentioned in the parent
// Start with conversation context, then go to $mention_found_in_origMentions = false;
// sender context. foreach($origMentions as $origMentionsId=>$origMention) {
if($origMention->getNickname() == $nickname) {
$mention_found_in_origMentions = $origMention;
// don't mention same twice! the parent might have mentioned
// two users with same nickname on different instances
unset($origMentions[$origMentionsId]);
break;
}
}
if ($parent instanceof Notice && $parent->getProfile()->getNickname() === $nickname) { // Try to get a profile for this nickname.
// Start with parents mentions, then go to parents sender context
if ($mention_found_in_origMentions) {
$mentioned = $mention_found_in_origMentions;
} else if ($parent instanceof Notice && $parent->getProfile()->getNickname() === $nickname) {
$mentioned = $parent->getProfile(); $mentioned = $parent->getProfile();
} else if (!empty($origMentions) &&
array_key_exists($nickname, $origMentions)) {
$mentioned = $origMentions[$nickname];
} else { } else {
// sets to null if no match // sets to null if no match
$mentioned = common_relative_profile($sender, $nickname); $mentioned = common_relative_profile($sender, $nickname);