getKV doesn't throw exception
This commit is contained in:
parent
f708a5b016
commit
501d081d3b
|
@ -170,16 +170,19 @@ class File_redirection extends Managed_DataObject
|
|||
|
||||
try {
|
||||
$r = File_redirection::getByUrl($in_url);
|
||||
try {
|
||||
$f = File::getKV('id',$r->file_id);
|
||||
|
||||
$f = File::getKV('id',$r->file_id);
|
||||
|
||||
if($file instanceof File) {
|
||||
$r->file = $f;
|
||||
$r->redir_url = $f->url;
|
||||
} catch (NoResultException $e) {
|
||||
} else {
|
||||
// Invalid entry, delete and run again
|
||||
common_log(LOG_ERR, "Could not find File with id=".$r->file_id." referenced in File_redirection, deleting File redirection entry and and trying again...");
|
||||
$r->delete();
|
||||
return self::where($in_url);
|
||||
}
|
||||
|
||||
// File_redirecion and File record found, return both
|
||||
return $r;
|
||||
|
||||
|
@ -207,11 +210,13 @@ class File_redirection extends Managed_DataObject
|
|||
// in that case we have the file id already
|
||||
try {
|
||||
$r = File_redirection::getByUrl($redir_info['url']);
|
||||
try {
|
||||
$f = File::getKV('id',$r->file_id);
|
||||
|
||||
$f = File::getKV('id',$r->file_id);
|
||||
|
||||
if($f instanceof File) {
|
||||
$redir->file = $f;
|
||||
$redir->redir_url = $f->url;
|
||||
} catch (NoResultException $e) {
|
||||
} else {
|
||||
// Invalid entry in File_redirection, delete and run again
|
||||
common_log(LOG_ERR, "Could not find File with id=".$r->file_id." referenced in File_redirection, deleting File_redirection entry and trying again...");
|
||||
$r->delete();
|
||||
|
|
Loading…
Reference in New Issue
Block a user