From 527427d3e0752a371b1b6421dabec5cc1c7e19ad Mon Sep 17 00:00:00 2001 From: Zach Copley Date: Wed, 4 Nov 2009 21:00:26 -0800 Subject: [PATCH] Implement update avatar via API (/api/account/update_profile_image.format) --- actions/apiaccountupdateprofileimage.php | 145 +++++++++++++++++++++++ actions/apistatusesupdate.php | 2 +- extlib/MIME/Type.php | 2 +- lib/imagefile.php | 2 +- lib/router.php | 3 + 5 files changed, 151 insertions(+), 3 deletions(-) create mode 100644 actions/apiaccountupdateprofileimage.php diff --git a/actions/apiaccountupdateprofileimage.php b/actions/apiaccountupdateprofileimage.php new file mode 100644 index 0000000000..416fee45ac --- /dev/null +++ b/actions/apiaccountupdateprofileimage.php @@ -0,0 +1,145 @@ +. + * + * @category API + * @package StatusNet + * @author Zach Copley + * @copyright 2009 StatusNet, Inc. + * @license http://www.fsf.org/licensing/licenses/agpl-3.0.html GNU Affero General Public License version 3.0 + * @link http://status.net/ + */ + +if (!defined('STATUSNET')) { + exit(1); +} + +require_once INSTALLDIR . '/lib/apiauth.php'; + +/** + * Updates the authenticating user's profile image. Note that this API method + * expects raw multipart data, not a URL to an image. + * + * @category API + * @package StatusNet + * @author Zach Copley + * @license http://www.fsf.org/licensing/licenses/agpl-3.0.html GNU Affero General Public License version 3.0 + * @link http://status.net/ + */ + +class ApiAccountUpdateProfileImageAction extends ApiAuthAction +{ + + /** + * Take arguments for running + * + * @param array $args $_REQUEST args + * + * @return boolean success flag + * + */ + + function prepare($args) + { + parent::prepare($args); + + $this->user = $this->auth_user; + + return true; + } + + /** + * Handle the request + * + * Check whether the credentials are valid and output the result + * + * @param array $args $_REQUEST data (unused) + * + * @return void + */ + + function handle($args) + { + parent::handle($args); + + if ($_SERVER['REQUEST_METHOD'] != 'POST') { + $this->clientError( + _('This method requires a POST.'), + 400, $this->format + ); + return; + } + + if (empty($this->user)) { + $this->clientError(_('No such user!'), 404, $this->format); + return; + } + + // Workaround for PHP returning empty $_FILES when POST length > PHP settings + + if (empty($_FILES) && ($_SERVER['CONTENT_LENGTH'] > 0)) { + common_debug('content-length = ' . $_SERVER['CONTENT_LENGTH']); + $this->clientError(_('Unable to handle that much POST data!')); + return; + } + + try { + $imagefile = ImageFile::fromUpload('image'); + } catch (Exception $e) { + $this->clientError($e->getMessage(), 400, $this->format); + return; + } + + $filename = Avatar::filename( + $user->id, + image_type_to_extension($imagefile->type), + null, + 'tmp'.common_timestamp() + ); + + $filepath = Avatar::path($filename); + + move_uploaded_file($imagefile->filepath, $filepath); + + $profile = $this->user->getProfile(); + + if (empty($profile)) { + $this->clientError(_('User has no profile.')); + return; + } + + $profile->setOriginal($filename); + + common_broadcast_profile($profile); + + $twitter_user = $this->twitterUserArray($this->user->getProfile(), true); + + if ($this->format == 'xml') { + $this->initDocument('xml'); + $this->showTwitterXmlUser($twitter_user); + $this->endDocument('xml'); + } elseif ($this->format == 'json') { + $this->initDocument('json'); + $this->showJsonObjects($twitter_user); + $this->endDocument('json'); + } + } + +} diff --git a/actions/apistatusesupdate.php b/actions/apistatusesupdate.php index b9c0832a4e..82fe5a537e 100644 --- a/actions/apistatusesupdate.php +++ b/actions/apistatusesupdate.php @@ -128,7 +128,7 @@ class ApiStatusesUpdateAction extends ApiAuthAction // Workaround for PHP returning empty $_FILES when POST length > PHP settings - if (empty($_POST) && ($_SERVER['CONTENT_LENGTH'] > 0)) { + if (empty($_FILES) && ($_SERVER['CONTENT_LENGTH'] > 0)) { $this->clientError(_('Unable to handle that much POST data!')); return; } diff --git a/extlib/MIME/Type.php b/extlib/MIME/Type.php index c335f8d92d..e0e9c9ee6e 100644 --- a/extlib/MIME/Type.php +++ b/extlib/MIME/Type.php @@ -513,7 +513,7 @@ class MIME_Type return PEAR::raiseError("Can't find file command \"{$fileCmd}\""); } - $cmd->pushCommand($fileCmd, "-bi " . escapeshellarg($file)); + $cmd->pushCommand($fileCmd, "-bI " . escapeshellarg($file)); $res = $cmd->execute(); unset($cmd); diff --git a/lib/imagefile.php b/lib/imagefile.php index cd2f87e6bd..cf1668f203 100644 --- a/lib/imagefile.php +++ b/lib/imagefile.php @@ -72,7 +72,7 @@ class ImageFile break; case UPLOAD_ERR_INI_SIZE: case UPLOAD_ERR_FORM_SIZE: - throw new Exception(sprintf(_('That file is too big. The maximum file size is %d.'), + throw new Exception(sprintf(_('That file is too big. The maximum file size is %s.'), ImageFile::maxFileSize())); return; case UPLOAD_ERR_PARTIAL: diff --git a/lib/router.php b/lib/router.php index 0ddda473c0..eb931e5b07 100644 --- a/lib/router.php +++ b/lib/router.php @@ -428,6 +428,9 @@ class Router $m->connect('api/account/verify_credentials.:format', array('action' => 'ApiAccountVerifyCredentials')); + $m->connect('api/account/update_profile_image.:format', + array('action' => 'ApiAccountUpdateProfileImage')); + // special case where verify_credentials is called w/out a format $m->connect('api/account/verify_credentials',