diff --git a/actions/imsettings.php b/actions/imsettings.php index b34f8ca12d..d8680c98b4 100644 --- a/actions/imsettings.php +++ b/actions/imsettings.php @@ -61,11 +61,11 @@ class ImsettingsAction extends SettingsAction { function handle_post() { - $jabber = $this->trimmed('jabber'); + $jabber = jabber_normalize_jid($this->trimmed('jabber')); $jabbernotify = $this->boolean('jabbernotify'); $updatefrompresence = $this->boolean('updatefrompresence'); - if (!jabber_validate_jid($jabber)) { + if (!jabber_valid_base_jid($jabber)) { $this->show_form(_('Not a valid Jabber ID')); return; } else if ($this->jabber_exists($jabber)) { diff --git a/lib/jabber.php b/lib/jabber.php new file mode 100644 index 0000000000..141b9231ff --- /dev/null +++ b/lib/jabber.php @@ -0,0 +1,33 @@ +. + */ + +if (!defined('LACONICA')) { exit(1); } + +function jabber_valid_base_jid($jid) { + # Cheap but effective + return Validate::email($jid); +} + +function jabber_normalize_jid($jid) { + preg_match("/(?:([^\@]+)\@)?([^\/]+)(?:\/(.*))?$/", $jid, $matches); + $node = $matches[1]; + $server = $matches[2]; + $resource = $matches[3]; + return strtolower($node.'@'.$server); +} diff --git a/lib/util.php b/lib/util.php index d990b8e1f0..7a9bed2c91 100644 --- a/lib/util.php +++ b/lib/util.php @@ -319,6 +319,25 @@ function common_input($id, $label, $value=NULL,$instructions=NULL) { common_element_end('p'); } +function common_checkbox($id, $label, $value='true', + $instructions=NULL) +{ + common_element_start('p'); + $attrs = array('name' => $id, + 'type' => 'checkbox', + 'id' => $id, + 'value' => $value); + if ($value) { + $attrs['value'] = htmlspecialchars($value); + } + common_element('input', $attrs); + common_element('label', array('for' => $id), $label); + if ($instructions) { + common_element('span', 'input_instructions', $instructions); + } + common_element_end('p'); +} + function common_hidden($id, $value) { common_element('input', array('name' => $id, 'type' => 'hidden', diff --git a/xmppdaemon.php b/xmppdaemon.php index aa402b1e2c..b71c93dc81 100644 --- a/xmppdaemon.php +++ b/xmppdaemon.php @@ -51,14 +51,6 @@ class XMPPDaemon { return !$this->conn->disconnected; } - function normalize_jid($jid) { - preg_match("/(?:([^\@]+)\@)?([^\/]+)(?:\/(.*))?$/", $jid, $matches); - $node = $matches[1]; - $server = $matches[2]; - $resource = $matches[3]; - return strtolower($node.'@'.$server); - } - function handle() { while(!$this->conn->disconnected) { $payloads = $this->conn->processUntil(array('message', 'presence', @@ -87,7 +79,7 @@ class XMPPDaemon { if (strlen($pl['body']) == 0) { return; } - $from = $this->normalize_jid($pl['from']); + $from = jabber_normalize_jid($pl['from']); $user = User::staticGet('jabber', $from); if (!$user) { $this->log(LOG_WARNING, 'Message from unknown user ' . $from); @@ -162,7 +154,7 @@ class XMPPDaemon { } function handle_presence(&$pl) { - $from = $this->normalize_jid($pl['from']); + $from = jabber_normalize_jid($pl['from']); $user = User::staticGet('jabber', $from); if (!$user) { $this->log(LOG_WARNING, 'Message from unknown user ' . $from);