From 7af94dc12562b8114f0f823dc8438234125022da Mon Sep 17 00:00:00 2001
From: Evan Prodromou <evan@controlyourself.ca>
Date: Sat, 27 Jun 2009 07:09:21 -0700
Subject: [PATCH] some debugging code for sessions

---
 classes/Session.php | 24 +++++++++++++++++++++---
 lib/util.php        |  1 +
 2 files changed, 22 insertions(+), 3 deletions(-)

diff --git a/classes/Session.php b/classes/Session.php
index 6f13c7d273..5c48e4aa90 100644
--- a/classes/Session.php
+++ b/classes/Session.php
@@ -40,6 +40,11 @@ class Session extends Memcached_DataObject
     /* the code above is auto generated do not remove the tag below */
     ###END_AUTOCODE
 
+    static function logdeb($msg)
+    {
+        common_debug("Session: " . $msg);
+    }
+
     static function open($save_path, $session_name)
     {
         return true;
@@ -52,6 +57,8 @@ class Session extends Memcached_DataObject
 
     static function read($id)
     {
+        self::logdeb("Fetching session '$id'");
+
         $session = Session::staticGet('id', $id);
 
         if (empty($session)) {
@@ -63,6 +70,8 @@ class Session extends Memcached_DataObject
 
     static function write($id, $session_data)
     {
+        self::logdeb("Writing session '$id'");
+
         $session = Session::staticGet('id', $id);
 
         if (empty($session)) {
@@ -82,6 +91,8 @@ class Session extends Memcached_DataObject
 
     static function destroy($id)
     {
+        self::logdeb("Deleting session $id");
+
         $session = Session::staticGet('id', $id);
 
         if (!empty($session)) {
@@ -91,6 +102,8 @@ class Session extends Memcached_DataObject
 
     static function gc($maxlifetime)
     {
+        self::logdeb("garbage collection (maxlifetime = $maxlifetime)");
+
         $epoch = time() - $maxlifetime;
 
         $qry = 'DELETE FROM session ' .
@@ -98,12 +111,17 @@ class Session extends Memcached_DataObject
 
         $session = new Session();
 
-        $session->query($qry);
+        $result = $session->query($qry);
+
+        self::logdeb("garbage collection result = $result");
     }
 
     static function setSaveHandler()
     {
-        session_set_save_handler('Session::open', 'Session::close', 'Session::read',
-                                 'Session::write', 'Session::destroy', 'Session::gc');
+        self::logdeb("setting save handlers");
+        $result = session_set_save_handler('Session::open', 'Session::close', 'Session::read',
+                                           'Session::write', 'Session::destroy', 'Session::gc');
+        self::logdeb("save handlers result = $result");
+        return $result;
     }
 }
diff --git a/lib/util.php b/lib/util.php
index 2face67770..c8da8c7dd1 100644
--- a/lib/util.php
+++ b/lib/util.php
@@ -145,6 +145,7 @@ function common_ensure_session()
     }
     if (!common_have_session()) {
         if (common_config('sessions', 'handle')) {
+            common_log(LOG_INFO, "Using our own session handler");
             Session::setSaveHandler();
         }
         @session_start();