From 8516ccfb9db5fd0e33f04abd5e63f11a909a3cfd Mon Sep 17 00:00:00 2001 From: Evan Prodromou Date: Wed, 21 Jan 2009 13:57:18 -0500 Subject: [PATCH] move membership/adminship tests to profile --- classes/Profile.php | 34 ++++++++++++++++++++++++++++++++-- classes/User.php | 25 ++++--------------------- 2 files changed, 36 insertions(+), 23 deletions(-) diff --git a/classes/Profile.php b/classes/Profile.php index 31bdf71d59..ab5a48e57f 100644 --- a/classes/Profile.php +++ b/classes/Profile.php @@ -121,7 +121,7 @@ class Profile extends Memcached_DataObject return $avatar; } - function crop_avatars($x, $y, $w, $h) + function crop_avatars($x, $y, $w, $h) { $avatar = $this->getOriginalAvatar(); @@ -139,7 +139,7 @@ class Profile extends Memcached_DataObject return true; } - function delete_avatars($original=true) + function delete_avatars($original=true) { $avatar = new Avatar(); $avatar->profile_id = $this->id; @@ -187,4 +187,34 @@ class Profile extends Memcached_DataObject 'profile:notices:'.$this->id, $offset, $limit, $since_id, $before_id); } + + function isMember($group) + { + $mem = new Group_member(); + + $mem->group_id = $group->id; + $mem->profile_id = $this->id; + + if ($mem->find()) { + return true; + } else { + return false; + } + } + + function isAdmin($group) + { + $mem = new Group_member(); + + $mem->group_id = $group->id; + $mem->profile_id = $this->id; + $mem->is_admin = 1; + + if ($mem->find()) { + return true; + } else { + return false; + } + } + } diff --git a/classes/User.php b/classes/User.php index 9a1ebddc41..5dadd6b440 100644 --- a/classes/User.php +++ b/classes/User.php @@ -494,31 +494,14 @@ class User extends Memcached_DataObject function isMember($group) { - $mem = new Group_member(); - - $mem->group_id = $group->id; - $mem->profile_id = $this->id; - - if ($mem->find()) { - return true; - } else { - return false; - } + $profile = $this->getProfile(); + return $profile->isMember($group); } function isAdmin($group) { - $mem = new Group_member(); - - $mem->group_id = $group->id; - $mem->profile_id = $this->id; - $mem->is_admin = 1; - - if ($mem->find()) { - return true; - } else { - return false; - } + $profile = $this->getProfile(); + return $profile->isAdmin($group); } function getGroups($offset=0, $limit=null)