Validate OStatus avatar URL before fetching.

This commit is contained in:
Brion Vibber 2010-03-19 10:15:00 -07:00
parent 05e3768e6a
commit 9e3e1d3d56

View File

@ -839,8 +839,8 @@ class Ostatus_profile extends Memcached_DataObject
} }
/** /**
*
* Download and update given avatar image * Download and update given avatar image
*
* @param string $url * @param string $url
* @throws Exception in various failure cases * @throws Exception in various failure cases
*/ */
@ -850,6 +850,9 @@ class Ostatus_profile extends Memcached_DataObject
// We've already got this one. // We've already got this one.
return; return;
} }
if (!common_valid_http_url($url)) {
throw new ServerException(_m("Invalid avatar URL %s"), $url);
}
if ($this->isGroup()) { if ($this->isGroup()) {
$self = $this->localGroup(); $self = $this->localGroup();