wamo/gnu-social
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

better error checking in shownotice

Browse Source 
darcs-hash:20080711171345-84dde-790e24f1d31a716cc52857229087469cd84ad65e.gz
This commit is contained in:
Evan Prodromou 2008-07-11 13:13:45 -04:00
parent 335d5f2e89
commit ad410c0c61
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
actions/shownotice.php
View File

@ -29,13 +29,15 @@ class ShownoticeAction extends StreamAction {
$notice = Notice::staticGet($id); $notice = Notice::staticGet($id);
if (!$notice) { if (!$notice) {
$this->no_such_notice(); $this->client_error(_t('No such notice.'), 404);
return;
} }
$profile = $notice->getProfile(); $profile = $notice->getProfile();
if (!$profile) { if (!$profile) {
$this->no_such_notice(); $this->server_error(_t('Notice has no profile'), 500);
return;
} }
# Looks like we're good; show the header # Looks like we're good; show the header
@ -58,8 +60,4 @@ class ShownoticeAction extends StreamAction {
common_notice_form(); common_notice_form();
} }
} }
function no_such_notice() {
common_user_error('No such notice.');
}
} }