[TOOLS][CS-FIXER] Fix incorrect transformation

.php-cs-fixer.php

@@ -273,12 +273,13 @@ return $config
         'phpdoc_single_line_var_spacing' => true,
         // Fixes casing of PHPDoc tags.
         'phpdoc_tag_casing' => true,
-        // EXPERIMENTAL: Takes `@param` annotations of non-mixed types and adjusts accordingly the function signature. Requires PHP >= 7.0.
-        'phpdoc_to_param_type' => true,
-        // EXPERIMENTAL: Takes `@var` annotation of non-mixed types and adjusts accordingly the property signature. Requires PHP >= 7.4.
-        'phpdoc_to_property_type' => true,
-        // EXPERIMENTAL: Takes `@return` annotation of non-mixed types and adjusts accordingly the function signature. Requires PHP >= 7.0.
-        'phpdoc_to_return_type' => true,
+        // Would be neat, but breaks cases where the parents don't have annotations
+        // // EXPERIMENTAL: Takes `@param` annotations of non-mixed types and adjusts accordingly the function signature. Requires PHP >= 7.0.
+        // 'phpdoc_to_param_type' => true,
+        // // EXPERIMENTAL: Takes `@var` annotation of non-mixed types and adjusts accordingly the property signature. Requires PHP >= 7.4.
+        // 'phpdoc_to_property_type' => true,
+        // // EXPERIMENTAL: Takes `@return` annotation of non-mixed types and adjusts accordingly the function signature. Requires PHP >= 7.0.
+        // 'phpdoc_to_return_type' => true,
         // PHPDoc should start and end with content, excluding the very first and last line of the docblocks.
         'phpdoc_trim' => true,
         // Removes extra blank lines after summary and after description in PHPDoc.
@@ -368,10 +369,10 @@ return $config
     ])
     ->setFinder(
         PhpCsFixer\Finder::create()
-    ->exclude('vendor')
-    ->exclude('var')
-    ->exclude('docker')
-    ->exclude('src/Entity')
-    ->notPath('src/Core/DB/DefaultSettings.php')
-    ->in(__DIR__),
+            ->exclude('vendor')
+            ->exclude('var')
+            ->exclude('docker')
+            ->exclude('src/Entity')
+            ->notPath('src/Core/DB/DefaultSettings.php')
+            ->in(__DIR__),
     );

bin/pre-commit

@@ -11,7 +11,7 @@ if (! (: "${SKIP_ALL?}") 2>/dev/null) && (! (: "${SKIP_CS_FIX?}") 2>/dev/null);
         # work only with existing files
         if [ -f "${staged}" ] && expr "${staged}" : '^.*\.php$' > /dev/null;  then
             # use php-cs-fixer and get flag of correction
-            if "${root}/bin/php-cs-fixer" -q fix "${staged}"; then
+            if "${root}/bin/php-cs-fixer" -q --config="${root}/.php-cs-fixer.php" fix "${staged}"; then
                 git add "${staged}" # execute git add directly
             fi
         fi

src/DependencyInjection/Compiler/SchemaDefDriver.php

@@ -91,8 +91,11 @@ class SchemaDefDriver extends StaticPHPDriver implements CompilerPassInterface
 
     /**
      * Fill in the database $metadata for $class_name
+     *
+     * @param string            $class_name
+     * @param ClassMetadataInfo $metadata
      */
-    public function loadMetadataForClass(string $class_name, ClassMetadataInfo $metadata)
+    public function loadMetadataForClass($class_name, $metadata)
     {
         $schema = $class_name::schemaDef();
 
@@ -208,8 +211,12 @@ class SchemaDefDriver extends StaticPHPDriver implements CompilerPassInterface
      * Override StaticPHPDriver's method,
      * we care about classes that have the method `schemaDef`,
      * instead of `loadMetadata`.
+     *
+     * @param string $class_name
+     *
+     * @return bool
      */
-    public function isTransient(string $class_name): bool
+    public function isTransient($class_name)
     {
         return !method_exists($class_name, 'schemaDef');
     }

src/Security/Authenticator.php

@@ -107,7 +107,10 @@ class Authenticator extends AbstractFormLoginAuthenticator
         return $user;
     }
 
-    public function checkCredentials($credentials, LocalUser $user)
+    /**
+     * @param LocalUser $user
+     */
+    public function checkCredentials($credentials, $user)
     {
         if (!$user->checkPassword($credentials['password'])) {
             throw new CustomUserMessageAuthenticationException(_m('Invalid login credentials.'));

src/Util/Form/ActorArrayTransformer.php

@@ -40,21 +40,29 @@ class ActorArrayTransformer extends ArrayTransformer
 {
     /**
      * Transforms array of Actors into string of nicknames
+     *
+     * @param array $a
+     *
+     * @return string
      */
-    public function transform(array $a): string
+    public function transform($a)
     {
         return parent::transform(
             array_map(
-                fn ($actor) => $actor->getNickname(),
-                $a,
-            ),
+            fn ($actor) => $actor->getNickname(),
+            $a,
+        ),
         );
     }
 
     /**
      * Transforms string of nicknames into Actors
+     *
+     * @param string $s
+     *
+     * @return array
      */
-    public function reverseTransform(string $s): array
+    public function reverseTransform($s)
     {
         return array_map(
             fn ($nickmame) => Actor::getFromNickname($nickmame),

src/Util/Form/ArrayTransformer.php

@@ -40,7 +40,12 @@ class ArrayTransformer implements DataTransformerInterface
 {
     // Can't use type annotations, to conform to interface
 
-    public function transform(array $a): string
+    /**
+     * @param array $a
+     *
+     * @return string
+     */
+    public function transform($a)
     {
         if (!\is_array($a)) {
             throw new TransformationFailedException();
@@ -48,7 +53,12 @@ class ArrayTransformer implements DataTransformerInterface
         return Formatting::toString($a, Formatting::SPLIT_BY_SPACE);
     }
 
-    public function reverseTransform(string $s): array
+    /**
+     * @param string $s
+     *
+     * @return array
+     */
+    public function reverseTransform($s)
     {
         if (empty($s)) {
             return [];