wamo/gnu-social
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Better error handling when updating Facebook

Browse Source
This commit is contained in:
Zach Copley 2009-07-27 02:54:51 +00:00
parent 3077876b17
commit b9cf19a2ee
2 changed files with 12 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
lib/facebookutil.php
View File

@ -193,14 +193,16 @@ function facebookBroadcastNotice($notice)
$facebook->api_client->users_setStatus($status, $fbuid, false, true); $facebook->api_client->users_setStatus($status, $fbuid, false, true);
} }
} catch(FacebookRestClientException $e) { } catch(FacebookRestClientException $e) {
common_log(LOG_ERR, $e->getMessage());
$code = $e->getCode();
common_log(LOG_ERR, 'Facebook returned error code ' .
$code . ': ' . $e->getMessage());
common_log(LOG_ERR, common_log(LOG_ERR,
'Unable to update Facebook status for ' . 'Unable to update Facebook status for ' .
"$user->nickname (user id: $user->id)!"); "$user->nickname (user id: $user->id)!");
$code = $e->getCode(); if ($code == 200 || $code == 250) {
if ($code >= 200) {
// 200 The application does not have permission to operate on the passed in uid parameter. // 200 The application does not have permission to operate on the passed in uid parameter.
// 250 Updating status requires the extended permission status_update or publish_stream. // 250 Updating status requires the extended permission status_update or publish_stream.
@ -216,7 +218,8 @@ function facebookBroadcastNotice($notice)
try { try {
updateProfileBox($facebook, $flink, $notice); updateProfileBox($facebook, $flink, $notice);
} catch(FacebookRestClientException $e) { } catch(FacebookRestClientException $e) {
common_log(LOG_WARNING, $e->getMessage()); common_log(LOG_ERR, 'Facebook returned error code ' .
$e->getCode() . ': ' . $e->getMessage());
common_log(LOG_WARNING, common_log(LOG_WARNING,
'Unable to update Facebook profile box for ' . 'Unable to update Facebook profile box for ' .
"$user->nickname (user id: $user->id)."); "$user->nickname (user id: $user->id).");

8
lib/mail.php
View File

@ -679,17 +679,17 @@ function mail_facebook_app_removed($user)
$site_name = common_config('site', 'name'); $site_name = common_config('site', 'name');
$subject = sprintf( $subject = sprintf(
_('Your %s Facebook application access has been disabled.', _('Your %1\$s Facebook application access has been disabled.',
$site_name)); $site_name));
$body = sprintf(_("Hi, %1\$s. We're sorry to inform you that we are " . $body = sprintf(_("Hi, %1\$s. We're sorry to inform you that we are " .
'unable to update your Facebook status from %s, and have disabled ' . 'unable to update your Facebook status from %2\$s, and have disabled ' .
'the Facebook application for your account. This may be because ' . 'the Facebook application for your account. This may be because ' .
'you have removed the Facebook application\'s authorization, or ' . 'you have removed the Facebook application\'s authorization, or ' .
'have deleted your Facebook account. You can re-enable the ' . 'have deleted your Facebook account. You can re-enable the ' .
'Facebook application and automatic status updating by ' . 'Facebook application and automatic status updating by ' .
"re-installing the %1\$s Facebook application.\n\nRegards,\n\n%1\$s"), "re-installing the %2\$s Facebook application.\n\nRegards,\n\n%2\$s"),
$site_name); $user->nickname, $site_name);
common_init_locale(); common_init_locale();
return mail_to_user($user, $subject, $body); return mail_to_user($user, $subject, $body);