Merge branch 'testing' of git@gitorious.org:statusnet/mainline into testing
This commit is contained in:
commit
c0f6572001
|
@ -109,7 +109,7 @@ class PublictagcloudAction extends Action
|
|||
$cutoff = sprintf("notice_tag.created > '%s'",
|
||||
common_sql_date(time() - common_config('tag', 'cutoff')));
|
||||
$tags->selectAdd($calc . ' as weight');
|
||||
$tags->addWhere($cutoff);
|
||||
$tags->whereAdd($cutoff);
|
||||
$tags->groupBy('tag');
|
||||
$tags->orderBy('weight DESC');
|
||||
|
||||
|
|
|
@ -61,7 +61,7 @@ class FeedSub extends Memcached_DataObject
|
|||
public $__table = 'feedsub';
|
||||
|
||||
public $id;
|
||||
public $feeduri;
|
||||
public $uri;
|
||||
|
||||
// PuSH subscription data
|
||||
public $huburi;
|
||||
|
@ -238,7 +238,7 @@ class FeedSub extends Memcached_DataObject
|
|||
public function subscribe($mode='subscribe')
|
||||
{
|
||||
if ($this->sub_state && $this->sub_state != 'inactive') {
|
||||
throw new ServerException("Attempting to start PuSH subscription to feed in state $this->sub_state");
|
||||
common_log(LOG_WARNING, "Attempting to (re)start PuSH subscription to $this->uri in unexpected state $this->sub_state");
|
||||
}
|
||||
if (empty($this->huburi)) {
|
||||
if (common_config('feedsub', 'nohub')) {
|
||||
|
@ -261,7 +261,7 @@ class FeedSub extends Memcached_DataObject
|
|||
*/
|
||||
public function unsubscribe() {
|
||||
if ($this->sub_state != 'active') {
|
||||
throw new ServerException("Attempting to end PuSH subscription to feed in state $this->sub_state");
|
||||
common_log(LOG_WARNING, "Attempting to (re)end PuSH subscription to $this->uri in unexpected state $this->sub_state");
|
||||
}
|
||||
if (empty($this->huburi)) {
|
||||
if (common_config('feedsub', 'nohub')) {
|
||||
|
|
|
@ -204,12 +204,13 @@ class Ostatus_profile extends Memcached_DataObject
|
|||
public function subscribe()
|
||||
{
|
||||
$feedsub = FeedSub::ensureFeed($this->feeduri);
|
||||
if ($feedsub->sub_state == 'active' || $feedsub->sub_state == 'subscribe') {
|
||||
if ($feedsub->sub_state == 'active') {
|
||||
// Active subscription, we don't need to do anything.
|
||||
return true;
|
||||
} else if ($feedsub->sub_state == '' || $feedsub->sub_state == 'inactive') {
|
||||
} else {
|
||||
// Inactive or we got left in an inconsistent state.
|
||||
// Run a subscription request to make sure we're current!
|
||||
return $feedsub->subscribe();
|
||||
} else if ('unsubscribe') {
|
||||
throw new FeedSubException("Unsub is pending, can't subscribe...");
|
||||
}
|
||||
}
|
||||
|
||||
|
@ -222,15 +223,13 @@ class Ostatus_profile extends Memcached_DataObject
|
|||
*/
|
||||
public function unsubscribe() {
|
||||
$feedsub = FeedSub::staticGet('uri', $this->feeduri);
|
||||
if (!$feedsub) {
|
||||
if (!$feedsub || $feedsub->sub_state == '' || $feedsub->sub_state == 'inactive') {
|
||||
// No active PuSH subscription, we can just leave it be.
|
||||
return true;
|
||||
}
|
||||
if ($feedsub->sub_state == 'active') {
|
||||
} else {
|
||||
// PuSH subscription is either active or in an indeterminate state.
|
||||
// Send an unsubscribe.
|
||||
return $feedsub->unsubscribe();
|
||||
} else if ($feedsub->sub_state == '' || $feedsub->sub_state == 'inactive' || $feedsub->sub_state == 'unsubscribe') {
|
||||
return true;
|
||||
} else if ($feedsub->sub_state == 'subscribe') {
|
||||
throw new FeedSubException("Feed is awaiting subscription, can't unsub...");
|
||||
}
|
||||
}
|
||||
|
||||
|
|
|
@ -102,7 +102,7 @@ class DiscoveryHints {
|
|||
if (array_key_exists('url', $hcard)) {
|
||||
if (is_string($hcard['url'])) {
|
||||
$hints['homepage'] = $hcard['url'];
|
||||
} else if (is_array($hcard['url'])) {
|
||||
} else if (is_array($hcard['url']) && !empty($hcard['url'])) {
|
||||
// HACK get the last one; that's how our hcards look
|
||||
$hints['homepage'] = $hcard['url'][count($hcard['url'])-1];
|
||||
}
|
||||
|
@ -231,7 +231,7 @@ class DiscoveryHints {
|
|||
|
||||
// If it's got a scheme, use it
|
||||
|
||||
if ($parts['scheme'] != '') {
|
||||
if (!empty($parts['scheme'])) {
|
||||
return $rel;
|
||||
}
|
||||
|
||||
|
|
|
@ -50,7 +50,7 @@ $encGroup = str_replace($marker, '%', $encGroup);
|
|||
$sql = "SELECT * FROM ostatus_profile WHERE uri LIKE '%s' OR uri LIKE '%s'";
|
||||
$oprofile->query(sprintf($sql, $encProfile, $encGroup));
|
||||
|
||||
echo "Found $oprofile->N bogus ostatus_profile entries:\n";
|
||||
echo "Found $oprofile->N bogus ostatus_profile entries for local users and groups:\n";
|
||||
|
||||
while ($oprofile->fetch()) {
|
||||
echo "$oprofile->uri";
|
||||
|
@ -58,7 +58,7 @@ while ($oprofile->fetch()) {
|
|||
if ($dry) {
|
||||
echo " (unchanged)\n";
|
||||
} else {
|
||||
echo " deleting...";
|
||||
echo " removing bogus ostatus_profile entry...";
|
||||
$evil = clone($oprofile);
|
||||
$evil->delete();
|
||||
echo " ok\n";
|
||||
|
|
Loading…
Reference in New Issue
Block a user