From c2de44a53042a30a1bf8e7e9384d2641c2004313 Mon Sep 17 00:00:00 2001 From: Evan Prodromou Date: Mon, 6 Sep 2010 09:59:08 -0400 Subject: [PATCH] remove NOOP function common_broadcast_notice() --- lib/implugin.php | 11 +++-------- lib/util.php | 5 ----- 2 files changed, 3 insertions(+), 13 deletions(-) diff --git a/lib/implugin.php b/lib/implugin.php index 72d1456f4d..2811e7d644 100644 --- a/lib/implugin.php +++ b/lib/implugin.php @@ -59,7 +59,6 @@ abstract class ImPlugin extends Plugin */ abstract function normalize($screenname); - /** * validate (ensure the validity of) a screenname * @@ -107,7 +106,7 @@ abstract class ImPlugin extends Plugin * receive a raw message * Raw IM data is taken from the incoming queue, and passed to this function. * It should parse the raw message and call handleIncoming() - * + * * Returning false may CAUSE REPROCESSING OF THE QUEUE ITEM, and should * be used for temporary failures only. For permanent failures such as * unrecognized addresses, return true to indicate your processing has @@ -135,7 +134,7 @@ abstract class ImPlugin extends Plugin */ function microiduri($screenname) { - return $this->transport . ':' . $screenname; + return $this->transport . ':' . $screenname; } //========================UTILITY FUNCTIONS USEFUL TO IMPLEMENTATIONS - MISC ========================\ @@ -180,7 +179,6 @@ abstract class ImPlugin extends Plugin } } - /** * given a screenname, get the User_im_prefs object for this transport * @@ -200,7 +198,6 @@ abstract class ImPlugin extends Plugin } } - /** * given a User, get their screenname * @@ -218,7 +215,6 @@ abstract class ImPlugin extends Plugin } } - /** * given a User, get their User_im_prefs * @@ -500,7 +496,6 @@ abstract class ImPlugin extends Plugin return; } - common_broadcast_notice($notice); common_log(LOG_INFO, 'Added notice ' . $notice->id . ' from user ' . $user->nickname); $notice->free(); @@ -508,7 +503,7 @@ abstract class ImPlugin extends Plugin } //========================EVENT HANDLERS========================\ - + /** * Register notice queue handler * diff --git a/lib/util.php b/lib/util.php index d56c9124d2..a5e29a7818 100644 --- a/lib/util.php +++ b/lib/util.php @@ -1251,11 +1251,6 @@ function common_redirect($url, $code=307) exit; } -function common_broadcast_notice($notice, $remote=false) -{ - // DO NOTHING! -} - // Stick the notice on the queue function common_enqueue_notice($notice)