Function declarations not matching their parents

This commit is contained in:
Mikael Nordfeldth 2015-06-06 22:14:56 +02:00
parent 871912a00a
commit d76d37340a
7 changed files with 11 additions and 18 deletions

View File

@ -49,16 +49,9 @@ class ApiconversationAction extends ApiAuthAction
protected $conversation = null;
protected $notices = null;
/**
* For initializing members of the class.
*
* @param array $argarray misc. arguments
*
* @return boolean true
*/
function prepare($argarray)
protected function prepare(array $args=array())
{
parent::prepare($argarray);
parent::prepare($args);
$convId = $this->trimmed('id');

View File

@ -97,7 +97,7 @@ class ConversationAction extends ManagedAction
Event::handle('EndShowConversation', array($this, $this->conv, $this->scoped));
}
function isReadOnly()
function isReadOnly($args)
{
return true;
}

View File

@ -72,9 +72,9 @@ class ClientErrorAction extends ErrorAction
// XXX: Should these error actions even be invokable via URI?
function handle($args)
protected function handle()
{
parent::handle($args);
parent::handle();
$this->code = $this->trimmed('code');

View File

@ -48,7 +48,7 @@ if (!defined('STATUSNET')) {
class FullThreadedNoticeList extends ThreadedNoticeList
{
function newListItem($notice)
function newListItem(Notice $notice)
{
return new FullThreadedNoticeListItem($notice, $this->out, $this->userProfile);
}

View File

@ -78,9 +78,9 @@ class ServerErrorAction extends ErrorAction
// XXX: Should these error actions even be invokable via URI?
function handle($args)
protected function handle()
{
parent::handle($args);
parent::handle();
$this->code = $this->trimmed('code');

View File

@ -43,7 +43,7 @@ if (!defined('STATUSNET') && !defined('LACONICA')) {
class WAP20Plugin extends Plugin
{
function onStartShowHTML($action)
function onStartShowHTML(Action $action)
{
}

View File

@ -260,7 +260,7 @@ class QnAPlugin extends MicroAppPlugin
* @return boolean hook value
*/
function onStartOpenNoticeListItemElement($nli)
function onStartOpenNoticeListItemElement(NoticeListItem $nli)
{
$type = $nli->notice->object_type;
@ -325,7 +325,7 @@ class QnAPlugin extends MicroAppPlugin
*
* @todo FIXME: WARNING WARNING WARNING this closes a 'div' that is implicitly opened in BookmarkPlugin's showNotice implementation
*/
function onStartShowNoticeItem($nli)
function onStartShowNoticeItem(NoticeListItem $nli)
{
if (!$this->isMyNotice($nli->notice)) {
return true;