From d9668a6d07c0500aba56a9fde372abe7bdb6e5f6 Mon Sep 17 00:00:00 2001
From: Miguel Dantas <biodantasgs@gmail.com>
Date: Sat, 24 Aug 2019 00:01:24 +0100
Subject: [PATCH] [URLMAPPER] Fix small bug in URLMapper: a dynamic route might
 not exist even if a static one does

---
 lib/urlmapper.php | 88 ++++++++++++++++++++++++-----------------------
 1 file changed, 45 insertions(+), 43 deletions(-)

diff --git a/lib/urlmapper.php b/lib/urlmapper.php
index d37b0fb337..1f7293526b 100644
--- a/lib/urlmapper.php
+++ b/lib/urlmapper.php
@@ -169,60 +169,62 @@ class URLMapper
             throw new Exception(sprintf('No candidate paths for action "%s"', $action));
         }
 
-        $candidates = $this->reverse_dynamics[$action];
+        if (array_key_exists($action, $this->reverse_dynamics)){
+            $candidates = $this->reverse_dynamics[$action];
+            foreach ($candidates as $candidate) {
+                list($tryArgs, $format, $paramNames) = $candidate;
 
-        foreach ($candidates as $candidate) {
-            list($tryArgs, $format, $paramNames) = $candidate;
-
-            foreach ($tryArgs as $key => $value) {
-                if (!array_key_exists($key, $args) || $args[$key] != $value) {
-                    // next candidate
-                    continue 2;
+                foreach ($tryArgs as $key => $value) {
+                    if (!array_key_exists($key, $args) || $args[$key] != $value) {
+                        // next candidate
+                        continue 2;
+                    }
                 }
-            }
 
-            // success
-            $toFormat = [];
+                // success
+                $toFormat = [];
 
-            foreach ($paramNames as $name) {
-                if (!array_key_exists($name, $args)) {
-                    // next candidate
-                    continue 2;
+                foreach ($paramNames as $name) {
+                    if (!array_key_exists($name, $args)) {
+                        // next candidate
+                        continue 2;
+                    }
+                    $toFormat[] = $args[$name];
                 }
-                $toFormat[] = $args[$name];
+
+                $path = vsprintf($format, $toFormat);
+
+                if (!empty($qstring)) {
+                    $formatted = http_build_query($qstring);
+                    $path .= '?' . $formatted;
+                }
+
+                return $path;
             }
-
-            $path = vsprintf($format, $toFormat);
-
-            if (!empty($qstring)) {
-                $formatted = http_build_query($qstring);
-                $path .= '?' . $formatted;
-            }
-
-            return $path;
         }
 
-        $candidates = $this->reverse_statics[$action];
+        if (array_key_exists($action, $this->reverse_statics)) {
+            $candidates = $this->reverse_statics[$action];
+            foreach ($candidates as $candidate) {
+                list($tryArgs, $tryPath) = $candidate;
 
-        foreach ($candidates as $candidate) {
-            list($tryArgs, $tryPath) = $candidate;
-
-            foreach ($tryArgs as $key => $value) {
-                if (!array_key_exists($key, $args) || $args[$key] != $value) {
-                    // next candidate
-                    continue 2;
+                foreach ($tryArgs as $key => $value) {
+                    if (!array_key_exists($key, $args) || $args[$key] != $value) {
+                        // next candidate
+                        continue 2;
+                    }
                 }
+
+                // success
+                $path = $tryPath;
+
+                if (!empty($qstring)) {
+                    $formatted = http_build_query($qstring);
+                    $path .= '?' . $formatted;
+                }
+
+                return $path;
             }
-
-            // success
-            $path = $tryPath;
-
-            if (!empty($qstring)) {
-                $formatted = http_build_query($qstring);
-                $path .= '?' . $formatted;
-            }
-
-            return $path;
         }
 
         // failure; some reporting twiddles