From b7dd4d2ad1e93771cdff11198e7fdf81ca8633de Mon Sep 17 00:00:00 2001
From: sarven <csarven@plantard.controlezvous.ca>
Date: Fri, 16 Jan 2009 23:13:22 +0000
Subject: [PATCH 01/19] Fix to put @class current on the navigation of the page
 viewed

---
 lib/action.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/action.php b/lib/action.php
index 5ff536dab2..fce9df4da7 100644
--- a/lib/action.php
+++ b/lib/action.php
@@ -566,7 +566,7 @@ class Action extends HTMLOutputter // lawsuit
             $lattrs['class'] = 'current';
         }
 
-        $this->elementStart('li', (is_null($id)) ? null : array('id' => $id),  $lattrs);
+        $this->elementStart('li', (is_null($id)) ? $lattrs : array_merge(array('id' => $id), $lattrs));
         $attrs['href'] = $url;
         if ($title) {
             $attrs['title'] = $title;

From 9881932d0734f515dc03e71551cfa7d04472f9a9 Mon Sep 17 00:00:00 2001
From: sarven <csarven@plantard.controlezvous.ca>
Date: Fri, 16 Jan 2009 23:23:02 +0000
Subject: [PATCH 02/19] Minor

---
 lib/action.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/action.php b/lib/action.php
index fce9df4da7..1622047c0c 100644
--- a/lib/action.php
+++ b/lib/action.php
@@ -565,8 +565,8 @@ class Action extends HTMLOutputter // lawsuit
         if ($is_selected) {
             $lattrs['class'] = 'current';
         }
-
-        $this->elementStart('li', (is_null($id)) ? $lattrs : array_merge(array('id' => $id), $lattrs));
+        (is_null($id)) ? $lattrs : $lattrs['id'] = $id;
+        $this->elementStart('li', $lattrs);
         $attrs['href'] = $url;
         if ($title) {
             $attrs['title'] = $title;

From f46fd284e4395a113cdcc6e019d6f1b4b9ef8ff6 Mon Sep 17 00:00:00 2001
From: sarven <csarven@plantard.controlezvous.ca>
Date: Fri, 16 Jan 2009 23:41:46 +0000
Subject: [PATCH 03/19] Update to forms and email settings

---
 actions/emailsettings.php  | 50 +++++++++++++++++++++++++++-----------
 lib/htmloutputter.php      | 21 ++++------------
 lib/settingsgroupnav.php   |  4 +--
 theme/base/css/display.css |  9 ++++++-
 4 files changed, 51 insertions(+), 33 deletions(-)

diff --git a/actions/emailsettings.php b/actions/emailsettings.php
index 4cd63a9d3b..d03d5ff842 100644
--- a/actions/emailsettings.php
+++ b/actions/emailsettings.php
@@ -85,42 +85,46 @@ class EmailsettingsAction extends SettingsAction
         $user = common_current_user();
 
         $this->elementStart('form', array('method' => 'post',
-                                          'id' => 'emailsettings',
+                                          'id' => 'form_settings_email',
+                                          'class' => 'form_settings',
                                           'action' =>
                                           common_local_url('emailsettings')));
-
+        $this->elementStart('fieldset');
+        $this->element('legend', null, _('Email settings'));
         $this->hidden('token', common_session_token());
 
+        $this->elementStart('div', array('id' => 'settings_email_address'));
         $this->element('h2', null, _('Address'));
 
         if ($user->email) {
-            $this->elementStart('p');
-            $this->element('span', 'address confirmed', $user->email);
-            $this->element('span', 'input_instructions',
-                           _('Current confirmed email address.'));
+            $this->element('p', array('id' => 'email_confirmed', $user->email));
+            $this->element('p', array('class' => 'form_note'), _('Current confirmed email address.'));
             $this->hidden('email', $user->email);
-            $this->elementEnd('p');
             $this->submit('remove', _('Remove'));
         } else {
             $confirm = $this->getConfirmation();
             if ($confirm) {
-                $this->elementStart('p');
-                $this->element('span', 'address unconfirmed', $confirm->address);
-                $this->element('span', 'input_instructions',
-                               _('Awaiting confirmation on this address. '.
-                                 'Check your inbox (and spam box!) for a message '.
-                                 'with further instructions.'));
+                $this->element('p', array('id' => 'email_unconfirmed'), $confirm->address);
+                $this->element('p', array('class' => 'form_note'), 
+                                        _('Awaiting confirmation on this address. '.
+                                        'Check your inbox (and spam box!) for a message '.
+                                        'with further instructions.'));
                 $this->hidden('email', $confirm->address);
-                $this->elementEnd('p');
                 $this->submit('cancel', _('Cancel'));
             } else {
+                $this->elementStart('ul', 'form_datas');
+                $this->elementStart('li');
                 $this->input('email', _('Email Address'),
                              ($this->arg('email')) ? $this->arg('email') : null,
                              _('Email address, like "UserName@example.org"'));
+                $this->elementEnd('li');
+                $this->elementEnd('ul');
                 $this->submit('add', _('Add'));
             }
         }
+        $this->elementEnd('div');
 
+        $this->elementStart('div', array('id' => 'settings_email_incoming'));
         if ($user->email) {
             $this->element('h2', null, _('Incoming email'));
 
@@ -140,31 +144,49 @@ class EmailsettingsAction extends SettingsAction
             $this->elementEnd('p');
             $this->submit('newincoming', _('New'));
         }
+        $this->elementEnd('div');
 
+        $this->elementStart('div', array('id' => 'settings_email_preferences'));
         $this->element('h2', null, _('Preferences'));
 
+        $this->elementStart('ul', 'form_datas');
+        $this->elementStart('li');
         $this->checkbox('emailnotifysub',
                         _('Send me notices of new subscriptions through email.'),
                         $user->emailnotifysub);
+        $this->elementEnd('li');
+        $this->elementStart('li');
         $this->checkbox('emailnotifyfav',
                         _('Send me email when someone '.
                           'adds my notice as a favorite.'),
                         $user->emailnotifyfav);
+        $this->elementEnd('li');
+        $this->elementStart('li');
         $this->checkbox('emailnotifymsg',
                         _('Send me email when someone sends me a private message.'),
                         $user->emailnotifymsg);
+        $this->elementEnd('li');
+        $this->elementStart('li');
         $this->checkbox('emailnotifynudge',
                         _('Allow friends to nudge me and send me an email.'),
                         $user->emailnotifynudge);
+        $this->elementEnd('li');
+        $this->elementStart('li');
         $this->checkbox('emailpost',
                         _('I want to post notices by email.'),
                         $user->emailpost);
+        $this->elementEnd('li');
+        $this->elementStart('li');
         $this->checkbox('emailmicroid',
                         _('Publish a MicroID for my email address.'),
                         $user->emailmicroid);
+        $this->elementEnd('li');
+        $this->elementEnd('ul');
+        $this->elementEnd('div');
 
         $this->submit('save', _('Save'));
 
+        $this->elementEnd('fieldset');
         $this->elementEnd('form');
     }
 
diff --git a/lib/htmloutputter.php b/lib/htmloutputter.php
index eb8a612e4f..37853f345f 100644
--- a/lib/htmloutputter.php
+++ b/lib/htmloutputter.php
@@ -155,20 +155,17 @@ class HTMLOutputter extends XMLOutputter
 
     function input($id, $label, $value=null, $instructions=null)
     {
-        $this->elementStart('p');
         $this->element('label', array('for' => $id), $label);
         $attrs = array('name' => $id,
                        'type' => 'text',
-                       'class' => 'input_text',
                        'id' => $id);
         if ($value) {
             $attrs['value'] = htmlspecialchars($value);
         }
         $this->element('input', $attrs);
         if ($instructions) {
-            $this->element('span', 'input_instructions', $instructions);
+            $this->element('p', 'form_guide', $instructions);
         }
-        $this->elementEnd('p');
     }
 
     /**
@@ -192,7 +189,6 @@ class HTMLOutputter extends XMLOutputter
     function checkbox($id, $label, $checked=false, $instructions=null,
                       $value='true', $disabled=false)
     {
-        $this->elementStart('p');
         $attrs = array('name' => $id,
                        'type' => 'checkbox',
                        'class' => 'checkbox',
@@ -213,9 +209,8 @@ class HTMLOutputter extends XMLOutputter
                        $label);
         $this->text(' ');
         if ($instructions) {
-            $this->element('span', 'input_instructions', $instructions);
+            $this->element('p', 'form_guide', $instructions);
         }
-        $this->elementEnd('p');
     }
 
     /**
@@ -240,7 +235,6 @@ class HTMLOutputter extends XMLOutputter
     function dropdown($id, $label, $content, $instructions=null,
                       $blank_select=false, $selected=null)
     {
-        $this->elementStart('p');
         $this->element('label', array('for' => $id), $label);
         $this->elementStart('select', array('id' => $id, 'name' => $id));
         if ($blank_select) {
@@ -257,9 +251,8 @@ class HTMLOutputter extends XMLOutputter
         }
         $this->elementEnd('select');
         if ($instructions) {
-            $this->element('span', 'input_instructions', $instructions);
+            $this->element('p', 'form_guide', $instructions);
         }
-        $this->elementEnd('p');
     }
 
     /**
@@ -296,7 +289,6 @@ class HTMLOutputter extends XMLOutputter
 
     function password($id, $label, $instructions=null)
     {
-        $this->elementStart('p');
         $this->element('label', array('for' => $id), $label);
         $attrs = array('name' => $id,
                        'type' => 'password',
@@ -304,9 +296,8 @@ class HTMLOutputter extends XMLOutputter
                        'id' => $id);
         $this->element('input', $attrs);
         if ($instructions) {
-            $this->element('span', 'input_instructions', $instructions);
+            $this->element('p', 'form_guide', $instructions);
         }
-        $this->elementEnd('p');
     }
 
     /**
@@ -348,7 +339,6 @@ class HTMLOutputter extends XMLOutputter
 
     function textarea($id, $label, $content=null, $instructions=null)
     {
-        $this->elementStart('p');
         $this->element('label', array('for' => $id), $label);
         $this->element('textarea', array('rows' => 3,
                                          'cols' => 40,
@@ -356,8 +346,7 @@ class HTMLOutputter extends XMLOutputter
                                          'id' => $id),
                        ($content) ? $content : '');
         if ($instructions) {
-            $this->element('span', 'input_instructions', $instructions);
+            $this->element('p', 'form_guide', $instructions);
         }
-        $this->elementEnd('p');
     }
 }
diff --git a/lib/settingsgroupnav.php b/lib/settingsgroupnav.php
index 044c74552a..bd66c65a65 100644
--- a/lib/settingsgroupnav.php
+++ b/lib/settingsgroupnav.php
@@ -94,7 +94,7 @@ class SettingsGroupNav extends Widget
                       _('Other options')));
         
         $action_name = $this->action->trimmed('action');
-        $this->action->elementStart('ul', array('id' => 'nav_views'));
+        $this->action->elementStart('ul', array('class' => 'nav'));
 	
         foreach ($menu as $menuaction => $menudesc) {
             if ($menuaction == 'imsettings' &&
@@ -104,7 +104,7 @@ class SettingsGroupNav extends Widget
             $this->action->menuItem(common_local_url($menuaction),
 				    $menudesc[0],
 				    $menudesc[1],
-				    $action_name == $menuaction);
+				    $action_name === $menuaction);
         }
 	
         $this->action->elementEnd('ul');
diff --git a/theme/base/css/display.css b/theme/base/css/display.css
index b8b260266c..027cb16662 100644
--- a/theme/base/css/display.css
+++ b/theme/base/css/display.css
@@ -100,7 +100,7 @@ border:0;
 display:none;
 }
 .form_settings .form_datas label {
-display:block;
+
 }
 
 .form_guide {
@@ -116,6 +116,13 @@ display:inline;
 font-weight:bold;
 }
 
+.form_settings p {
+margin-bottom:18px;
+}
+
+#settings_email_address {
+margin-bottom:29px;
+}
 
 
 /* FORM SETTINGS */

From 0a5125675b4165be4c8278edf8d30f33483081fa Mon Sep 17 00:00:00 2001
From: sarven <csarven@plantard.controlezvous.ca>
Date: Sat, 17 Jan 2009 00:01:53 +0000
Subject: [PATCH 04/19] Updates to form styling

---
 actions/emailsettings.php  | 28 ++++++++++++----------------
 lib/htmloutputter.php      |  2 +-
 theme/base/css/display.css | 13 ++++++++++++-
 3 files changed, 25 insertions(+), 18 deletions(-)

diff --git a/actions/emailsettings.php b/actions/emailsettings.php
index d03d5ff842..090df30dd2 100644
--- a/actions/emailsettings.php
+++ b/actions/emailsettings.php
@@ -89,12 +89,10 @@ class EmailsettingsAction extends SettingsAction
                                           'class' => 'form_settings',
                                           'action' =>
                                           common_local_url('emailsettings')));
-        $this->elementStart('fieldset');
-        $this->element('legend', null, _('Email settings'));
-        $this->hidden('token', common_session_token());
 
-        $this->elementStart('div', array('id' => 'settings_email_address'));
-        $this->element('h2', null, _('Address'));
+        $this->elementStart('fieldset',array('id' => 'settings_email_address'));
+        $this->element('legend', null, _('Address'));
+        $this->hidden('token', common_session_token());
 
         if ($user->email) {
             $this->element('p', array('id' => 'email_confirmed', $user->email));
@@ -122,12 +120,11 @@ class EmailsettingsAction extends SettingsAction
                 $this->submit('add', _('Add'));
             }
         }
-        $this->elementEnd('div');
-
-        $this->elementStart('div', array('id' => 'settings_email_incoming'));
-        if ($user->email) {
-            $this->element('h2', null, _('Incoming email'));
+        $this->elementEnd('fieldset');
 
+       if ($user->email) {
+            $this->elementStart('fieldset',array('id' => 'settings_email_incoming'));
+            $this->element('legend',_('Incoming email'));
             if ($user->incomingemail) {
                 $this->elementStart('p');
                 $this->element('span', 'address', $user->incomingemail);
@@ -143,11 +140,12 @@ class EmailsettingsAction extends SettingsAction
                              'cancels the old one.'));
             $this->elementEnd('p');
             $this->submit('newincoming', _('New'));
+            $this->elementEnd('fieldset');
         }
-        $this->elementEnd('div');
 
-        $this->elementStart('div', array('id' => 'settings_email_preferences'));
-        $this->element('h2', null, _('Preferences'));
+
+        $this->elementStart('fieldset', array('id' => 'settings_email_preferences'));
+        $this->element('legend', null, _('Preferences'));
 
         $this->elementStart('ul', 'form_datas');
         $this->elementStart('li');
@@ -182,11 +180,9 @@ class EmailsettingsAction extends SettingsAction
                         $user->emailmicroid);
         $this->elementEnd('li');
         $this->elementEnd('ul');
-        $this->elementEnd('div');
+        $this->elementEnd('fieldset');
 
         $this->submit('save', _('Save'));
-
-        $this->elementEnd('fieldset');
         $this->elementEnd('form');
     }
 
diff --git a/lib/htmloutputter.php b/lib/htmloutputter.php
index 37853f345f..71f17604ba 100644
--- a/lib/htmloutputter.php
+++ b/lib/htmloutputter.php
@@ -204,7 +204,7 @@ class HTMLOutputter extends XMLOutputter
         }
         $this->element('input', $attrs);
         $this->text(' ');
-        $this->element('label', array('class' => 'checkbox_label',
+        $this->element('label', array('class' => 'checkbox',
                                       'for' => $id),
                        $label);
         $this->text(' ');
diff --git a/theme/base/css/display.css b/theme/base/css/display.css
index 027cb16662..294119c550 100644
--- a/theme/base/css/display.css
+++ b/theme/base/css/display.css
@@ -64,6 +64,13 @@ font-weight:bold;
 }
 form ul li input {
 }
+
+form input.checkbox {
+position:relative;
+top:2px;
+left:0;
+}
+
 form .error {
 margin-right:11px;
 }
@@ -97,7 +104,8 @@ padding:0;
 border:0;
 }
 .form_settings legend {
-display:none;
+font-size:1.6em;
+text-transform:uppercase;
 }
 .form_settings .form_datas label {
 
@@ -124,6 +132,9 @@ margin-bottom:18px;
 margin-bottom:29px;
 }
 
+#settings_email_preferences label {
+font-weight:normal;
+}
 
 /* FORM SETTINGS */
 

From 2561199e59ce6c4f4390443bda6d17d709ce1e36 Mon Sep 17 00:00:00 2001
From: sarven <csarven@plantard.controlezvous.ca>
Date: Sat, 17 Jan 2009 00:06:31 +0000
Subject: [PATCH 05/19] OpenID form settings markup

---
 actions/openidsettings.php | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/actions/openidsettings.php b/actions/openidsettings.php
index a21a9869e3..f24c817954 100644
--- a/actions/openidsettings.php
+++ b/actions/openidsettings.php
@@ -85,26 +85,31 @@ class OpenidsettingsAction extends SettingsAction
         $user = common_current_user();
 
         $this->elementStart('form', array('method' => 'post',
-                                          'id' => 'openidadd',
+                                          'id' => 'form_openid_add',
+                                          'class' => 'form_settings',
                                           'action' =>
                                           common_local_url('openidsettings')));
+        $this->elementStart('fieldset');
+        $this->element('legend', null, _('Add OpenID'));
         $this->hidden('token', common_session_token());
-        $this->element('h2', null, _('Add OpenID'));
-        $this->element('p', null,
+        $this->element('p', 'form_guide',
                        _('If you want to add an OpenID to your account, ' .
                          'enter it in the box below and click "Add".'));
-        $this->elementStart('p');
+        $this->elementStart('ul', 'form_datas');
+        $this->elementStart('li');
         $this->element('label', array('for' => 'openid_url'),
                        _('OpenID URL'));
         $this->element('input', array('name' => 'openid_url',
                                       'type' => 'text',
                                       'id' => 'openid_url'));
+        $this->elementEnd('li');
+        $this->elementEnd('ul');
         $this->element('input', array('type' => 'submit',
                                       'id' => 'add',
                                       'name' => 'add',
                                       'class' => 'submit',
                                       'value' => _('Add')));
-        $this->elementEnd('p');
+        $this->elementEnd('fieldset');
         $this->elementEnd('form');
 
         $oid = new User_openid();

From b9fb70ee70ecd465f5843241b308f2b8680120f6 Mon Sep 17 00:00:00 2001
From: sarven <csarven@plantard.controlezvous.ca>
Date: Sat, 17 Jan 2009 00:46:33 +0000
Subject: [PATCH 06/19] Markup clean up and styles

---
 actions/emailsettings.php  |  7 +++----
 actions/openidsettings.php | 15 ++++++++-------
 lib/action.php             |  3 +--
 theme/base/css/display.css |  4 ++++
 4 files changed, 16 insertions(+), 13 deletions(-)

diff --git a/actions/emailsettings.php b/actions/emailsettings.php
index 090df30dd2..3554708156 100644
--- a/actions/emailsettings.php
+++ b/actions/emailsettings.php
@@ -90,7 +90,7 @@ class EmailsettingsAction extends SettingsAction
                                           'action' =>
                                           common_local_url('emailsettings')));
 
-        $this->elementStart('fieldset',array('id' => 'settings_email_address'));
+        $this->elementStart('fieldset', array('id' => 'settings_email_address'));
         $this->element('legend', null, _('Address'));
         $this->hidden('token', common_session_token());
 
@@ -123,7 +123,7 @@ class EmailsettingsAction extends SettingsAction
         $this->elementEnd('fieldset');
 
        if ($user->email) {
-            $this->elementStart('fieldset',array('id' => 'settings_email_incoming'));
+            $this->elementStart('fieldset', array('id' => 'settings_email_incoming'));
             $this->element('legend',_('Incoming email'));
             if ($user->incomingemail) {
                 $this->elementStart('p');
@@ -180,9 +180,8 @@ class EmailsettingsAction extends SettingsAction
                         $user->emailmicroid);
         $this->elementEnd('li');
         $this->elementEnd('ul');
-        $this->elementEnd('fieldset');
-
         $this->submit('save', _('Save'));
+        $this->elementEnd('fieldset');
         $this->elementEnd('form');
     }
 
diff --git a/actions/openidsettings.php b/actions/openidsettings.php
index f24c817954..6f17f154ca 100644
--- a/actions/openidsettings.php
+++ b/actions/openidsettings.php
@@ -85,11 +85,11 @@ class OpenidsettingsAction extends SettingsAction
         $user = common_current_user();
 
         $this->elementStart('form', array('method' => 'post',
-                                          'id' => 'form_openid_add',
+                                          'id' => 'form_settings_openid_add',
                                           'class' => 'form_settings',
                                           'action' =>
                                           common_local_url('openidsettings')));
-        $this->elementStart('fieldset');
+        $this->elementStart('fieldset', array('id' => 'settings_openid_add'));
         $this->element('legend', null, _('Add OpenID'));
         $this->hidden('token', common_session_token());
         $this->element('p', 'form_guide',
@@ -105,7 +105,7 @@ class OpenidsettingsAction extends SettingsAction
         $this->elementEnd('li');
         $this->elementEnd('ul');
         $this->element('input', array('type' => 'submit',
-                                      'id' => 'add',
+                                      'id' => 'settings_openid_add_action-submit',
                                       'name' => 'add',
                                       'class' => 'submit',
                                       'value' => _('Add')));
@@ -139,7 +139,7 @@ class OpenidsettingsAction extends SettingsAction
 
             } else {
 
-                $this->element('p', null,
+                $this->element('p', 'form_guide',
                                _('You can remove an OpenID from your account '.
                                  'by clicking the button marked "Remove".'));
                 $idx = 0;
@@ -147,10 +147,11 @@ class OpenidsettingsAction extends SettingsAction
                 while ($oid->fetch()) {
                     $this->elementStart('form',
                                         array('method' => 'POST',
-                                              'id' => 'openiddelete' . $idx,
+                                              'id' => 'form_settings_openid_delete' . $idx,
+                                              'class' => 'form_settings',
                                               'action' =>
                                               common_local_url('openidsettings')));
-                    $this->elementStart('p');
+                    $this->elementStart('fieldset');
                     $this->hidden('token', common_session_token());
                     $this->element('a', array('href' => $oid->canonical),
                                    $oid->display);
@@ -163,7 +164,7 @@ class OpenidsettingsAction extends SettingsAction
                                                   'name' => 'remove',
                                                   'class' => 'submit',
                                                   'value' => _('Remove')));
-                    $this->elementEnd('p');
+                    $this->elementEnd('fieldset');
                     $this->elementEnd('form');
                     $idx++;
                 }
diff --git a/lib/action.php b/lib/action.php
index 1622047c0c..35f6f2e3ec 100644
--- a/lib/action.php
+++ b/lib/action.php
@@ -565,8 +565,7 @@ class Action extends HTMLOutputter // lawsuit
         if ($is_selected) {
             $lattrs['class'] = 'current';
         }
-        (is_null($id)) ? $lattrs : $lattrs['id'] = $id;
-        $this->elementStart('li', $lattrs);
+        $this->elementStart('li', (is_null($id)) ? $lattrs : $lattr['id'] = $id);
         $attrs['href'] = $url;
         if ($title) {
             $attrs['title'] = $title;
diff --git a/theme/base/css/display.css b/theme/base/css/display.css
index 294119c550..3aee52088a 100644
--- a/theme/base/css/display.css
+++ b/theme/base/css/display.css
@@ -99,6 +99,10 @@ form input.submit {
 
 
 /* FORM SETTINGS */
+.form_settings {
+margin-bottom:29px;
+}
+
 .form_settings fieldset {
 padding:0;
 border:0;

From 0b947a33bc401faaddcae3bb5b39b9cbe2d5277c Mon Sep 17 00:00:00 2001
From: sarven <csarven@plantard.controlezvous.ca>
Date: Sat, 17 Jan 2009 00:49:48 +0000
Subject: [PATCH 07/19] Minor

---
 actions/smssettings.php | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/actions/smssettings.php b/actions/smssettings.php
index f214997ec6..d7c621b138 100644
--- a/actions/smssettings.php
+++ b/actions/smssettings.php
@@ -83,12 +83,14 @@ class SmssettingsAction extends SettingsAction
         $user = common_current_user();
 
         $this->elementStart('form', array('method' => 'post',
-                                          'id' => 'smssettings',
+                                          'id' => 'form_settings_sms',
+                                          'class' => 'form_settings',
                                           'action' =>
                                           common_local_url('smssettings')));
 
+        $this->elementStart('fieldset');
+        $this->element('legend', null, _('Address'));
         $this->hidden('token', common_session_token());
-        $this->element('h2', null, _('Address'));
 
         if ($user->sms) {
             $this->elementStart('p');
@@ -126,6 +128,7 @@ class SmssettingsAction extends SettingsAction
                 $this->submit('add', _('Add'));
             }
         }
+        $this->elementEnd('fieldset');
 
         if ($user->sms) {
             $this->element('h2', null, _('Incoming email'));
@@ -147,8 +150,8 @@ class SmssettingsAction extends SettingsAction
             $this->submit('newincoming', _('New'));
         }
 
-        $this->element('h2', null, _('Preferences'));
-
+        $this->elementStart('fieldset', array('id' => 'sms_preferences'));
+        $this->element('legend', null, _('Preferences'));
         $this->checkbox('smsnotify',
                         _('Send me notices through SMS; '.
                           'I understand I may incur '.
@@ -157,6 +160,7 @@ class SmssettingsAction extends SettingsAction
 
         $this->submit('save', _('Save'));
 
+        $this->elementEnd('fieldset');
         $this->elementEnd('form');
     }
 

From b2f16c523466f40589712a173a35c1b0bf54ea99 Mon Sep 17 00:00:00 2001
From: sarven <csarven@plantard.controlezvous.ca>
Date: Sat, 17 Jan 2009 01:08:55 +0000
Subject: [PATCH 08/19] SMS form settings

---
 actions/smssettings.php    | 24 +++++++++++++++---------
 theme/base/css/display.css |  7 ++-----
 2 files changed, 17 insertions(+), 14 deletions(-)

diff --git a/actions/smssettings.php b/actions/smssettings.php
index d7c621b138..6d3c549420 100644
--- a/actions/smssettings.php
+++ b/actions/smssettings.php
@@ -88,7 +88,7 @@ class SmssettingsAction extends SettingsAction
                                           'action' =>
                                           common_local_url('smssettings')));
 
-        $this->elementStart('fieldset');
+        $this->elementStart('fieldset', array('id' => 'settings_sms_address'));
         $this->element('legend', null, _('Address'));
         $this->hidden('token', common_session_token());
 
@@ -142,21 +142,25 @@ class SmssettingsAction extends SettingsAction
                 $this->submit('removeincoming', _('Remove'));
             }
 
-            $this->elementStart('p');
-            $this->element('span', 'input_instructions',
+            $this->element('p', 'form_guide',
                            _('Make a new email address for posting to; '.
                              'cancels the old one.'));
-            $this->elementEnd('p');
             $this->submit('newincoming', _('New'));
         }
 
-        $this->elementStart('fieldset', array('id' => 'sms_preferences'));
+        $this->elementStart('fieldset', array('id' => 'settings_sms_preferences'));
         $this->element('legend', null, _('Preferences'));
+
+
+        $this->elementStart('ul', 'form_datas');
+        $this->elementStart('li');
         $this->checkbox('smsnotify',
                         _('Send me notices through SMS; '.
                           'I understand I may incur '.
                           'exorbitant charges from my carrier.'),
                         $user->smsnotify);
+        $this->elementEnd('li');
+        $this->elementEnd('ul');
 
         $this->submit('save', _('Save'));
 
@@ -440,8 +444,9 @@ class SmssettingsAction extends SettingsAction
 
         $cnt = $carrier->find();
 
-        $this->elementStart('p');
-        $this->element('label', array('for' => 'carrier'));
+        $this->elementStart('ul');
+        $this->elementStart('li');
+        $this->element('label', array('for' => 'carrier'), _('Mobile carrier'));
         $this->elementStart('select', array('name' => 'carrier',
                                             'id' => 'carrier'));
         $this->element('option', array('value' => 0),
@@ -451,13 +456,14 @@ class SmssettingsAction extends SettingsAction
                            $carrier->name);
         }
         $this->elementEnd('select');
-        $this->elementEnd('p');
-        $this->element('span', 'input_instructions',
+        $this->element('p', 'form_guide',
                        sprintf(_('Mobile carrier for your phone. '.
                                  'If you know a carrier that accepts ' .
                                  'SMS over email but isn\'t listed here, ' .
                                  'send email to let us know at %s.'),
                                common_config('site', 'email')));
+        $this->elementEnd('li');
+        $this->elementEnd('ul');
     }
 
     /**
diff --git a/theme/base/css/display.css b/theme/base/css/display.css
index 3aee52088a..fce4c7b86f 100644
--- a/theme/base/css/display.css
+++ b/theme/base/css/display.css
@@ -99,13 +99,10 @@ form input.submit {
 
 
 /* FORM SETTINGS */
-.form_settings {
-margin-bottom:29px;
-}
-
 .form_settings fieldset {
 padding:0;
 border:0;
+margin-bottom:29px;
 }
 .form_settings legend {
 font-size:1.6em;
@@ -136,7 +133,7 @@ margin-bottom:18px;
 margin-bottom:29px;
 }
 
-#settings_email_preferences label {
+.form_settings label.checkbox {
 font-weight:normal;
 }
 

From 3e40a564bd7f727d2c967b6f70acc14d4b801d97 Mon Sep 17 00:00:00 2001
From: sarven <csarven@plantard.controlezvous.ca>
Date: Sat, 17 Jan 2009 01:50:21 +0000
Subject: [PATCH 09/19] twitter settings markup

---
 actions/twittersettings.php | 39 ++++++++++++++++++++++++-------------
 1 file changed, 26 insertions(+), 13 deletions(-)

diff --git a/actions/twittersettings.php b/actions/twittersettings.php
index 5492dd9958..cd070cb450 100644
--- a/actions/twittersettings.php
+++ b/actions/twittersettings.php
@@ -97,58 +97,71 @@ class TwittersettingsAction extends SettingsAction
         }
 
         $this->elementStart('form', array('method' => 'post',
-                                          'id' => 'twittersettings',
+                                          'id' => 'form_settings_twitter',
+                                          'class' => 'form_settings',
                                           'action' =>
                                           common_local_url('twittersettings')));
+        $this->elementStart('fieldset', array('id' => 'settings_twitter_account'));
+        $this->element('legend', null, _('Twitter Account'));
         $this->hidden('token', common_session_token());
-
-        $this->element('h2', null, _('Twitter Account'));
-
+        $this->elementStart('ul', 'form_datas');
         if ($fuser) {
-            $this->elementStart('p');
-
+            $this->elementStart('li');
             $this->element('span', 'twitter_user', $fuser->nickname);
             $this->element('a', array('href' => $fuser->uri), $fuser->uri);
-            $this->element('span', 'input_instructions',
+            $this->element('p', 'form_guide',
                            _('Current verified Twitter account.'));
             $this->hidden('flink_foreign_id', $flink->foreign_id);
-            $this->elementEnd('p');
             $this->submit('remove', _('Remove'));
+            $this->elementEnd('li');
         } else {
+            $this->elementStart('li');
             $this->input('twitter_username', _('Twitter user name'),
                          ($this->arg('twitter_username')) ?
                          $this->arg('twitter_username') :
                          $profile->nickname,
                          _('No spaces, please.')); // hey, it's what Twitter says
-
+            $this->elementEnd('li');
+            $this->elementStart('li');
             $this->password('twitter_password', _('Twitter password'));
+            $this->elementend('li');
         }
+        $this->elementEnd('ul');
+        $this->elementEnd('fieldset');
 
-        $this->element('h2', null, _('Preferences'));
+        $this->elementStart('fieldset', array('id' => 'settings_twitter_preferences'));
+        $this->element('legend', null, _('Preferences'));
 
+        $this->elementStart('ul');
+        $this->elementStart('li');
         $this->checkbox('noticesync',
                         _('Automatically send my notices to Twitter.'),
                         ($flink) ?
                         ($flink->noticesync & FOREIGN_NOTICE_SEND) :
                         true);
-
+        $this->elementEnd('li');
+        $this->elementStart('li');
         $this->checkbox('replysync',
                         _('Send local "@" replies to Twitter.'),
                         ($flink) ?
                         ($flink->noticesync & FOREIGN_NOTICE_SEND_REPLY) :
                         true);
-
+        $this->elementEnd('li');
+        $this->elementStart('li');
         $this->checkbox('friendsync',
                         _('Subscribe to my Twitter friends here.'),
                         ($flink) ?
                         ($flink->friendsync & FOREIGN_FRIEND_RECV) :
                         false);
+        $this->elementEnd('li');
+        $this->elementEnd('ul');
 
         if ($flink) {
             $this->submit('save', _('Save'));
         } else {
             $this->submit('add', _('Add'));
         }
+        $this->elementEnd('fieldset');
 
         $this->showTwitterSubscriptions();
 
@@ -481,4 +494,4 @@ class TwittersettingsAction extends SettingsAction
         return false;
     }
 
-}
\ No newline at end of file
+}

From 996eb1da4ea043360dbc7accf9254537d59c7df5 Mon Sep 17 00:00:00 2001
From: sarven <csarven@plantard.controlezvous.ca>
Date: Sat, 17 Jan 2009 02:13:02 +0000
Subject: [PATCH 10/19] site nav local views styles -- rgba background color

---
 theme/base/css/display.css     | 3 ++-
 theme/identica/css/display.css | 4 ++++
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/theme/base/css/display.css b/theme/base/css/display.css
index fce4c7b86f..fb7e71acd4 100644
--- a/theme/base/css/display.css
+++ b/theme/base/css/display.css
@@ -219,8 +219,9 @@ padding:4px 11px;
 -moz-border-radius-topleft:4px;
 -moz-border-radius-topright:4px;
 border-width:1px;
-border-style:dashed;
+border-style:solid;
 border-bottom:0;
+font-weight:bold;
 }
 #site_nav_local_views .nav {
 float:left;
diff --git a/theme/identica/css/display.css b/theme/identica/css/display.css
index c2eb4ef655..aed4f95e50 100644
--- a/theme/identica/css/display.css
+++ b/theme/identica/css/display.css
@@ -59,6 +59,10 @@ background-color:transparent;
 
 #site_nav_local_views a {
 border-color:#fff;
+background-color:rgba(255, 255, 255, 0.2);
+}
+#site_nav_local_views a:hover {
+background-color:rgba(255, 255, 255, 0.7);:
 }
 
 /*

From 607e65be81d6b42990706884f96fa024301c7893 Mon Sep 17 00:00:00 2001
From: sarven <csarven@plantard.controlezvous.ca>
Date: Sat, 17 Jan 2009 02:32:13 +0000
Subject: [PATCH 11/19] Delete notice markup and styles

---
 lib/noticelist.php             | 14 ++++++++------
 theme/base/css/display.css     | 17 +++++++++--------
 theme/identica/css/display.css |  6 +++---
 3 files changed, 20 insertions(+), 17 deletions(-)

diff --git a/lib/noticelist.php b/lib/noticelist.php
index fde93a3b66..1283e43e4a 100644
--- a/lib/noticelist.php
+++ b/lib/noticelist.php
@@ -438,7 +438,7 @@ class NoticeListItem extends Widget
         $reply_url = common_local_url('newnotice',
                                       array('replyto' => $this->profile->nickname));
 
-        $this->out->elementStart('dl', 'reply');
+        $this->out->elementStart('dl', 'notice_reply');
         $this->out->element('dt', null, _('Reply to this notice'));
         $this->out->elementStart('dd');
         $this->out->element('a', array('href' => $reply_url,
@@ -459,11 +459,13 @@ class NoticeListItem extends Widget
         if ($user && $this->notice->profile_id == $user->id) {
             $deleteurl = common_local_url('deletenotice',
                                           array('notice' => $this->notice->id));
-            $this->out->elementStart('a', array('class' => 'deletenotice',
-                                            'href' => $deleteurl,
-                                            'title' => _('delete')));
-            $this->out->raw(' &#215;');
-            $this->out->elementEnd('a');
+            $this->out->elementStart('dl', 'notice_delete');
+            $this->out->element('dt', null, _('Delete this notice'));
+            $this->out->elementStart('dd');
+            $this->out->element('a', array('href' => $deleteurl,
+                                           'title' => _('delete')), _('Delete'));
+            $this->out->elementEnd('dd');
+            $this->out->elementEnd('dl');
         }
     }
 
diff --git a/theme/base/css/display.css b/theme/base/css/display.css
index fb7e71acd4..20e66c3519 100644
--- a/theme/base/css/display.css
+++ b/theme/base/css/display.css
@@ -775,25 +775,26 @@ outline:none;
 margin-left:2%;
 float:left;
 }
-.notice-options .reply,
+.notice-options .notice_reply,
 .notice-options .notice_delete ,
 .notice-options .notice_favorite {
 float:left;
 margin-right:11px;
 }
-.notice-options .reply {
+.notice-options .notice_reply {
 margin-top:1px;
 }
-.notice-options .reply dt {
+.notice-options .notice_reply dt {
 display:none;
 }
-.notice-options .reply a,
+.notice-options .notice_reply a,
 .notice-options form input.submit {
 display:block;
 border:0;
 }
 
-.notice-options .reply a {
+.notice-options .notice_reply a,
+.notice-options .notice_delete a {
 text-decoration:none;
 padding-left:20px;
 }
@@ -802,7 +803,7 @@ cursor:pointer;
 padding:0 0 0 17px;
 }
 
-.notice-options .notice_delete legend,
+.notice-options .notice_delete dt,
 .notice-options .notice_favorite legend {
 display:none;
 }
@@ -813,8 +814,8 @@ padding:0;
 }
 
 
-.notice-options form.notice_delete {
-margin-left:2em;
+.notice-options .notice_delete {
+margin-left:3em;
 }
 /*END: NOTICES */
 
diff --git a/theme/identica/css/display.css b/theme/identica/css/display.css
index aed4f95e50..94e97d4148 100644
--- a/theme/identica/css/display.css
+++ b/theme/identica/css/display.css
@@ -173,17 +173,17 @@ background-image:url(../images/icons/twotone/green/flag.gif);
 background-image:url(../images/icons/twotone/green/document.gif);
 }
 
-.notice-options .reply a,
+.notice-options .notice_reply a,
 .notice-options form input.submit {
 background-color:transparent;
 }
-.notice-options .reply a {
+.notice-options .notice_reply a {
 background:transparent url(../images/icons/twotone/green/reply.gif) no-repeat 0 45%;
 }
 .notice-options form.notice_favorite input.submit {
 background:transparent url(../images/icons/twotone/green/favourite.gif) no-repeat 0 45%;
 }
-.notice-options form.notice_delete input.submit {
+.notice-options .notice_delete a {
 background:transparent url(../images/icons/twotone/green/trash.gif) no-repeat 0 45%;
 }
 

From ba18deeee52f99067a453c45ce04d72892af985d Mon Sep 17 00:00:00 2001
From: sarven <csarven@plantard.controlezvous.ca>
Date: Sat, 17 Jan 2009 02:57:51 +0000
Subject: [PATCH 12/19] Adding xbImportNode

---
 js/xbImportNode.js | 47 ++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 47 insertions(+)
 create mode 100644 js/xbImportNode.js

diff --git a/js/xbImportNode.js b/js/xbImportNode.js
new file mode 100644
index 0000000000..f600a4789e
--- /dev/null
+++ b/js/xbImportNode.js
@@ -0,0 +1,47 @@
+/* is this stuff defined? */
+if (!document.ELEMENT_NODE) {
+	document.ELEMENT_NODE = 1;
+	document.ATTRIBUTE_NODE = 2;
+	document.TEXT_NODE = 3;
+	document.CDATA_SECTION_NODE = 4;
+	document.ENTITY_REFERENCE_NODE = 5;
+	document.ENTITY_NODE = 6;
+	document.PROCESSING_INSTRUCTION_NODE = 7;
+	document.COMMENT_NODE = 8;
+	document.DOCUMENT_NODE = 9;
+	document.DOCUMENT_TYPE_NODE = 10;
+	document.DOCUMENT_FRAGMENT_NODE = 11;
+	document.NOTATION_NODE = 12;
+}
+
+document._importNode = function(node, allChildren) {
+	/* find the node type to import */
+	switch (node.nodeType) {
+		case document.ELEMENT_NODE:
+			/* create a new element */
+			var newNode = document.createElement(node.nodeName);
+			/* does the node have any attributes to add? */
+			if (node.attributes && node.attributes.length > 0)
+				/* add all of the attributes */
+				for (var i = 0, il = node.attributes.length; i < il;) {
+					if (node.attributes[i].nodeName == 'class') {
+						newNode.className = node.getAttribute(node.attributes[i++].nodeName);
+					} else {
+						newNode.setAttribute(node.attributes[i].nodeName, node.getAttribute(node.attributes[i++].nodeName));
+					}
+				}
+			/* are we going after children too, and does the node have any? */
+			if (allChildren && node.childNodes && node.childNodes.length > 0)
+				/* recursively get all of the child nodes */
+				for (var i = 0, il = node.childNodes.length; i < il;)
+					newNode.appendChild(document._importNode(node.childNodes[i++], allChildren));
+			return newNode;
+			break;
+		case document.TEXT_NODE:
+		case document.CDATA_SECTION_NODE:
+		case document.COMMENT_NODE:
+			return document.createTextNode(node.nodeValue);
+			break;
+	}
+};
+

From 102028fb4813a27957efeb6fdd5bc7bfc46a03f0 Mon Sep 17 00:00:00 2001
From: sarven <csarven@plantard.controlezvous.ca>
Date: Sat, 17 Jan 2009 03:03:53 +0000
Subject: [PATCH 13/19] In reply to @id

---
 js/util.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/js/util.js b/js/util.js
index 35d69310bf..6fe4770756 100644
--- a/js/util.js
+++ b/js/util.js
@@ -179,7 +179,7 @@ function doreply(nick,id) {
 		replyto = "@" + nick + " ";
 		if ($("#notice_data-text").length) {
 			$("#notice_data-text").val(replyto);
-			$("form#form_notice input#inreplyto").val(id);
+			$("#form_notice input#notice_in-reply-to").val(id);
 			$("#notice_data-text").focus();
 			return false;
 		}

From 1df4a3831358753c59b996305a54bd2366450079 Mon Sep 17 00:00:00 2001
From: sarven <csarven@plantard.controlezvous.ca>
Date: Sat, 17 Jan 2009 03:09:00 +0000
Subject: [PATCH 14/19] notice vcard url and a:visited style

---
 theme/base/css/display.css     |  4 ++--
 theme/identica/css/display.css | 11 +++++++++++
 2 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/theme/base/css/display.css b/theme/base/css/display.css
index 20e66c3519..ce7f69b358 100644
--- a/theme/base/css/display.css
+++ b/theme/base/css/display.css
@@ -851,12 +851,12 @@ border-bottom:0;
 }
 
 .pagination .nav_prev a {
--moz-border-radius-topright:4px;
+-moz-border-radius-topright:7px;
 padding-left:20px;
 border-left:0;
 }
 .pagination .nav_next a {
--moz-border-radius-topleft:4px;
+-moz-border-radius-topleft:7px;
 padding-right:20px;
 border-right:0;
 }
diff --git a/theme/identica/css/display.css b/theme/identica/css/display.css
index 94e97d4148..1bb2ca01ba 100644
--- a/theme/identica/css/display.css
+++ b/theme/identica/css/display.css
@@ -26,6 +26,17 @@ color:#EC008C;
 a {
 color:#002E6E;
 }
+a:active {
+background-color:#ddd;
+}
+.notice p.entry-content a:visited {
+background-color:#fcfcfc;
+-moz-border-radius:4px;
+}
+.notice p.entry-content .vcard a {
+background-color:#fcfffc;
+-moz-border-radius:4px;
+}
 
 
 

From 5a10287bc3e2ee2b2529bd95ce73d22e8c237e22 Mon Sep 17 00:00:00 2001
From: sarven <csarven@plantard.controlezvous.ca>
Date: Sat, 17 Jan 2009 03:15:45 +0000
Subject: [PATCH 15/19] Minor

---
 lib/noticeform.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/noticeform.php b/lib/noticeform.php
index 84817639a7..d6a3aa9c21 100644
--- a/lib/noticeform.php
+++ b/lib/noticeform.php
@@ -144,8 +144,8 @@ class NoticeForm extends Form
 
         if ($this->action) {
             $this->out->hidden('notice_return-to', $this->action, 'returnto');
-            $this->out->hidden('notice_in-reply-to', $this->action, 'inreplyto');
         }
+        $this->out->hidden('notice_in-reply-to', $this->action, 'inreplyto');
     }
 
     /**

From e7687c66b21fec1a2db524842505d229ce896e72 Mon Sep 17 00:00:00 2001
From: sarven <csarven@plantard.controlezvous.ca>
Date: Sat, 17 Jan 2009 06:33:45 +0000
Subject: [PATCH 16/19] Using @id instead of @class for navigation li

---
 lib/action.php           |  5 ++++-
 lib/personalgroupnav.php | 10 +++++-----
 2 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/lib/action.php b/lib/action.php
index 35f6f2e3ec..71520b84e8 100644
--- a/lib/action.php
+++ b/lib/action.php
@@ -565,7 +565,10 @@ class Action extends HTMLOutputter // lawsuit
         if ($is_selected) {
             $lattrs['class'] = 'current';
         }
-        $this->elementStart('li', (is_null($id)) ? $lattrs : $lattr['id'] = $id);
+
+        (is_null($id)) ? $lattrs : $lattrs['id'] = $id;
+        
+        $this->elementStart('li', $lattrs);
         $attrs['href'] = $url;
         if ($title) {
             $attrs['title'] = $title;
diff --git a/lib/personalgroupnav.php b/lib/personalgroupnav.php
index 5d727a5051..63e6138df2 100644
--- a/lib/personalgroupnav.php
+++ b/lib/personalgroupnav.php
@@ -91,28 +91,28 @@ class PersonalGroupNav extends Widget
             $user_profile = false;
         }
 
-        $this->out->elementStart('ul', array('id' => 'nav_views'));
+        $this->out->elementStart('ul', array('class' => 'nav'));
 
         $this->out->menuItem(common_local_url('all', array('nickname' =>
                                                        $nickname)),
                          _('Personal'),
                          sprintf(_('%s and friends'), (($user_profile && $user_profile->fullname) ? $user_profile->fullname : $nickname)),
-                         $action == 'all');
+                         $action == 'all', 'nav_timeline_personal');
         $this->out->menuItem(common_local_url('replies', array('nickname' =>
                                                               $nickname)),
                          _('Replies'),
                          sprintf(_('Replies to %s'), (($user_profile && $user_profile->fullname) ? $user_profile->fullname : $nickname)),
-                         $action == 'replies');
+                         $action == 'replies', 'nav_timeline_replies');
         $this->out->menuItem(common_local_url('showstream', array('nickname' =>
                                                               $nickname)),
                          _('Profile'),
                          ($user_profile && $user_profile->fullname) ? $user_profile->fullname : $nickname,
-                         $action == 'showstream');
+                         $action == 'showstream', 'nav_profile');
         $this->out->menuItem(common_local_url('showfavorites', array('nickname' =>
                                                               $nickname)),
                          _('Favorites'),
                          sprintf(_('%s\'s favorite notices'), ($user_profile) ? $user_profile->getBestName() : _('User')),
-                         $action == 'showfavorites');
+                         $action == 'showfavorites', 'nav_timeline_favorites');
 
         $cur = common_current_user();
 

From 05b00cc7df22d2e998d642e91fee6cea317a9b83 Mon Sep 17 00:00:00 2001
From: sarven <csarven@plantard.controlezvous.ca>
Date: Sat, 17 Jan 2009 16:22:36 +0000
Subject: [PATCH 17/19] Login styles

---
 actions/login.php          | 14 +++++++-
 theme/base/css/display.css | 68 +++++++++++++++++---------------------
 2 files changed, 44 insertions(+), 38 deletions(-)

diff --git a/actions/login.php b/actions/login.php
index 23ab166769..224b30f6fb 100644
--- a/actions/login.php
+++ b/actions/login.php
@@ -130,15 +130,27 @@ class LoginAction extends Action
     function showContent()
     {      
         $this->elementStart('form', array('method' => 'post',
-                                           'id' => 'login',
+                                           'id' => 'form_login',
+                                           'class' => 'form_login',
                                            'action' => common_local_url('login')));
+        $this->elementStart('fieldset');
+        $this->element('legend', null, _('Login to site'));
+        $this->elementStart('ul', 'form_datas');
+        $this->elementStart('li');
         $this->input('nickname', _('Nickname'));
+        $this->elementEnd('li');
+        $this->elementStart('li');
         $this->password('password', _('Password'));
+        $this->elementEnd('li');
+        $this->elementStart('li');
         $this->checkbox('rememberme', _('Remember me'), false,
                         _('Automatically login in the future; ' .
                            'not for shared computers!'));
+        $this->elementEnd('li');
+        $this->elementEnd('ul');
         $this->submit('submit', _('Login'));
         $this->hidden('token', common_session_token());
+        $this->elementEnd('fieldset');
         $this->elementEnd('form');
         $this->elementStart('p');
         $this->element('a', array('href' => common_local_url('recoverpassword')),
diff --git a/theme/base/css/display.css b/theme/base/css/display.css
index ce7f69b358..afddefd270 100644
--- a/theme/base/css/display.css
+++ b/theme/base/css/display.css
@@ -30,30 +30,38 @@ h1,h2,h3,h4,h5,h6 {
 	text-transform:uppercase;
 	margin-bottom:7px;
 }
-legend { font-weight:bold; }
+caption {
+font-weight:bold;
+}
+.opened { display: block !important;}
+.closed { display: none !important;}
+
+
+legend {
+font-weight:bold; 
+font-size:1.6em;
+text-transform:uppercase;
+}
 input, textarea, select, option {
 padding:4px;
 font-family:sans-serif;
 font-size:1em;
 -moz-border-radius:4px;
 }
+input:focus, textarea:focus, select:focus {
+border-width:2px;
+border-style: solid;
+}
+
 select, option {
 padding-bottom:0;
 }
 fieldset {
-padding:11px;
+padding:0;
+border:0;
+margin-bottom:29px;
 }
-input:focus, textarea:focus, select:focus {
-border-width:2px;
-border-style: solid;
--moz-border-radius:4px;
-}
-caption {
-font-weight:bold;
-}
-.opened { display: block !important;}
-.closed { display: none !important;}
-span.required { font-weight:bold; }
+
 form ul li {
 list-style-type:none;
 margin:0 0 18px 0;
@@ -71,8 +79,10 @@ top:2px;
 left:0;
 }
 
-form .error {
-margin-right:11px;
+#page_notice .error {
+background-color:#F7E8E8;
+padding:4px 7px;
+-moz-border-radius:4px;
 }
 form label.submit {
 display:none;
@@ -83,15 +93,7 @@ display:block;
 .form_response {
 margin-bottom:18px;
 }
-.form_response dt {
-}
-.form_response dd {
-}
 
-form input.remove,
-form input.submit {
--moz-border-radius:4px;
-}
 form input.submit {
 }
 
@@ -99,24 +101,16 @@ form input.submit {
 
 
 /* FORM SETTINGS */
-.form_settings fieldset {
-padding:0;
-border:0;
-margin-bottom:29px;
-}
-.form_settings legend {
-font-size:1.6em;
-text-transform:uppercase;
-}
-.form_settings .form_datas label {
-
-}
-
 .form_guide {
 font-style:italic;
 }
 
-.form_settings .form_actions label {
+.form_login label,
+.form_settings label {
+margin-right:11px;
+}
+
+.form_actions label {
 display:none;
 }
 

From f28f1108a98cb33404513f760d1a40e9e98d85b9 Mon Sep 17 00:00:00 2001
From: sarven <csarven@plantard.controlezvous.ca>
Date: Sat, 17 Jan 2009 16:42:54 +0000
Subject: [PATCH 18/19] Opacity on notice div.entry-content and
 div.notice-options

---
 theme/base/css/display.css     |  6 ++++--
 theme/identica/css/display.css | 10 +++++-----
 2 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/theme/base/css/display.css b/theme/base/css/display.css
index afddefd270..213f0c0d29 100644
--- a/theme/base/css/display.css
+++ b/theme/base/css/display.css
@@ -59,9 +59,7 @@ padding-bottom:0;
 fieldset {
 padding:0;
 border:0;
-margin-bottom:29px;
 }
-
 form ul li {
 list-style-type:none;
 margin:0 0 18px 0;
@@ -101,6 +99,10 @@ form input.submit {
 
 
 /* FORM SETTINGS */
+.form_settings fieldset {
+margin-bottom:29px;
+}
+
 .form_guide {
 font-style:italic;
 }
diff --git a/theme/identica/css/display.css b/theme/identica/css/display.css
index 1bb2ca01ba..d1338e709d 100644
--- a/theme/identica/css/display.css
+++ b/theme/identica/css/display.css
@@ -198,16 +198,16 @@ background:transparent url(../images/icons/twotone/green/favourite.gif) no-repea
 background:transparent url(../images/icons/twotone/green/trash.gif) no-repeat 0 45%;
 }
 
-.notice-options a,
-.notice-options input {
-opacity:0.1;
+div.entry-content,
+div.notice-options {
+opacity:0.2;
 color:#333;
 }
 .notices li.hover {
 background-color:#fcfcfc;
 }
-.notices li.hover .notice-options a,
-.notices li.hover .notice-options input {
+.notices li.hover div.entry-content,
+.notices li.hover div.notice-options {
 opacity:1;
 }
 

From 6cc3f78cf309a80c72156c673dceac21dde63603 Mon Sep 17 00:00:00 2001
From: sarven <csarven@plantard.controlezvous.ca>
Date: Sat, 17 Jan 2009 20:06:56 +0000
Subject: [PATCH 19/19] Typography update to input and anchors on
 div.entry-content and div.notice-options

---
 theme/base/css/display.css     | 35 +++++++++++++++---------------
 theme/identica/css/display.css | 39 +++++++++++++---------------------
 2 files changed, 33 insertions(+), 41 deletions(-)

diff --git a/theme/base/css/display.css b/theme/base/css/display.css
index 213f0c0d29..b0a41cede8 100644
--- a/theme/base/css/display.css
+++ b/theme/base/css/display.css
@@ -42,6 +42,8 @@ font-weight:bold;
 font-size:1.6em;
 text-transform:uppercase;
 }
+form {
+}
 input, textarea, select, option {
 padding:4px;
 font-family:sans-serif;
@@ -714,12 +716,15 @@ clear:left;
 float:left;
 width:48%;
 }
-.notice div.entry-content,
+.notice div.entry-content a,
 .notice .notice-options a,
 .notice .notice-options input {
-font-size:0.9em;
-}
 
+}
+.notice .notice-options a,
+.notice .notice-options input {
+float:left;
+}
 
 #laconicat .notice div.entry-content {
 /*margin-left:0;*/
@@ -734,17 +739,16 @@ display:inline;
 .notice div.entry-content .response dt {
 display:none;
 }
-.notice div.entry-content .timestamp {
+.notice div.entry-content .timestamp a {
 
 }
 .notice div.entry-content .device dt {
 text-transform:lowercase;
 }
 .notice div.entry-content a {
-text-decoration:none;
+
 }
 .notice div.entry-content a:hover {
-text-decoration:underline;
 }
 
 
@@ -765,20 +769,17 @@ display:block;
 outline:none;
 }
 
-
-
 .notice-options {
-margin-left:2%;
+padding-left:2%;
 float:left;
+width:50%;
 }
 .notice-options .notice_reply,
-.notice-options .notice_delete ,
 .notice-options .notice_favorite {
 float:left;
 margin-right:11px;
 }
 .notice-options .notice_reply {
-margin-top:1px;
 }
 .notice-options .notice_reply dt {
 display:none;
@@ -788,15 +789,19 @@ display:none;
 display:block;
 border:0;
 }
-
 .notice-options .notice_reply a,
 .notice-options .notice_delete a {
 text-decoration:none;
 padding-left:20px;
 }
+
+.notice-options .notice_delete {
+float:right;
+}
+
 .notice-options form input.submit {
 cursor:pointer;
-padding:0 0 0 17px;
+padding:2px 0 2px 17px;
 }
 
 .notice-options .notice_delete dt,
@@ -809,10 +814,6 @@ border:0;
 padding:0;
 }
 
-
-.notice-options .notice_delete {
-margin-left:3em;
-}
 /*END: NOTICES */
 
 
diff --git a/theme/identica/css/display.css b/theme/identica/css/display.css
index d1338e709d..4af7cf2396 100644
--- a/theme/identica/css/display.css
+++ b/theme/identica/css/display.css
@@ -1,28 +1,17 @@
 /* theme: identica */
 html {
-	background-color:#ddd;
+background-color:#ddd;
 }
 body {
-	font-family: sans-serif;
-	font-family: "Lucida Sans Unicode", "Lucida Grande", sans-serif;
-	font-size:1em;
-
+font-family: "Lucida Sans Unicode", "Lucida Grande", sans-serif;
+font-size:1em;
 }
 input, textarea, select, option {
-	font-family: "Lucida Sans Unicode", "Lucida Grande", sans-serif;
+font-family: "Lucida Sans Unicode", "Lucida Grande", sans-serif;
 }
 input:focus, textarea:focus, select:focus {
 border-color:#B2D0DD;
 }
-form span.required { color:#f00; }
-form .error {
-background-color:#f00;
-color:#fff;
-}
-form .error_message {
-color:#EC008C;
-}
-
 a {
 color:#002E6E;
 }
@@ -76,13 +65,6 @@ background-color:rgba(255, 255, 255, 0.2);
 background-color:rgba(255, 255, 255, 0.7);:
 }
 
-/*
-#site_nav_global_primary .current a {
-font-weight:bold;
-border-color:#ccc;
-border-style:solid;
-}
-*/
 
 #content,
 #site_nav_local_views .current a {
@@ -154,7 +136,7 @@ color:#555;
 
 /* NOTICES */
 .notice div.entry-content a {
-color:#333;
+
 }
 .notice div.entry-content a:hover {
 }
@@ -201,7 +183,16 @@ background:transparent url(../images/icons/twotone/green/trash.gif) no-repeat 0
 div.entry-content,
 div.notice-options {
 opacity:0.2;
-color:#333;
+font-family:sans-serif;
+}
+div.entry-content a,
+div.notice-options a,
+div.notice-options input {
+font-family:sans-serif;
+}
+div.notice-options input {
+color:#002E6E;
+
 }
 .notices li.hover {
 background-color:#fcfcfc;