[CORE] Avatars are in PUBLICDIR in v2

Fixed a bug in the Installer

lib/default.php

@@ -146,7 +146,7 @@ $default =
         array('jpegquality' => 85),
         'avatar' =>
         array('server' => null,
-              'dir' => INSTALLDIR . '/avatar/',
+              'dir' => PUBLICDIR . '/avatar/',
               'path' => $_path . '/avatar/',
               'ssl' => null,
               'maxsize' => 300),

lib/installer.php

@@ -164,6 +164,11 @@ abstract class Installer
             unset($default);
             foreach ($fileSubdirs as $fileFullPath) {
                 if (!file_exists($fileFullPath)) {
+                    $this->warning(
+                        sprintf('GNU social was unable to create a directory on this path: %s', $fileFullPath),
+                        'Either create that directory with the right permissions so that GNU social can use it or '.
+                        'set the necessary permissions and it will be created.'
+                    );
                     $pass = $pass && mkdir($fileFullPath);
                 } elseif (!is_dir($fileFullPath)) {
                     $this->warning(

public/install.php

@@ -37,6 +37,7 @@
  */
 
 define('INSTALLDIR', dirname(__DIR__));
+define('PUBLICDIR', INSTALLDIR . DIRECTORY_SEPARATOR . 'public');
 
 require INSTALLDIR . '/lib/installer.php';