Throw exception when we can't get the url for a notice
This commit is contained in:
parent
7025817cc1
commit
e0e69ddd7c
|
@ -213,7 +213,15 @@ class Notice extends Managed_DataObject
|
||||||
public function getUrl()
|
public function getUrl()
|
||||||
{
|
{
|
||||||
// The risk is we start having empty urls and non-http uris...
|
// The risk is we start having empty urls and non-http uris...
|
||||||
return $this->url ?: $this->uri;
|
// and we can't really handle any other protocol right now.
|
||||||
|
switch (true) {
|
||||||
|
case common_valid_http_url($this->url):
|
||||||
|
return $this->url;
|
||||||
|
case common_valid_http_url($this->uri):
|
||||||
|
return $this->uri;
|
||||||
|
default:
|
||||||
|
throw new ServerException('No URL available for notice.');
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
public function get_object_type($canonical=false) {
|
public function get_object_type($canonical=false) {
|
||||||
|
|
Loading…
Reference in New Issue
Block a user