From ea8151688e1ce14d115b9b733156fc5474e71b8f Mon Sep 17 00:00:00 2001
From: Evan Prodromou <evan@e14n.com>
Date: Fri, 24 May 2013 09:26:58 -0400
Subject: [PATCH] Throw an exception converting fave to activity for
 non-existent notice or profile

---
 classes/Fave.php | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/classes/Fave.php b/classes/Fave.php
index 59a1e00318..455e7b089c 100644
--- a/classes/Fave.php
+++ b/classes/Fave.php
@@ -124,9 +124,18 @@ class Fave extends Managed_DataObject
 
     function asActivity()
     {
-        $notice  = Notice::staticGet('id', $this->notice_id);
+        $notice = Notice::staticGet('id', $this->notice_id);
+
+        if (!$notice) {
+            throw new Exception("Fave for non-existent notice: " . $this->notice_id);
+        }
+
         $profile = Profile::staticGet('id', $this->user_id);
 
+        if (!$profile) {
+            throw new Exception("Fave by non-existent profile: " . $this->user_id);
+        }
+
         $act = new Activity();
 
         $act->verb = ActivityVerb::FAVORITE;