ignore old password if no old password

darcs-hash:20080708041210-84dde-71118bdd00ace64af0aee5033bff69e638a1463c.gz
This commit is contained in:
Evan Prodromou 2008-07-08 00:12:10 -04:00
parent 6942064d12
commit ebd9adca69

View File

@ -28,12 +28,16 @@ class PasswordAction extends SettingsAction {
} }
function show_form($msg=NULL, $success=false) { function show_form($msg=NULL, $success=false) {
$user = common_current_user();
$this->form_header(_t('Change password'), $msg, $success); $this->form_header(_t('Change password'), $msg, $success);
common_element_start('form', array('method' => 'post', common_element_start('form', array('method' => 'post',
'id' => 'password', 'id' => 'password',
'action' => 'action' =>
common_local_url('password'))); common_local_url('password')));
# Users who logged in with OpenID won't have a pwd
if ($user->password) {
common_password('oldpassword', _t('Old password')); common_password('oldpassword', _t('Old password'));
}
common_password('newpassword', _t('New password'), common_password('newpassword', _t('New password'),
_t('6 or more characters')); _t('6 or more characters'));
common_password('confirm', _t('Confirm'), common_password('confirm', _t('Confirm'),
@ -50,7 +54,6 @@ class PasswordAction extends SettingsAction {
# FIXME: scrub input # FIXME: scrub input
$oldpassword = $this->arg('oldpassword');
$newpassword = $this->arg('newpassword'); $newpassword = $this->arg('newpassword');
$confirm = $this->arg('confirm'); $confirm = $this->arg('confirm');
@ -59,10 +62,14 @@ class PasswordAction extends SettingsAction {
return; return;
} }
if ($user->password) {
$oldpassword = $this->arg('oldpassword');
if (!common_check_user($user->nickname, $oldpassword)) { if (!common_check_user($user->nickname, $oldpassword)) {
$this->show_form(_t('Incorrect old password')); $this->show_form(_t('Incorrect old password'));
return; return;
} }
}
$original = clone($user); $original = clone($user);