improve status length calculation, each link is exactly 23 characters long at Twitter

This commit is contained in:
Bjoern Schiessle 2016-12-14 15:54:02 +01:00
parent 7d67eefdf5
commit f198d5d110
No known key found for this signature in database
GPG Key ID: 2378A753E2BF04F6

View File

@ -389,11 +389,16 @@ function format_status($notice)
// XXX: Make this an optional setting?
$statustxt = preg_replace('/(^|\s)!([A-Za-z0-9]{1,64})/', "\\1#\\2", $statustxt);
// detect links, each link uses 23 characters on twitter
$numberOfLinks = preg_match_all('`((http|https|ftp)://[^\s<]+[^\s<\.)])`i', $statustxt);
$statusWithoutLinks = preg_replace('`((http|https|ftp)://[^\s<]+[^\s<\.)])`i', '', $statustxt);
$statusLength = mb_strlen($statusWithoutLinks) + $numberOfLinks * 23;
// Twitter still has a 140-char hardcoded max.
if (mb_strlen($statustxt) > 140) {
if ($statusLength > 140) {
$noticeUrl = common_shorten_url($notice->getUrl());
$urlLen = mb_strlen($noticeUrl);
$statustxt = mb_substr($statustxt, 0, 140 - ($urlLen + 3)) . ' … ' . $noticeUrl;
// each link uses 23 chars on twitter + 3 for the ' … ' => 26
$statustxt = mb_substr($statustxt, 0, 140 - 26) . ' … ' . $noticeUrl;
}
return $statustxt;