From 629532e2da239b791b245ce702170d0b8de9c0ef Mon Sep 17 00:00:00 2001 From: Sarven Capadisli Date: Mon, 16 Nov 2009 22:00:15 +0000 Subject: [PATCH 1/3] Added update delay and max notice count --- plugins/Realtime/realtimeupdate.js | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/plugins/Realtime/realtimeupdate.js b/plugins/Realtime/realtimeupdate.js index e82b4dbfbb..59045c094e 100644 --- a/plugins/Realtime/realtimeupdate.js +++ b/plugins/Realtime/realtimeupdate.js @@ -34,6 +34,8 @@ RealtimeUpdate = { _favorurl: '', _deleteurl: '', _updatecounter: 0, + _updatedelay: 500, + _maxnotices: 50, init: function(userid, replyurl, favorurl, deleteurl) { @@ -76,11 +78,16 @@ RealtimeUpdate = { $("#notices_primary .notices").prepend(noticeItem); $("#notices_primary .notice:first").css({display:"none"}); $("#notices_primary .notice:first").fadeIn(1000); + + if ($('#notices_primary .notice').length > RealtimeUpdate._maxnotices) { + $("#notices_primary .notice:last").remove(); + } + NoticeReply(); RealtimeUpdate._updatecounter += 1; document.title = '('+RealtimeUpdate._updatecounter+') ' + DT; - }, 500); + }, RealtimeUpdate._updatedelay); }, makeNoticeItem: function(data) From be73757131127c687090f925ff873ff385a88604 Mon Sep 17 00:00:00 2001 From: Sarven Capadisli Date: Mon, 16 Nov 2009 22:16:08 +0000 Subject: [PATCH 2/3] Unbinding the events from Notice reply and favor for possible memory leaks --- plugins/Realtime/realtimeupdate.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/plugins/Realtime/realtimeupdate.js b/plugins/Realtime/realtimeupdate.js index 59045c094e..16c96615ef 100644 --- a/plugins/Realtime/realtimeupdate.js +++ b/plugins/Realtime/realtimeupdate.js @@ -80,6 +80,9 @@ RealtimeUpdate = { $("#notices_primary .notice:first").fadeIn(1000); if ($('#notices_primary .notice').length > RealtimeUpdate._maxnotices) { + $("#notices_primary .notice:last .form_disfavor").unbind('submit'); + $("#notices_primary .notice:last .form_favor").unbind('submit'); + $("#notices_primary .notice:last #notice_in-reply-to").unbind('click'); $("#notices_primary .notice:last").remove(); } From 8b4fd414218d162970cf997d260e070d0a5177fe Mon Sep 17 00:00:00 2001 From: Sarven Capadisli Date: Mon, 16 Nov 2009 22:16:55 +0000 Subject: [PATCH 3/3] Added NoticeFavors() for received notices --- plugins/Realtime/realtimeupdate.js | 1 + 1 file changed, 1 insertion(+) diff --git a/plugins/Realtime/realtimeupdate.js b/plugins/Realtime/realtimeupdate.js index 16c96615ef..2ded33e937 100644 --- a/plugins/Realtime/realtimeupdate.js +++ b/plugins/Realtime/realtimeupdate.js @@ -86,6 +86,7 @@ RealtimeUpdate = { $("#notices_primary .notice:last").remove(); } + NoticeFavors(); NoticeReply(); RealtimeUpdate._updatecounter += 1;