wamo/gnu-social
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Twitter bridge - don't delete Twitter users. Update them instead.

Browse Source 
darcs-hash:20081114053044-462f3-30e2d27261bca1977b89dee409383e178f446149.gz
This commit is contained in:
zach 2008-11-14 00:30:44 -05:00
parent 65b22d2fdf
commit fed15bd6b7
2 changed files with 69 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
actions/twittersettings.php
View File

@ -138,16 +138,45 @@ class TwittersettingsAction extends SettingsAction {
return; return;
} }
$fuser = null;
$result = null;
// Check to see whether the Twitter user is already in the system,
// and update its username and uri if so.
$fuser = Foreign_User::getForeignUser($twitter_id, 1);
if ($fuser) {
$original = clone($fuser);
$fuser->nickname = $twitter_username;
$fuser->uri = "http://www.twitter.com/$twitter_username";
$result = $fuser->updateKeys($original);
if (!$result) {
common_log_db_error($fuser, 'UPDATE', __FILE__);
}
} else {
// Otherwise, add the Twitter user
$fuser = DB_DataObject::factory('foreign_user'); $fuser = DB_DataObject::factory('foreign_user');
$fuser->nickname = $twitter_username;
$fuser->uri = "http://www.twitter.com/$twitter_username";
$fuser->id = $twitter_id; $fuser->id = $twitter_id;
$fuser->service = 1; // Twitter $fuser->service = 1; // Twitter
$fuser->uri = "http://www.twitter.com/$twitter_username";
$fuser->nickname = $twitter_username;
$fuser->created = common_sql_now(); $fuser->created = common_sql_now();
$result = $fuser->insert(); $result = $fuser->insert();
if (!$result) { if (!$result) {
common_log_db_error($fuser, 'INSERT', __FILE__); common_log_db_error($fuser, 'INSERT', __FILE__);
}
}
if (!$result) {
$this->show_form(_('Unable to save your Twitter settings!')); $this->show_form(_('Unable to save your Twitter settings!'));
return; return;
} }
@ -179,7 +208,6 @@ class TwittersettingsAction extends SettingsAction {
// For now we assume one Twitter acct per Laconica acct // For now we assume one Twitter acct per Laconica acct
$flink = Foreign_link::getForeignLink($user->id, 1); $flink = Foreign_link::getForeignLink($user->id, 1);
$fuser = Foreign_user::getForeignUser($flink->foreign_id, 1);
$flink_foreign_id = $this->arg('flink_foreign_id'); $flink_foreign_id = $this->arg('flink_foreign_id');
if (!$flink) { if (!$flink) {
@ -193,14 +221,6 @@ class TwittersettingsAction extends SettingsAction {
return; return;
} }
$result = $fuser->delete();
if (!$result) {
common_log_db_error($fuser, 'DELETE', __FILE__);
$this->show_form(_('Couldn\'t remove Twitter user.'));
return;
}
$result = $flink->delete(); $result = $flink->delete();
if (!$result) { if (!$result) {

28
classes/Foreign_user.php
View File

@ -39,4 +39,32 @@ class Foreign_user extends Memcached_DataObject
return NULL; return NULL;
} }
function updateKeys(&$orig) {
$parts = array();
foreach (array('id', 'service', 'uri', 'nickname') as $k) {
if (strcmp($this->$k, $orig->$k) != 0) {
$parts[] = $k . ' = ' . $this->_quote($this->$k);
}
}
if (count($parts) == 0) {
# No changes
return true;
}
$toupdate = implode(', ', $parts);
$table = $this->tableName();
if(common_config('db','quote_identifiers')) {
$table = '"' . $table . '"';
}
$qry = 'UPDATE ' . $table . ' SET ' . $toupdate .
' WHERE id = ' . $this->id;
$orig->decache();
$result = $this->query($qry);
if ($result) {
$this->encache();
}
return $result;
}
} }