Commit Graph

213 Commits

Author SHA1 Message Date
Hugo Sales
b74d944ae3
[TOOLS][PHPStan] Raise PHPStan level to 3 and fix new errors 2021-09-14 13:13:45 +01:00
Hugo Sales
add8f4a52f
[TOOLS] Fix all errors found by PHPStan level 1 2021-09-14 13:13:42 +01:00
Hugo Sales
eb833b62e2
[TOOLS] Fix all level 0 errors found by PHPStan and move constant definition to bootstrap file 2021-09-14 13:13:42 +01:00
Hugo Sales
bfd0acacd1
[TESTS] Fix SecurityTest breakage following UI changes 2021-09-14 13:13:41 +01:00
Hugo Sales
c94ef26617
[TESTS] Fix namespace on Controller Security test 2021-09-14 13:13:36 +01:00
Hugo Sales
56e5d5c4a0
[TESTS] Fix broken tests and expand tests around Attachments 2021-09-14 13:13:36 +01:00
Hugo Sales
f1bd4db495
[TESTS] Fix Common test 2021-09-14 13:13:36 +01:00
Diogo Peralta Cordeiro
2b457655ea
[CORE] Fix path configuration 2021-09-14 13:13:35 +01:00
Diogo Peralta Cordeiro
aa8412f607
[TESTS][Forms] Respect new naming conventions 2021-09-14 13:13:35 +01:00
Diogo Peralta Cordeiro
9067bd8785
[TESTS] remove accidentally duplicate sample upload 2021-09-14 13:13:35 +01:00
Diogo Peralta Cordeiro
5107e06fae
[DOCS][Developer] Paradigms: Update is_null based on poll votes
Everything around the use we give to php's null is about the state of having a value or not. Thus, using `is_null` always is the less bad option.
2021-09-14 13:13:35 +01:00
Diogo Peralta Cordeiro
e80ad2d87b
[TESTS][Controller][AdminTest] Update int tests to use attachment file_quota instead, as we deleted attachment max width 2021-09-14 13:13:34 +01:00
Hugo Sales
a7d5b5599c
[TESTS] Fix LocalUserTest, i forgor to boot the kernel 2021-09-14 13:13:33 +01:00
Hugo Sales
e278efe61d
[TESTS] Fix tests broken with rebased commits 2021-09-14 13:13:33 +01:00
Hugo Sales
8e12f5ee59
[TESTS] Raise test coverage for Link to 100% 2021-09-14 13:13:33 +01:00
Hugo Sales
c78032f1fa
[TESTS] Raise test coverage of LocalGroup to 100% 2021-09-14 13:13:33 +01:00
Hugo Sales
cfc89d8a25
[TESTS] Raise test coverage of LocalUser to 100% 2021-09-14 13:13:33 +01:00
Hugo Sales
a2e302efb4
[TESTS] Raise GSActor test coverage to 100% 2021-09-14 13:13:33 +01:00
Hugo Sales
043e179c23
[TESTS][Attachment][AttachmentThumbnail][GSFile] Reorganize tests and raise test coverage to 100% 2021-09-14 13:13:33 +01:00
Hugo Sales
e7699b3245
[TESTS] Raise test coverage for Note to 100% 2021-09-14 13:13:32 +01:00
Hugo Sales
e2e6c7a5bf
[TESTS] Hot-fix Security controller tests, broken with ongoing form rendering changes 2021-09-14 13:13:30 +01:00
Hugo Sales
8ca61eea77
Duplicate public/assets/css/bg.jpg history in tests/sample-uploads/attachment-lifecycle-target.jpg history. 2021-09-14 13:13:29 +01:00
Hugo Sales
5237364a21
[TESTS] Raise test coverage for GSFile to 100% 2021-09-14 13:13:28 +01:00
Hugo Sales
300eccfd17
[TESTS] Raise test coverage for Attachment controller to 100% 2021-09-14 13:13:28 +01:00
Hugo Sales
d4d4f4e950
[TESTS] Cleanup attachment test data 2021-09-14 13:13:27 +01:00
Hugo Sales
6e6d1a946f
[TESTS] Remove MediaFileTest and move setup code to media data fixture 2021-09-14 13:13:27 +01:00
Diogo Peralta Cordeiro
5fd91bf3a2
[TESTS][Twig] Fix ExtensionTest->testIconsExtension 2021-09-14 13:13:26 +01:00
Diogo Peralta Cordeiro
3f61537140
[ENTITY] Split Attachment in various new entities
Remove Attachment Scope
Fixed some minor bugs

Scope will be implemented later in v3. It doesn't make sense to have
the scope handling being per attachment. Different actors can post
the same attachment with different scopes. The attachment controller
will assume the highest level of scope applied to the attachment and
the rest will be handled at the note level.

Motivation:
* Remove title from attachment, as it's part of the relation between attachment and note.
* Remove actor from attachment, many actors may publish the same attachment.
* Remove is_local from attachment,  as it's part of the relation between attachment and note.
* Remove remote_url from attachment, different urls can return the same attachment.

Addition:
* Attachment now has a lives attribute,  it's a reference counter with a nicer name
* GSActorToAttachment
* GSActorToRemoteURL
* RemoteURL
* RemoteURLToNote
* RemoteURLToAttachment
* AttachmentToNote now has a title attribute
2021-09-14 13:13:24 +01:00
Hugo Sales
809bf00aa9
[TemporaryFile][TESTS] Throw on attempt to write to null resource and fix tests 2021-09-14 13:13:24 +01:00
Hugo Sales
c24c32334d
[TESTS] Add test for JSON response and invalid accept format 2021-09-14 13:13:24 +01:00
Hugo Sales
061a85d6b3
[EVENTS] Change FormatNoteList do separate in and out arguments
This is necessary due to some weird problem which I wasn't able to figure out (but which doesn't matter)
that somehow causes the event to be called twice during testing, and thus the function was exploding
2021-09-14 13:13:23 +01:00
Hugo Sales
57f43108bb
[TESTS] Fix Entity test in accordance with the changes to createOrUpdate 2021-09-14 13:13:23 +01:00
Hugo Sales
b5de80303a
[TEST] Raise test coverage for UserPanel to 100% 2021-09-14 13:13:23 +01:00
Hugo Sales
8240591bd4
[TESTS] Fixup Security controller tests to match new UI 2021-09-14 13:13:19 +01:00
Hugo Sales
fe7c2b5115
[TESTS] Raise test coverage for AdminPanel controller to 100% 2021-09-14 13:13:19 +01:00
Hugo Sales
e0a0df502e
[TESTS] Raise test coverage for Attachment controller to 100% 2021-09-14 13:13:19 +01:00
Hugo Sales
dfc97d2607
[TESTS] Raise test coverage for Controller/Security to 100% 2021-09-14 13:13:18 +01:00
Hugo Sales
41e4e2de0e
[TESTS][Router] Add tests for Router and use named paramenters, as we can since PHP8 2021-09-14 13:13:16 +01:00
Hugo Sales
1d40c5cdb3
[TESTS][DB] Update test to reflec fact that GSActor no longer has a normalized_nickname field 2021-09-14 13:13:15 +01:00
Hugo Sales
6b4b3e90fb
[TESTS][Nickname] Update tests to reflect new usage. Normalization functionality will be moved to a plugin 2021-09-14 13:13:15 +01:00
Hugo Sales
adf0897527
[TESTS][TemporaryFile] Update test to reflect new usage 2021-09-14 13:13:15 +01:00
Hugo Sales
7a2574eafb
[CORE][TemporaryFile] Add option to specify attempts and better handle when reaching the attemp limit without being able to create a file 2021-09-14 13:13:15 +01:00
Hugo Sales
f5fb4ed3c3
[TESTS] Add tests for GSFile 2021-09-14 13:13:15 +01:00
Hugo Sales
2ee99e5176
[TESTS] Raise test coverage for Form to 100% 2021-09-14 13:13:14 +01:00
Hugo Sales
b111870853
[TESTS][EVENTS] Raise test coverage for Event class to 100% 2021-09-14 13:13:14 +01:00
Hugo Sales
871422e6b6
[TESTS][ENTITY] Raise test coverage for Entity class to 100% 2021-09-14 13:13:14 +01:00
Hugo Sales
747b464c7d
[TESTS] Add missing tests for Common 2021-09-14 13:13:13 +01:00
Hugo Sales
9ce30751af
[TESTS] Expand and fix cache tests 2021-09-14 13:13:13 +01:00
Diogo Peralta Cordeiro
c8cf8c3f13
[FILE][TemporaryFile] Fix various issues now that we also have Symfony's file abstractions 2021-09-14 13:13:03 +01:00
Hugo Sales
74f477489b
[TESTS] Raise test coverage for App\Controller\Network to 100% and fixup related code 2021-09-14 13:13:02 +01:00