Commit Graph

4101 Commits

Author SHA1 Message Date
Joshua Judson Rosen
f246dd4645 OStatusPlugin: fix ensureProfile catch-22 in onCheckActivityAuthorship()
Use profile URL (not URI), like elsewhere.

Profile::getUri() doesn't actually do anything useful, here--
it does nothing unless a plugin (like OStatus) is already
able to resolve the Profile into a backend object (e.g.: an Ostatus_profile).

If we might not already have an Ostatus_profile for a given Profile,
then we need to use $profile->getUrl() and fetch the data from that URL.
2014-12-30 23:56:33 -05:00
Mikael Nordfeldth
c93b21d9f6 Columns too narrow in mobileprofile 2014-12-10 12:28:38 +01:00
Mikael Nordfeldth
d3a8896b2a Merge commit 'refs/merge-requests/26' of https://gitorious.org/social/mainline into merge-requests/26 2014-12-09 13:45:15 +01:00
Joshua Judson Rosen
f71eeaee5a OStatus/scripts/update-profile-data.php: print updated fullnames
Now that we can actually update them again.
2014-12-08 22:06:29 -05:00
Mikael Nordfeldth
812d1eead9 Stronger typing in Ostatus_profile 2014-12-08 19:52:00 +01:00
Mikael Nordfeldth
e7c6c6fc76 Merge commit 'refs/merge-requests/19' of https://gitorious.org/social/mainline into merge-requests/19 2014-12-06 20:18:52 +01:00
Hannes Mannerheim
b81857656f delete groups from groups directory, for admins 2014-12-02 15:31:27 +01:00
Mikael Nordfeldth
72d1c3c73e fetch conversation URI in processPost, not processShare 2014-11-27 16:51:21 +01:00
Mikael Nordfeldth
1b449ea705 scripts/upgrade.php would fail if Profile_prefs did not exist
A checkschema.php run would've done it, but that would require an
additional step to our upgrade procedure.
2014-11-27 14:46:10 +01:00
Mikael Nordfeldth
bdb4a41696 Use remote conversation URI info to stitch convos together
If we know the URI sent from the remote party, and we don't know the
notice it is replying to, we might still be able to put it in the same
conversation thread!
2014-11-27 14:06:10 +01:00
Joshua Judson Rosen
cff8c462da sendemailsummary.php: correct path to INSTALLDIR
So that we can actually find commandline.inc.

This should have been updated when the files in the EmailSummary tree
where moved down a level into subdirectories.
2014-11-24 20:28:31 -05:00
Mikael Nordfeldth
8056097478 Try to lookup the profile if we don't know it yet 2014-11-24 23:50:42 +01:00
Mikael Nordfeldth
720c2c9ff2 Ostatus_profile->checkAuthorship returns Profile
not Ostatus_profile
2014-11-24 23:40:06 +01:00
Mikael Nordfeldth
3bf1478f97 Bad parameter count for checkAuthorship
At the same time we change this to call ActivityUtils::checkAuthorship
instead to let the retrieval/verification go through event handling.

rozzin (Joshua Judson Rosen) found this error. Thanks.
2014-11-24 12:49:20 +01:00
Joshua Judson Rosen
4b875e0fd0 Fix OStatus groups by making Ostatus_profile::localProfile() work for groups
We need to look up a feed profile for HandleFeedEntryWithProfile events,
regardless of whether they're an OStatus user, group, or something else;
this is the least hairy way of doing that--the alternative being
to keep spreading the same logic all over the calling code.

Theoretically, this change might allow OStatusGroups to be recorded
as the authors of activities if they pass through any authorless
activities; but that's why we have checkAuthorship().
2014-11-24 12:30:37 +01:00
Joshua Judson Rosen
d2e1a8c706 Ostatus_profile::checkAuthorship(): throw ServerException when bogus non-authorship is detected
Similarly to what ActivityUtils::checkAuthorship does; try to ensure
that activities from ambiguous OStatus feeds (groups and peopletags)
that require explicit authorship don't get in without explicit authors.
2014-11-24 12:29:41 +01:00
Joshua Judson Rosen
2d7804b88f UserEmailSummaryHandler: use $notice->getLocalUrl(), not getUrl()
getUrl() doesn't work on all notices anymore.
2014-11-23 23:28:30 -05:00
Joshua Judson Rosen
bf0f22744d UserEmailSummaryHandler: Update notice-fetching logic
InboxNoticeStream::getNotices() no longer returns an ArrayWrapper;
just fetch notices normally via $notice->fetch(), so that
we can actually get the top notice-ID and update email_summary_status
accordingly--and not mail about the same notices repeatedly.
2014-11-23 23:28:28 -05:00
Joshua Judson Rosen
2f506dde28 UserEmailSummaryHandler: correct instantiation of InboxNoticeStream
It only takes a single Profile argument....
2014-11-23 23:28:27 -05:00
Mikael Nordfeldth
496acdc7d9 normalizing acct: URI just to be sure 2014-11-16 18:29:05 +01:00
Mikael Nordfeldth
33e7562210 Some unnecessary/faulty includes fixed in DM plugin 2014-11-07 16:33:19 +01:00
Mikael Nordfeldth
98eba61a7e Lost file with MessageCommand class. 2014-11-07 16:25:40 +01:00
Mikael Nordfeldth
aedfb6a8dd FavoritePlugin calls CommandInterpreter::split_arg
The last commit found a bug that a previous move of the FavCommand
into a plugin called $this in FavoritePlugin instead of the instance
of a CommandInterpreter class. Now that call is statically defined in
CommandInterpreter and appropriately called in FavoritePlugin.
2014-11-07 16:24:14 +01:00
Mikael Nordfeldth
046d070ad4 MessageCommand moved to DirectMessage plugin 2014-11-07 16:23:34 +01:00
Mikael Nordfeldth
6ac2a5b8ff &$supported in CommandSupportedAPI event is boolean
not array as we specified here
2014-11-07 16:13:45 +01:00
Mikael Nordfeldth
38d9b4d3a4 UserActivityStream export of DMs moved to plugin 2014-11-07 16:08:16 +01:00
Mikael Nordfeldth
d493fd0772 DirectMessage API functions moved to plugin 2014-11-07 16:00:27 +01:00
Mikael Nordfeldth
68143ff916 DirectMessage moved into a plugin, not done yet
We still have to move some API calls into the new plugin.
2014-11-07 15:53:35 +01:00
Mikael Nordfeldth
faae9d069a We're using URLMapper, not Net_URL_Mapper 2014-11-07 15:24:05 +01:00
Mikael Nordfeldth
29ac42addd Diaspora public key published in WebFinger 2014-11-06 21:05:31 +01:00
Mikael Nordfeldth
5e4f93cc7d Conversation link as default, permalink for /notice 2014-11-05 19:34:39 +01:00
Mikael Nordfeldth
c263bbcca7 EventPlugin now uses event handling instead of NLI adapter 2014-10-27 14:24:16 +01:00
Mikael Nordfeldth
18c6a0bf35 Show poll results also to non-logged in visitors 2014-10-26 23:17:58 +01:00
Mikael Nordfeldth
fb1b80c915 Updating TwitterBridge README to be clearer on installation 2014-10-26 23:17:43 +01:00
Mikael Nordfeldth
636ad44f0b BookmarkListItem removed in favor of event-driven rendering 2014-10-26 22:07:16 +01:00
Mikael Nordfeldth
f69f713360 PollListItem freed from noticeListItemAdapter clutches
In the future, use events for formatting microapp notices, more specifically
through the plugin's function "showNoticeContent" or similar, which is called
from MicroAppPlugin, which is extended from ActivityHandlerPlugin.
2014-10-26 14:48:02 +01:00
Mikael Nordfeldth
39b5e08d44 Possible XSS scenario when posting Bookmarks 2014-10-25 15:00:29 +02:00
Mikael Nordfeldth
048af5ac73 Can't use empty on a function call 2014-10-25 14:29:27 +02:00
Roland Haeder
3d031951f9 Fixed syntax error. :-(
Signed-off-by: Roland Haeder <roland@mxchange.org>
2014-10-25 14:26:22 +02:00
Roland Haeder
db704b5d10 Fixed type-hints + added assert + method getGroup().
Signed-off-by: Roland Haeder <roland@mxchange.org>
2014-10-25 14:26:18 +02:00
Roland Haeder
419c2cd5b3 Some fixes/improvements - added getter getGroup() for https://bugz.foocorp.net/T44 - added type-hints in method signatures
---------------------------------------------------------
WARNING: Some plugins attempt to get a property 'group' from (basicly) a Menu
class which does NOT have such property. This badly needs fixing.
---------------------------------------------------------

Signed-off-by: Roland Haeder <roland@mxchange.org>
2014-10-25 14:25:12 +02:00
Mikael Nordfeldth
57b5e2483d A little bit more debugging. 2014-10-25 14:23:15 +02:00
Hannes Mannerheim
8dba84bd76 i had introduced a bug... userdirectory didn't work when logged out 2014-10-21 02:57:52 +02:00
Hannes Mannerheim
0f87edd9f4 remove dupes when infinitescrolling, and add infinitescroll to user lists and userdirectory also 2014-10-20 16:34:37 +02:00
Hannes Mannerheim
4d4a0491f1 groups/all didn't work, also fixed pagination in directory/users, and a convenient delete-button for admins 2014-10-20 16:24:53 +02:00
Hannes Mannerheim
e3bb5e1df9 do favorites from default like in API
not quite sure about this, but the deleted code in this commit created
activity notices that we couldn't turn off in config.
2014-10-20 16:17:40 +02:00
Mikael Nordfeldth
d0401b19a5 statusnet/gnu-social merge request 22 2014-10-10 20:52:09 +02:00
Aqeel Zafar
a7ffc9e14e Fix T46 Blog Plugin is broken
Adds newFormAction() in Blog Plugin to redirect to correct action.
2014-09-29 18:06:54 +05:00
Mikael Nordfeldth
78781050b3 Mats Sjöberg's merge request no.5 from Gitorious 2014-09-25 08:41:25 +02:00
Mikael Nordfeldth
ee41bc560c Updated LDAP2 extlib to latest version. 2014-09-25 08:34:55 +02:00
Mikael Nordfeldth
a6545d09b8 Added a return true statement for an event handler 2014-09-25 08:32:10 +02:00
Silke Meyer
731d619c1e "return parent" breaks ldap plugin, there's no parent 2014-09-17 17:15:32 +02:00
Mikael Nordfeldth
7e47026085 QnA layout fix, still no answer-action
There is required to be an answer-action element for the threaded view
so we can fetch that action value to an AJAX call which fetches the form.

That is: Currently the "Your answer..." placeholder will fetch a blank URL.
2014-08-24 13:34:01 +02:00
Mikael Nordfeldth
f851d3dbf9 tabs to spaces 2014-08-24 13:33:52 +02:00
Roland Haeder
e1eadbcf4f Fixes for making Meteor working with HTTPS.
Signed-off-by: Roland Haeder <roland@mxchange.org>
2014-08-24 13:24:42 +02:00
Roland Haeder
c1a0132cab Added missing index declarations.
Signed-off-by: Roland Haeder <roland@mxchange.org>
2014-08-24 13:21:59 +02:00
Roland Haeder
3ec64116a4 This JavaScript file is located in js/ - Fixed paths for all targets.
Signed-off-by: Roland Haeder <roland@mxchange.org>
2014-08-24 13:10:19 +02:00
Mikael Nordfeldth
63b61ea2d1 QnA fixes from chimo 2014-08-24 13:05:49 +02:00
Mikael Nordfeldth
3cdc313429 Poll fixes by chimo 2014-08-24 13:01:13 +02:00
Mats Sjöberg
376e63db77 TwitterBridge should not try to send replies to tweets back to Twitter if user hasn't selected to import tweets. 2014-08-21 21:04:06 +03:00
chimo
3edc200b26 PollListItem: Use showNotice args 2014-08-17 13:39:19 -04:00
chimo
0a95cdfa88 Added adaptNoticeListItem and QnAListItem 2014-08-17 13:37:43 -04:00
chimo
850d687901 Added adaptNoticeListItem and PollListItem 2014-08-17 13:33:07 -04:00
Mikael Nordfeldth
9933c00c4f TwitterBridge PHP require_once paths now relative 2014-08-06 09:29:47 +02:00
Mikael Nordfeldth
a9676f5b2b RSVP fromNotice now throws NoResultException 2014-08-06 09:23:42 +02:00
Mikael Nordfeldth
9018fd75c6 JOINs and FOLLOWs would have null titles in Activity representation of notices 2014-07-30 00:21:00 +02:00
Mikael Nordfeldth
8674b51144 Activity plugin fix (LeaveListItem unused) 2014-07-29 10:43:58 +02:00
Mikael Nordfeldth
78dc376f01 Moved some FAVORITE handling from Activity plugin to Favorite 2014-07-28 10:58:24 +02:00
Mikael Nordfeldth
509f31af0e Favorite plugin now "extends" Activity on NoticeAsActivity
Got this mainly from my patches to FreeSocial. The idea is to migrate
also the Note activity to a plugin and have everything be handled as
events, only filling out the basic "context" stuff in the Notice class.
2014-07-28 10:02:53 +02:00
Mikael Nordfeldth
6e481d35ed Start/End NoticeAsActivity modifications
More 'scoped' profiles and typing to the functions.
Also, there's no need to send an object as a reference.
2014-07-28 09:40:07 +02:00
Mikael Nordfeldth
eb2f93ad2b More use of Profile, less User 2014-07-28 09:34:46 +02:00
Mikael Nordfeldth
d11ce2ef3b Consistently use "email-notify_fave" syntax for preference 2014-07-27 23:25:49 +02:00
Mikael Nordfeldth
2d0c7c2c99 ensureWebfinger was never complete in StatusNet. Worked a bit on it. 2014-07-27 23:08:02 +02:00
Mikael Nordfeldth
bb1ac66d74 Cronish plugin minor debugging text fixes and so 2014-07-21 09:51:28 +02:00
Mikael Nordfeldth
9a2e3a52c9 Don't access HTTP_USER_AGENT if it doesn't exist 2014-07-15 20:38:58 +02:00
Mikael Nordfeldth
ea8cb21e98 Allow exception to be thrown if saveActivityObject fails 2014-07-15 14:12:39 +02:00
Mikael Nordfeldth
c96f0aa30f More Activity-based reasoning for saveActivity in Notice
If we can, get the activity ID from the activity itself, instead of the
supplied $options array.
2014-07-14 23:54:58 +02:00
Mikael Nordfeldth
31d53ede91 Bad variable reference in Fave class 2014-07-14 23:37:28 +02:00
Mikael Nordfeldth
eb955fe629 "Notice posted" message in Ajax title for NewnoticeAction 2014-07-14 17:11:54 +02:00
Mikael Nordfeldth
b0c4a35940 Local favoriting fills out content to saveActivity 2014-07-14 14:05:47 +02:00
Mikael Nordfeldth
ae62b91940 Unifying HTML stripping functions to common_strip_html 2014-07-14 13:52:23 +02:00
Mikael Nordfeldth
ac44695c44 Put text content into Favorite activities/activityobjects 2014-07-14 13:25:26 +02:00
Mikael Nordfeldth
5ebe01ba36 NoticeStream fixes regarding non-post verbs 2014-07-14 00:59:04 +02:00
Mikael Nordfeldth
0a20abf1d8 Email notify-on-fave moved to Profile_prefs (run upgrade.php) 2014-07-13 19:46:40 +02:00
Mikael Nordfeldth
933bf0b026 Start and End EmailSaveForm events now take a scoped profile 2014-07-13 15:42:15 +02:00
Mikael Nordfeldth
c8873de08b Start and End EmailFormData events include current profile 2014-07-13 15:33:44 +02:00
Mikael Nordfeldth
a9bfa1979d Don't send favorite notifications unless the user wants it. 2014-07-13 12:58:52 +02:00
Mikael Nordfeldth
6f593a79d4 making more sense in mail_notify_fav
We should probably get rid of this function, at least storing everything in
lib/mail.php - but until then, at least let's make it more understandable.
2014-07-13 12:56:43 +02:00
Mikael Nordfeldth
0e8148af86 When modplus.css got moved, it should've re-related an image path 2014-07-07 01:40:33 +02:00
Mikael Nordfeldth
2eea7a2d4b Do proper Activity-plugin based mention notification 2014-07-07 01:15:43 +02:00
Mikael Nordfeldth
aadc7398dc ModPlus and some layouting issues regarding fixes 2014-07-06 01:37:31 +02:00
Mikael Nordfeldth
fffacaa27c FavorAction now uses Notice::saveActivity 2014-07-06 01:37:03 +02:00
Mikael Nordfeldth
aa33b7f21c Fave does not carry a type
it did in FreeSocial, where I copied my code from.
2014-07-05 16:28:09 +02:00
Mikael Nordfeldth
57a2d7a0e2 Bad ActivityObject generation of Fave 2014-07-05 00:15:22 +02:00
Mikael Nordfeldth
ffb9d7ad3f Rewriting code for notice representation
Getting rid of NoticeListItemAdapter, putting more into ActivityHandlerPlugin
and relying on plugins to handle rendering code of the content. This gives us
a lot more structure and consistency in notice structure and allows activity
plugins to stop rendering certain kinds of notices more easily.

There should also be a property for an ActivityHandlerPlugin class to avoid
rendering notices in the ordinary stream, so we don't have to overload stuff.
2014-07-04 14:14:49 +02:00
Mikael Nordfeldth
eda69cabaf Remove Ostatus_profile when releted Profile is deleted 2014-07-04 11:45:42 +02:00
Mikael Nordfeldth
4b40d6bb2a TagprofileAction fiddled with, now doesn't require OStatus override
But it still doesn't quite work properly, so a lot of work is necessary for this.
2014-07-03 14:02:21 +02:00
Mikael Nordfeldth
b63f6e949c Converted all ActivityObject::fromProfile to $profile->asActivityObject 2014-07-03 10:51:36 +02:00
Mikael Nordfeldth
c44146d6f8 Favorites are now being stored from activities 2014-07-02 18:38:19 +02:00
Mikael Nordfeldth
2e6a32c7be Most of the activityobject-saving for Favorite implemented 2014-07-02 11:38:55 +02:00