Commit Graph

55 Commits

Author SHA1 Message Date
Adrian Lang
fbe794e44d Improve handling of null values in profile parameters.
This commit fixes two issues:
- Allowing remote users to clear profile parameters via OMB.
- Improved handling of profile parameters which evaluate to
  false ('0' for example)
2009-03-09 08:06:31 +01:00
Evan Prodromou
1a63d7d829 fix case of OAuthUtil method 2009-03-07 13:35:19 -08:00
Evan Prodromou
ba9c589bb2 fix for change in OAuthUtil upstream 2009-03-07 13:32:44 -08:00
Adrian Lang
89197210cf Fixes #1067: Avatar stretched on authorize remote subscription page. The img tag used a wrong class which had a width: 100% applied. 2009-02-27 15:39:10 -08:00
Evan Prodromou
47a5d2b7f0 Fixed remote subscribe avatar problems
Had some Avatar file-copying issues; seem to be fixed.
2009-02-09 23:13:11 +00:00
Robin Millette
c2905085c1 trac #1155 ++ replace strlen with mb_strlen for all utf8 strings. 2009-02-07 19:33:18 +00:00
Adrian Lang
d2521786f0 Cancel -> Reject in remote subscribe 2009-01-26 14:20:19 +01:00
Evan Prodromou
1132e66f84 Fix over-zealous un-underscoring in userauthorization 2009-01-23 01:41:00 +01:00
Evan Prodromou
0ecfd7a7ec Update userauthorization, strip out a lot of debug stuff 2009-01-23 01:35:05 +01:00
Evan Prodromou
4b0cf99e56 Convert use of common_server_error and common_user_error to methods on Action 2009-01-15 23:03:38 +00:00
Evan Prodromou
eaa81d25fa Convert all actions to use new UI functions
I did a massive search-and-replace to get all the action subclasses to
use the new output function (common_element() -> $this->element(), etc.)

There's still a lot to do, but it's a first step
2009-01-15 22:57:15 +00:00
Evan Prodromou
b264c03d32 move opening brace of class declaration to next line
Another gigantor PEAR coding standards patch. Here, I've moved the
opening curly bracket on a class statement to the following line.

darcs-hash:20081223194923-84dde-77a93de314caadbcb5b70bf346a4648be77a864e.gz
2008-12-23 14:49:23 -05:00
Evan Prodromou
7ad2f2a371 TRUE
More PEAR coding standards global changes. Here, I've changed all
instances of TRUE to true and FALSE to false.

darcs-hash:20081223194428-84dde-cb1a1e6f679acd68e864545c4d4dd8752d6a6257.gz
2008-12-23 14:44:28 -05:00
Evan Prodromou
04ef1ba8ee change function headers to K&R style
Another huge change, for PEAR code standards compliance. Function
headers have to be in K&R style (opening brace on its own line),
instead of having the opening brace on the same line as the function
and parameters. So, a little perl magic found all the function
definitions and move the opening brace to the next line (properly
indented... usually).

darcs-hash:20081223193323-84dde-a28e36ecc66672c783c2842d12fc11043c13ab28.gz
2008-12-23 14:33:23 -05:00
Evan Prodromou
eb2f9c98ac replace NULL with null
Another global search-and-replace update. Here, I've replaced the PHP
keyword 'NULL' with its lowercase version. This is another PEAR code
standards change.

darcs-hash:20081223192129-84dde-4a0182e0ec16a01ad88745ad3e08f7cb501aee0b.gz
2008-12-23 14:21:29 -05:00
Evan Prodromou
edbc0c665c replace all tabs with four spaces
The PEAR coding standards decree: no tabs, but indent by four spaces.
I've done a global search-and-replace on all tabs, replacing them by
four spaces. This is a huge change, but it will go a long way to
getting us towards phpcs-compliance. And that means better code
readability, and that means more participation.

darcs-hash:20081223191907-84dde-21e8efe210e6d5d54e935a22d0cee5c7bbfc007d.gz
2008-12-23 14:19:07 -05:00
Evan Prodromou
8b3080faf4 whitespace fixup in userauthorization
darcs-hash:20081203032650-5ed1f-1f9affd557cf958cdfe7ed224433199b22e1c56a.gz
2008-12-02 22:26:50 -05:00
Evan Prodromou
58beea9798 check for license compatibility
darcs-hash:20081203032632-5ed1f-2213efd018913e3253082dbe83d7b906c4f0ff76.gz
2008-12-02 22:26:32 -05:00
Evan Prodromou
a179a816b5 add some extra checks to avoid remote subscriptions to local users
darcs-hash:20081118180644-84dde-ab152249ac0844a482029b7e0f8db2780a0f15d6.gz
2008-11-18 13:06:44 -05:00
Evan Prodromou
7ff02bb7d4 try to clean up user-without-profile errors
darcs-hash:20080926145008-5ed1f-8a60ed3c5adbfe75aa044732e8d10dbdb9b93089.gz
2008-09-26 10:50:08 -04:00
CiaranG
e322732bd3 Fix remote sub when redirected via login (Ticket #618)
darcs-hash:20080909202259-f6e2c-8c7e836fd1f0ce9de3ea3802161e1068e346e5dd.gz
2008-09-09 16:22:59 -04:00
CiaranG
fff677e6c4 Resolve remote subscribe and omb problems with quotes (Tickets #604 and #567)
darcs-hash:20080904065504-f6e2c-f0c770f52624e7151a93f2ed2b8813657ca88c14.gz
2008-09-04 02:55:04 -04:00
Evan Prodromou
98e941753b session token in userauthorization form
darcs-hash:20080829052847-84dde-a64918a75f8300ec8fb230202881691066147652.gz
2008-08-29 01:28:47 -04:00
Evan Prodromou
63438008e0 csrf protection in userauthorization
darcs-hash:20080829052732-84dde-0ebb7e32236b480cc3aa2eb7a4bb2b41ff6177d6.gz
2008-08-29 01:27:32 -04:00
Evan Prodromou
ea40dabb39 better error reporting in user authorization action
darcs-hash:20080822212111-84dde-2770093fcfaa6fe03abb1143d3828f0622382b45.gz
2008-08-22 17:21:11 -04:00
Evan Prodromou
5b01880685 name omb_listener param so we can refer to it in error msg
darcs-hash:20080816151057-84dde-e9df2c91a2711b235aa936a28e250715fc7c6d50.gz
2008-08-16 11:10:57 -04:00
zach
7e6870db91 base class is_readonly() now returns false by default
darcs-hash:20080722212056-ca946-e4bd9eef8e3d8991414932e9fc7b8c9a31f818c0.gz
2008-07-22 17:20:56 -04:00
zach
038f762bce Added is_readonly() method to all Actions
darcs-hash:20080722171501-ca946-160bad6c4f80be2b3b105ea9b913f1c0f9edb0ef.gz
2008-07-22 13:15:01 -04:00
Mike Cochrane
87b494f1eb Convert _t() to _() for gettext.
darcs-hash:20080708094531-533db-83399a46e6ec4c0fcc6249b0235961f969d1ae73.gz
2008-07-08 05:45:31 -04:00
Evan Prodromou
721d6f94c7 method
darcs-hash:20080702131507-84dde-507a6380fcab66c1fbcbaad6d1399c8a2f210acf.gz
2008-07-02 09:15:07 -04:00
Evan Prodromou
6ce7f932a6 fixup some TODOs, fix a bug in userauthorization
darcs-hash:20080611020810-84dde-32ab3b9e25532b92156d093dcf2ad24134cbcf4f.gz
2008-06-10 22:08:10 -04:00
Evan Prodromou
1ef5cf964e checks for user and sub in validate and better error check in remote save
darcs-hash:20080606055439-84dde-3abda48583737e89a9c75b3cff6722e9444d13a9.gz
2008-06-06 01:54:39 -04:00
Evan Prodromou
281dbc3177 debug info for authorizing token
darcs-hash:20080606053321-84dde-c6ee7a4565cce35873ad36890b609b90b65b472d.gz
2008-06-06 01:33:21 -04:00
Evan Prodromou
c5853abc39 handle errors in authorizing and saving remote profile
darcs-hash:20080606052631-84dde-4a8b4d8f70b0148d0b98b62875099f7d9cca9026.gz
2008-06-06 01:26:31 -04:00
Evan Prodromou
5fb2072bc9 use $_GET, not $args
darcs-hash:20080606052117-84dde-b9afe0037d9c75382f218f85eefec2a944e42dc6.gz
2008-06-06 01:21:17 -04:00
Evan Prodromou
c6f9e7c241 don't clone arrays!
darcs-hash:20080606051823-84dde-1ba6bdfe546b5307afd97c2c7715f8d35b464e83.gz
2008-06-06 01:18:23 -04:00
Evan Prodromou
9152085702 fix args in returnto
darcs-hash:20080606051331-84dde-1afe6e4a156cbb802b8b4231e065dc99ad07fef4.gz
2008-06-06 01:13:31 -04:00
Evan Prodromou
56021d9572 move avatar scaling and saving to Avatar and Profile
Extracted the code for setting a new original avatar to the Profile
class, and moved some of it to Avatar, too. This makes it easier to
have the same functionality whether an avatar is set using the profile
settings (for our users), or on a remote subscription. Necessitated
changing the filenaming function to just take an ID.

darcs-hash:20080605193708-84dde-a441cc0474951ce7f1a1da9310b5145c0b7c3070.gz
2008-06-05 15:37:08 -04:00
Evan Prodromou
1cdb7919ef a
darcs-hash:20080605183419-84dde-debe7f18565c960ee6886ac1330833bc8ae1ca5f.gz
2008-06-05 14:34:19 -04:00
Evan Prodromou
356f401986 bad validation of callback URL
darcs-hash:20080605040358-84dde-b2018db43791d1cbed722d3320cd0b62d6da94eb.gz
2008-06-05 00:03:58 -04:00
Evan Prodromou
24ff61d159 decided to validate tag uris rather than not validating any uris
darcs-hash:20080605040153-84dde-5d180f0d8ead2fc7c5eaca3deaf035ba31d3512a.gz
2008-06-05 00:01:53 -04:00
Evan Prodromou
29d9f0ae64 don't validate listenee URI
Validation of the listenee URI was failing for tag: URIs. So,
abandoned validation for now. Maybe in the future I'll add it back in,
with a second check for a valid tag URI if it doesn't work.

darcs-hash:20080605033911-84dde-0cf77fad66198a790450183eba11028e153f43d1.gz
2008-06-04 23:39:11 -04:00
Evan Prodromou
1254761770 clear request doesn't need an argument
darcs-hash:20080605025611-84dde-18fcf515bb9c727cafd3ca44454e7f18d8f8e752.gz
2008-06-04 22:56:11 -04:00
Evan Prodromou
2bf7717ddd correct order of params in get_token
darcs-hash:20080605025152-84dde-54da3eba220432b71d14ef7cfd4a8a7bf664316f.gz
2008-06-04 22:51:52 -04:00
Evan Prodromou
d241352dcc automatically prepend filename to debug output
darcs-hash:20080605024035-84dde-bc3abc4329f3181cffd26e83d37968ee6a02a26e.gz
2008-06-04 22:40:35 -04:00
Evan Prodromou
593f1e5e2c add some debugging code
darcs-hash:20080604201123-84dde-ff9ec8530474e194eee5e6fcc6190f7cd6fc5b5c.gz
2008-06-04 16:11:23 -04:00
Evan Prodromou
9d670d25f8 fix passing request around
darcs-hash:20080604191206-84dde-24d6a80c9e3886352d451ca0993ed0bb6baafd7a.gz
2008-06-04 15:12:06 -04:00
Evan Prodromou
d251e624a9 full interface for userauthorization
darcs-hash:20080604185131-84dde-2ff45e07ebba18c97803ed4a99121a6244ef1158.gz
2008-06-04 14:51:31 -04:00
Evan Prodromou
d266ab8c2d remove call to private get-version() method
darcs-hash:20080603115839-84dde-40da93a70e24274dcdc28ea2f4fd1e492fdb9e24.gz
2008-06-03 07:58:39 -04:00
Evan Prodromou
71c4032273 clear out lots of debugging code, add require to userauthorization
darcs-hash:20080603115218-84dde-f333d4541e1112487a5da1e3ad71064513e2228f.gz
2008-06-03 07:52:18 -04:00