wamo/gnu-social
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
097d0bd2fa
gnu-social/plugins
History
Brion Vibber 097d0bd2fa Ticket #2731: Fix for regression in posting to remote groups (regression in 2d4e0693c8) 
Changes in 2d4e0693c8 changed Ostatus_profile::filterReplies() (which sorts out the local, remote, and group recipients on incoming remote messages) from checking for remote profiles with a safe call to Ostatus_profile::staticGet() to calls through Ostatus_profile::ensureProfileURL() and Ostatus_profile::ensureWebfinger(), which throw exceptions and thus abort processing.
Since this was done before checking for local groups, the filter would fail when the ensure* functions determined it was looking at a local group and rightfully refused to create a remote group profile for it.

Changing the calls to the ensure* functions was done so we can record remote reply recipients for future reply-to-reply processing (the staticGet() call was a cheaper way to do a lookup when we knew we only actually had to process groups that somebody signed up to); most important fix is simply to actually check for the exception! :)

Here I'm changing the order of processing so we do the local group lookup first -- where it's nice and safe -- and then when we do the remote checks, we'll go ahead and gracefully skip that entry if the full remote lookup fails, so we'll still process any following recipients.
2010-09-16 14:43:27 -07:00
..
Adsense Update/add pot files for plugins. 2010-09-15 01:16:45 +02:00
APC Move standalone plugin files into subdirectories so they can have locale data, etc added to them at leisure. 2010-09-15 14:10:18 -07:00
Autocomplete Update/add pot files for plugins. 2010-09-15 01:16:45 +02:00
AutoSandbox Update/add pot files for plugins. 2010-09-15 01:16:45 +02:00
BitlyUrl Update/add pot files for plugins. 2010-09-15 01:16:45 +02:00
Blacklist Update/add pot files for plugins. 2010-09-15 01:16:45 +02:00
BlankAd wrong height for rectangle in BlankAd 2010-01-27 16:34:17 -05:00
BlogspamNet Move standalone plugin files into subdirectories so they can have locale data, etc added to them at leisure. 2010-09-15 14:10:18 -07:00
CacheLog Move standalone plugin files into subdirectories so they can have locale data, etc added to them at leisure. 2010-09-15 14:10:18 -07:00
CasAuthentication Update/add pot files for plugins. 2010-09-15 01:16:45 +02:00
ClientSideShorten Update/add pot files for plugins. 2010-09-15 01:16:45 +02:00
Comet htmloutputter->script() special cases src's that begin with plugin/ or local/ so that plugins don't need to include common_path() in every call to $action->script() 2010-02-17 12:03:14 -05:00
DirectionDetector Update/add pot files for plugins. 2010-09-15 01:16:45 +02:00
DiskCache Move standalone plugin files into subdirectories so they can have locale data, etc added to them at leisure. 2010-09-15 14:10:18 -07:00
Disqus Move standalone plugin files into subdirectories so they can have locale data, etc added to them at leisure. 2010-09-15 14:10:18 -07:00
Echo Move standalone plugin files into subdirectories so they can have locale data, etc added to them at leisure. 2010-09-15 14:10:18 -07:00
EmailAuthentication Update/add pot files for plugins. 2010-09-15 01:16:45 +02:00
Enjit XMPP queued output & initial retooling of DB queue manager to support non-Notice objects. 2010-01-22 12:52:36 -08:00
Facebook Update/add pot files for plugins. 2010-09-15 01:16:45 +02:00
FirePHP Update/add pot files for plugins. 2010-09-15 01:16:45 +02:00
Geonames Move standalone plugin files into subdirectories so they can have locale data, etc added to them at leisure. 2010-09-15 14:10:18 -07:00
GeoURL Move standalone plugin files into subdirectories so they can have locale data, etc added to them at leisure. 2010-09-15 14:10:18 -07:00
GoogleAnalytics Move standalone plugin files into subdirectories so they can have locale data, etc added to them at leisure. 2010-09-15 14:10:18 -07:00
Gravatar Update/add pot files for plugins. 2010-09-15 01:16:45 +02:00
Imap Update/add pot files for plugins. 2010-09-15 01:16:45 +02:00
InfiniteScroll Update/add pot files for plugins. 2010-09-15 01:16:45 +02:00
LdapAuthentication Update/add pot files for plugins. 2010-09-15 01:16:45 +02:00
LdapAuthorization Update/add pot files for plugins. 2010-09-15 01:16:45 +02:00
LdapCommon Assigning my copyrights to the Free Software Foundation 2010-05-27 18:27:33 -04:00
LilUrl Update/add pot files for plugins. 2010-09-15 01:16:45 +02:00
Linkback Move standalone plugin files into subdirectories so they can have locale data, etc added to them at leisure. 2010-09-15 14:10:18 -07:00
Mapstraction Update/add pot files for plugins. 2010-09-15 01:16:45 +02:00
Memcache Move standalone plugin files into subdirectories so they can have locale data, etc added to them at leisure. 2010-09-15 14:10:18 -07:00
Memcached Move standalone plugin files into subdirectories so they can have locale data, etc added to them at leisure. 2010-09-15 14:10:18 -07:00
Meteor Meteor realtime plugin: use persistent connections by default when pushing updates from our queue threads 2010-06-03 17:41:26 -07:00
Minify Update/add pot files for plugins. 2010-09-15 01:16:45 +02:00
Mobile Init for WAP 2.0 and XHTML Mobile Profile support. WAP20Plugin is a 2009-10-02 11:46:14 +00:00
MobileProfile Update/add pot files for plugins. 2010-09-15 01:16:45 +02:00
Mollom Use plugin configuration instead of common_config() 2010-01-06 00:20:15 -05:00
NoticeTitle Update/add pot files for plugins. 2010-09-15 01:16:45 +02:00
OpenExternalLinkTarget Update/add pot files for plugins. 2010-09-15 01:16:45 +02:00
OpenID Update/add pot files for plugins. 2010-09-15 01:16:45 +02:00
OpenX move script into OpenXPlugin::showAd() so it works 2010-01-27 18:44:46 -05:00
Orbited htmloutputter->script() special cases src's that begin with plugin/ or local/ so that plugins don't need to include common_path() in every call to $action->script() 2010-02-17 12:03:14 -05:00
OStatus Ticket #2731: Fix for regression in posting to remote groups (regression in 2d4e0693c8) 2010-09-16 14:43:27 -07:00
PiwikAnalytics Move standalone plugin files into subdirectories so they can have locale data, etc added to them at leisure. 2010-09-15 14:10:18 -07:00
PostDebug Update/add pot files for plugins. 2010-09-15 01:16:45 +02:00
PoweredByStatusNet Update/add pot files for plugins. 2010-09-15 01:16:45 +02:00
PtitUrl Update/add pot files for plugins. 2010-09-15 01:16:45 +02:00
Realtime Include notice fragment on 'in context' links in Realtime plugin family. 2010-05-17 19:47:44 +00:00
Recaptcha Update/add pot files for plugins. 2010-09-15 01:16:45 +02:00
RegisterThrottle Update/add pot files for plugins. 2010-09-15 01:16:45 +02:00
RequireValidatedEmail Update/add pot files for plugins. 2010-09-15 01:16:45 +02:00
ReverseUsernameAuthentication Update/add pot files for plugins. 2010-09-15 01:16:45 +02:00
RSSCloud Update/add pot files for plugins. 2010-09-15 01:16:45 +02:00
Sample Update/add pot files for plugins. 2010-09-15 01:16:45 +02:00
SimpleUrl Update/add pot files for plugins. 2010-09-15 01:16:45 +02:00
Sitemap add last-modified header to sitemaps to keep them from getting regenerated 2010-08-10 23:35:47 -07:00
SphinxSearch Performance fix on Sphinx search results: use id instead of created timestamp for reverse date sorting; should give same result but doesn't trigger a filesort. 2010-03-02 12:06:40 -08:00
Spotify Move standalone plugin files into subdirectories so they can have locale data, etc added to them at leisure. 2010-09-15 14:10:18 -07:00
SubMirror Update/add pot files for plugins. 2010-09-15 01:16:45 +02:00
SubscriptionThrottle Move standalone plugin files into subdirectories so they can have locale data, etc added to them at leisure. 2010-09-15 14:10:18 -07:00
TabFocus Update/add pot files for plugins. 2010-09-15 01:16:45 +02:00
Template Move standalone plugin files into subdirectories so they can have locale data, etc added to them at leisure. 2010-09-15 14:10:18 -07:00
TightUrl Update/add pot files for plugins. 2010-09-15 01:16:45 +02:00
TinyMCE Update/add pot files for plugins. 2010-09-15 01:16:45 +02:00
TwitterBridge Update/add pot files for plugins. 2010-09-15 01:16:45 +02:00
UrlShortener Assigning my copyrights to the Free Software Foundation 2010-05-27 18:27:33 -04:00
UserFlag Added block link to subscription notification emails; block action can now take a profile ID on the URL; added profile details to block page so there's an indication of who you're blocking before you pull the trigger. 2010-05-20 14:24:44 -07:00
UserLimit Move standalone plugin files into subdirectories so they can have locale data, etc added to them at leisure. 2010-09-15 14:10:18 -07:00
WikiHashtags Move standalone plugin files into subdirectories so they can have locale data, etc added to them at leisure. 2010-09-15 14:10:18 -07:00
WikiHowProfile Update/add pot files for plugins. 2010-09-15 01:16:45 +02:00
XCache Move standalone plugin files into subdirectories so they can have locale data, etc added to them at leisure. 2010-09-15 14:10:18 -07:00
README-plugins add a quickie plugins/ dir readme mentioning how to add plugins, plus ref to wiki pages 2010-01-18 09:37:42 -08:00