wamo/gnu-social
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
7440dc2145
gnu-social/plugins
History
Joshua Judson Rosen 7440dc2145 Prevent spurious refusals of legitimate notices posted to users via Salmon. 
Make the logic match the intent described in the comments.

The intent is clearly "accept notices whenever (A or B or C)", but
the logic implemented was more like "not ((not A) or (not B) or (not C))",
which is a basical boolean algebra fail (each of those ORs need to
become ANDs for double-negation to work).

The practical implication was that, for example, writing a reply
to someone else's notice and including an @-reference to _another_
user on another site to bring them into the discussion would
fail to deliver the notice to the new user because their server
would basically say `oh no, you can't message this user
from someone else's thread' because an earlier check for
the `A' or `C' parts of `(A or B or C)' prevents `B' from
being checked.

cf.: <http://status.hackerposse.com/notice/55846>, which was
refused by the nhcrossing.com server because it didn't know
about <http://sn.jonkman.ca/notice/93724>, even though it would
have passed the later `notice contains a reference to a local user'
check if not for an exception being prematurely thrown.

The whole idea of reporting `which specific check FAILED'
in an `if ANY SUCCEEDS' analysis is just bogus, so nix all of
the distinct ClientExceptions--a single `ALL FAILED' exception
is the only one that makes sense.
2014-05-05 13:35:38 +02:00
..
AccountManager Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
Activity s/bestUrl/getUrl/ for notices and microapp objects 2014-04-29 19:46:58 +02:00
ActivitySpam Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
Adsense Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
Aim Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
AnonymousFave Cosmetic changes to common_redirect, clientError, serverError 2014-03-10 00:25:57 +01:00
APC Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
ApiLogger Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
AuthCrypt Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
Autocomplete Autocomplete: don't match non-subscribed group-names. 2014-05-05 13:32:18 +02:00
AutoSandbox Code cleanup and enabling User object's etc. getUri() 2014-04-28 14:08:42 +02:00
Awesomeness Localisation updates from http://translatewiki.net. 2012-06-30 11:10:38 +00:00
BitlyUrl Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
Blacklist Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
BlankAd Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
Blog s/bestUrl/getUrl/ for notices and microapp objects 2014-04-29 19:46:58 +02:00
BlogspamNet User agents and generators changed to GNU social 2013-11-01 13:46:05 +01:00
Bookmark s/bestUrl/getUrl/ for notices and microapp objects 2014-04-29 19:46:58 +02:00
CacheLog Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
CasAuthentication Cosmetic changes to common_redirect, clientError, serverError 2014-03-10 00:25:57 +01:00
ClientSideShorten Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
Comet Partly revert 97830b0701 (thanks _MrB_) 2014-02-27 23:30:35 +01:00
Cronish Cronish jobs by the minute. These run very often! 2013-11-20 23:26:41 +01:00
DirectionDetector Localisation updates from http://translatewiki.net. 2012-06-30 11:10:38 +00:00
Directory Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
DiskCache Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
DomainStatusNetwork Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
DomainWhitelist Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
EmailAuthentication EmailAuthentication enabled by default 2014-04-28 12:39:57 +02:00
EmailRegistration Cosmetic changes to common_redirect, clientError, serverError 2014-03-10 00:25:57 +01:00
EmailReminder Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
EmailSummary getConversationUrl introduced for linking to conversations 2014-05-01 15:25:19 +02:00
Enjit The overloaded DB_DataObject function staticGet is now called getKV 2013-08-18 13:13:56 +02:00
Event s/bestUrl/getUrl/ for notices and microapp objects 2014-04-29 19:46:58 +02:00
ExtendedProfile Cosmetic changes to common_redirect, clientError, serverError 2014-03-10 00:25:57 +01:00
FacebookBridge Notice URIs are not necessarily URLs. 2014-04-30 20:44:23 +02:00
FirePHP Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
FollowEveryone Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
ForceGroup Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
Geonames Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
GeoURL Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
GNUsocialPhoto s/bestUrl/getUrl/ for notices and microapp objects 2014-04-29 19:46:58 +02:00
GNUsocialPhotos common_redirect and clientError exits, so refactor 2014-03-10 00:24:32 +01:00
GNUsocialProfileExtensions Cosmetic changes to common_redirect, clientError, serverError 2014-03-10 00:25:57 +01:00
GNUsocialVideo s/bestUrl/getUrl/ for notices and microapp objects 2014-04-29 19:46:58 +02:00
GoogleAnalytics Localisation updates from http://translatewiki.net. 2012-06-30 11:10:38 +00:00
Gravatar Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
GroupFavorited Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
GroupPrivateMessage Datetime representation aligned for microformats2 2014-04-28 18:54:55 +02:00
Imap Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
InfiniteScroll Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
InProcessCache Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
Irc IrcManager does not have serverError, so it must throw ServerException 2014-03-10 00:30:41 +01:00
LdapAuthentication Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
LdapAuthorization Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
LdapCommon plugins onAutoload now only overloads if necessary (extlibs etc.) 2013-08-28 16:10:30 +02:00
LilUrl Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
Linkback Notice URIs are not necessarily URLs. 2014-04-30 20:44:23 +02:00
LinkPreview Preparing plugins for no-minify-in-core-policy 2014-02-24 01:01:34 +01:00
LogFilter Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
LRDD Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
Mapstraction s/bestUrl/getUrl/ for notices and microapp objects 2014-04-29 19:46:58 +02:00
Memcache Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
Memcached Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
Meteor Partly revert 97830b0701 (thanks _MrB_) 2014-02-27 23:30:35 +01:00
Minify Cosmetic changes to common_redirect, clientError, serverError 2014-03-10 00:25:57 +01:00
Mobile Use profile->getBestName() instead of more complex i18n unfriendly construction. 2011-04-25 22:44:21 +02:00
MobileProfile Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
ModHelper Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
ModLog Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
ModPlus Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
Mollom Localisation updates from http://translatewiki.net. 2012-06-30 11:10:38 +00:00
Msn Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
NoticeTitle s/bestUrl/getUrl/ for notices and microapp objects 2014-04-29 19:46:58 +02:00
OfflineBackup Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
OpenExternalLinkTarget Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
OpenID Cosmetic changes to common_redirect, clientError, serverError 2014-03-10 00:25:57 +01:00
OpenX Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
OpportunisticQM Added OpportunisticQM README that has good docs 2014-03-06 14:45:18 +01:00
Orbited Partly revert 97830b0701 (thanks _MrB_) 2014-02-27 23:30:35 +01:00
OStatus Prevent spurious refusals of legitimate notices posted to users via Salmon. 2014-05-05 13:35:38 +02:00
PiwikAnalytics Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
Poll s/bestUrl/getUrl/ for notices and microapp objects 2014-04-29 19:46:58 +02:00
PostDebug Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
PoweredByStatusNet Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
PtitUrl Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
QnA Notice URIs are not necessarily URLs. 2014-04-30 20:44:23 +02:00
Realtime getConversationUrl introduced for linking to conversations 2014-05-01 15:25:19 +02:00
Recaptcha Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
RegisterThrottle RegisterThrottle didn't save the created time 2014-03-07 21:23:49 +01:00
RequireValidatedEmail Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
ReverseUsernameAuthentication Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
RSSCloud plugins onAutoload now only overloads if necessary (extlibs etc.) 2013-08-28 16:10:30 +02:00
Sample Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
SearchSub Cosmetic changes to common_redirect, clientError, serverError 2014-03-10 00:25:57 +01:00
ShareNotice s/bestUrl/getUrl/ for notices and microapp objects 2014-04-29 19:46:58 +02:00
SimpleUrl Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
Sitemap Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
SiteNoticeInSidebar plugins onAutoload now only overloads if necessary (extlibs etc.) 2013-08-28 16:10:30 +02:00
SlicedFavorites Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
SphinxSearch Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
Spotify User agents and generators changed to GNU social 2013-11-01 13:46:05 +01:00
SQLProfile Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
SQLStats Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
StrictTransportSecurity Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
SubMirror s/bestUrl/getUrl/ for notices and microapp objects 2014-04-29 19:46:58 +02:00
SubscriptionThrottle Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
TabFocus Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
TagSub Cosmetic changes to common_redirect, clientError, serverError 2014-03-10 00:25:57 +01:00
TightUrl Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
TinyMCE Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
TwitterBridge Notice URIs are not necessarily URLs. 2014-04-30 20:44:23 +02:00
UserFlag Cosmetic changes to common_redirect, clientError, serverError 2014-03-10 00:25:57 +01:00
UserLimit Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
VideoThumbnails VideoThumbnails failure detection improved. 2014-04-29 19:45:42 +02:00
WebFinger Notice metadata for WebFinger. Not sure if implemented properly. 2013-11-01 17:37:18 +01:00
WikiHashtags Localisation updates from http://translatewiki.net. 2012-06-30 11:10:38 +00:00
WikiHowProfile Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
XCache Using GNUSOCIAL_VERSION instead of STATUSNET_VERSION 2013-11-01 13:51:41 +01:00
Xmpp Updated and moved XMPP documentation into plugin. 2014-03-11 00:11:25 +01:00
YammerImport LOG_WARNING, not LOG_WARN 2013-10-06 01:33:10 +02:00
GNUsocialTemplatePlugin.php
README-plugins