wamo/gnu-social
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
89727549a6
gnu-social/classes
History
Brion Vibber af1cbc6fe3 Fix ticket #2181: Can't save #000000 (black) in color fields on design page 
It seems to have actually been saving correctly, but the update of the colors on the form success page wasn't working properly.
When a design object is pulled out of the database, the numeric fields are read in as strings, so black comes back as "0".
But, when we populate the new object and then stick it live, we've populated it with actual integers; with memcache on these might live for a while in the cache...

The fallback code in Design::toWebColor() did a check ($color == null) which would be false for the string "0", but counts as true for the *integer* 0.
Thus, the display code would initially interpret the correctly-saved black color as "use default".

Changing the check to === against null and "" empty string avoids the false positive on integers, and lets us see our nice black text immediately after save.
2011-01-04 13:09:44 -08:00
..
Avatar.php * i18n/L10n and translator documentation updates. 2010-09-28 23:21:09 +02:00
Config.php ...and drop the unnecessary &reference from child class pkeyGet() overrides. 2010-01-06 14:28:40 -08:00
Confirm_address.php change function headers to K&R style 2008-12-23 14:33:23 -05:00
Consumer.php * i18n/L10n and translator documentation updates. 2010-09-28 23:21:09 +02:00
Conversation.php * i18n/L10n and translator documentation updates. 2010-09-28 23:21:09 +02:00
Deleted_notice.php check correct define (not backwards compatible) 2009-09-15 21:12:44 -04:00
Design.php Fix ticket #2181: Can't save #000000 (black) in color fields on design page 2011-01-04 13:09:44 -08:00
Fave.php add fixme for since_id/max_id on fave streaming (?) 2010-12-17 14:32:06 -08:00
File_oembed.php Encapsulate the oEmbed -> oohembed fallback into oEmbedHelper class. Also added a chance to whitelist sites that don't show discovery info but do have oEmbed API endpoints, and to provide alternate APIs for some common services. 2010-11-12 17:41:35 -08:00
File_redirection.php Fix for tickets #2917, #2262: user URL shortening options not being applied in non-web channels 2010-12-02 13:41:56 -08:00
File_thumbnail.php Save oEmbed photo references as thumbnails if there's not a separate thumbnail_url entry in the return data. This fixes thumb saving for Flickr photo references. 2010-11-12 14:03:08 -08:00
File_to_post.php Bad method call in File_to_post 2010-12-29 13:28:32 -08:00
File.php method to count notices linking to an URL 2010-12-28 13:44:49 -08:00
Foreign_link.php * i18n/L10n and translator documentation updates. 2010-09-28 23:21:09 +02:00
Foreign_service.php * i18n/L10n and translator documentation updates. 2010-09-28 23:21:09 +02:00
Foreign_subscription.php * i18n/L10n and translator documentation updates. 2010-09-28 23:21:09 +02:00
Foreign_user.php * i18n/L10n and translator documentation updates. 2010-09-28 23:21:09 +02:00
Group_alias.php Fixed problem causing 500 error on notices containing a non-existent group 2010-03-06 00:30:15 +00:00
Group_block.php * i18n/L10n and translator documentation updates. 2010-09-28 23:21:09 +02:00
Group_inbox.php * i18n/L10n and translator documentation updates. 2010-09-28 23:21:09 +02:00
Group_member.php membership stream method and return membership from join() in Group_member class 2010-12-13 13:50:39 -05:00
Inbox.php * i18n/L10n and translator documentation updates. 2010-09-28 23:21:09 +02:00
Invitation.php * i18n/L10n and translator documentation updates. 2010-09-28 23:21:09 +02:00
Local_group.php * add translator documentation 2010-07-29 13:01:04 +02:00
Location_namespace.php flip x flag on generated files 2009-10-21 22:43:41 -04:00
Login_token.php * add translator documentation 2010-07-29 13:01:04 +02:00
Memcached_DataObject.php Memcache_DataObject checks for PEAR::isError() on results 2010-12-26 21:08:20 -08:00
Message.php URL shortening fix for direct messages: if we're going to shorten the text, shorten the rendered text too. 2010-12-02 13:59:51 -08:00
Nonce.php * i18n/L10n and translator documentation updates. 2010-09-28 23:21:09 +02:00
Notice_inbox.php Dropped deprecated timestamp-based 'since' parameter for all API methods. When it sneaks in it can cause some very slow queries due to mismatches with the indexing. 2010-03-02 11:54:02 -08:00
Notice_source.php * i18n/L10n and translator documentation updates. 2010-09-28 23:21:09 +02:00
Notice_tag.php Notice_tag::url() gets the URL for a tag string 2010-12-19 10:15:56 -05:00
Notice.php Delete file links when Notice is deleted 2010-12-28 13:44:18 -08:00
Oauth_application_user.php Revert DB change for OAuth. Change compound key for oauth_application_user 2010-10-20 11:41:04 -07:00
Oauth_application.php Ticket #2811 use more consistent max limit for OAuth application registration descriptions; now using the field max of 255 rather than $config['site']['textlimit'] as fallback if $config['application']['desclimit'] is unset or out of bounds. 2010-10-11 12:52:32 -07:00
Oauth_token_association.php i18n/L10n updates, translator docs updated, superfluous whitespace removed. 2010-10-21 03:10:46 +02:00
Profile_block.php define LACONICA and accept LACONICA for backwards compatibility 2009-08-26 10:41:36 -04:00
Profile_role.php Background deletion of user accounts. Notices are deleted in chunks, then the user itself when they're all gone. 2010-03-15 16:08:00 -07:00
Profile_tag.php * i18n/L10n and translator documentation updates. 2010-09-28 23:42:18 +02:00
Profile.php Merge branch 'master' into 0.9.x 2010-12-28 11:37:38 -08:00
Queue_item.php Ticket #2797: replace addslashes() with explicit escape calls on the DB objects 2010-11-19 15:06:26 -08:00
Related_group.php some class files had x bit set 2009-05-22 21:11:46 -04:00
Remember_me.php * i18n/L10n and translator documentation updates. 2010-09-28 23:42:18 +02:00
Remote_profile.php * i18n/L10n and translator documentation updates. 2010-09-28 23:42:18 +02:00
Reply.php Update sorting on reply/mentions timeline: added reply_profile_id_modified_notice_id_idx index to reply table 2010-12-17 14:43:45 -08:00
Safe_DataObject.php * i18n/L10n and translator documentation updates. 2010-09-28 23:42:18 +02:00
Session.php Workaround for locally-handled sessions breaking on PHP 5.3 with APC enabled. 2010-12-10 14:12:02 -08:00
Sms_carrier.php * i18n/L10n and translator documentation updates. 2010-09-28 23:42:18 +02:00
Status_network_tag.php * translator documentation added. 2010-10-23 19:20:51 +02:00
status_network.ini oops. really embarassing typo (that explains some weird behaviour) 2010-07-29 16:32:41 -04:00
Status_network.php * i18n/L10n and translator documentation updates. 2010-09-28 23:42:18 +02:00
statusnet.ini Use a new table (oauth_token_association) to associate authorized 2010-10-20 17:21:04 -07:00
statusnet.links.ini PHP 5.3 compatibility hack for DB_DataObject 2010-02-12 11:15:12 -08:00
Subscription.php Merge branch '0.9.x' into activityatompub 2010-12-11 11:03:02 -05:00
Token.php Add verifier and verified callback to token for OAuth 1.0a 2010-01-14 02:41:10 +00:00
User_group.php Merge branch 'master' into 0.9.x 2010-12-28 11:37:38 -08:00
User_location_prefs.php Add magic formula to keep DB_DataObject from treating location prefs pkey as autoincrement 2009-12-30 08:56:43 -10:00
User_username.php * i18n/L10n and translator documentation updates. 2010-09-28 23:42:18 +02:00
User.php Update sorting for User::repeatedByMe() -- currently unused. Likely not ideally indexed yet. 2010-12-17 15:28:55 -08:00