Stephen Paul Weber
a9b1b60a97
Refactor on File::processNew
...
The code was so involved there was even a comment asking for a refactor.
Now, File_redirection::where always returns a nice File_redirection
object instead of an array or string or nothing. The object is
either one which already existed or else a new, unsaved object.
Instead of duplicating "does it exist" checks everywhere, do it in
File_redirection::where. You either get what exists or something to save.
An unsaved File_redirection may be paired with an unsaved File.
You will want to save the File first (using ->saveFile()) and put the
id in File_redirection#file_id before saving.
2015-11-02 05:15:08 +00:00
Mikael Nordfeldth
2c8536dbf0
Link source==share notices
2015-10-14 01:30:29 +02:00
Mikael Nordfeldth
401b774c2f
Only set ->actor in a case where it has not yet been set
...
Otherwise it could overwrite it with the wrong actor (the "second round"
for share activities)
2015-10-14 01:20:50 +02:00
Mikael Nordfeldth
d260808cd3
intval for type assurance
2015-10-14 01:16:22 +02:00
Mikael Nordfeldth
79c40bc73b
Type-aware comparison is necessary for Notice is_local/scope
2015-10-14 00:42:15 +02:00
Mikael Nordfeldth
b6aeff89c4
Call Notice::saveActivity instead of Ostatus_profile->processActivity
2015-10-14 00:10:54 +02:00
Mikael Nordfeldth
236bf0b0f5
Remote notice creators should not have notice is_local default to LOCAL_PUBLIC
2015-10-14 00:10:01 +02:00
Mikael Nordfeldth
005c108118
Shared activities were missing the actor
2015-10-13 23:40:35 +02:00
Mikael Nordfeldth
5b307c0417
Add a url test in Notice::saveActivity
2015-10-13 23:39:40 +02:00
Mikael Nordfeldth
65adefe170
Wrong variable names in SharePlugin
2015-10-13 23:18:13 +02:00
Mikael Nordfeldth
4b69ef41e2
Bad variable name in File_redirection
2015-10-13 22:57:45 +02:00
Mikael Nordfeldth
e379c49d49
Removing excess debug logging
2015-10-13 22:55:27 +02:00
Mikael Nordfeldth
c8a907c828
Bookmark:addNew did not add a proper rel=related
2015-10-13 12:31:35 +02:00
Mikael Nordfeldth
3f4d4cb7a0
Better error handling in Bookmark
2015-10-12 18:28:32 +02:00
Mikael Nordfeldth
67e7bc55ea
Bookmarks are almost migrated
...
Now they are just not being saved in the bookmark table.
2015-10-12 17:48:23 +02:00
Mikael Nordfeldth
7834e67583
Just a functionifying of Notice->rendered
2015-10-12 17:16:13 +02:00
Mikael Nordfeldth
297d68f36c
Change Bookmark plugin version details
2015-10-12 09:47:30 +02:00
Mikael Nordfeldth
0e588bdeca
Woops, put the bookmark get* functions in the wrong file.
2015-10-11 22:08:28 +02:00
Mikael Nordfeldth
1dac0e709a
First step of making Bookmark saveActivity-compatible
2015-10-10 23:47:43 +02:00
Mikael Nordfeldth
b209276e72
Stricter typing for Bookmark plugin
2015-10-10 23:15:51 +02:00
Mikael Nordfeldth
5726459629
unmaintained plugins that accidentally got translations
2015-10-10 22:40:05 +02:00
mmn
0926316a76
Merge branch 'master' into 'nightly'
...
convert activity stream RFC3339 dates to mysql datetime format when saving remote event dates to db
See merge request !34
2015-10-10 20:38:01 +00:00
mmn
3255e2e1b8
Merge branch 'page_title_showstream' into 'nightly'
...
Show page title in user's profile page
Enable page title on user's profile page to make it consistent with all other pages and better orient users.
See merge request !22
2015-10-10 20:36:59 +00:00
mmn
32f77dbf05
Merge branch 'translation-snapshot-october-2015' into 'nightly'
...
Snapshot of the Transifex translation project - October 2015
It's been 7 months since the last localization update, and the files in the repository are out of sync with the current state of the project. Our Transifex team has since grown to 63 translators, many of them are active members of the GNU social community. I don't know how we will resolve this situation, but it is clear that we have to act. If you plan to redesign the plugin system in the future to support external repository for localizations, that would work as well. But now, please let us do an update. It would be a serious disgrace to the community to throw all of their hard work away.
See merge request !32
2015-10-10 20:36:04 +00:00
mmn
89d3d9b2ce
Merge branch 'usergroups_page' into 'nightly'
...
Improve display of user's groups page.
* Show page notice as for subscriptions
* Show instructions when user has no groups
* Add explanation of remote groups and link to skilledtest wiki
Here is how it looks when a logged in user is not following groups yet
After following a group, you still see the instruction notice. This way you have links to searching groups and creating a new one.
Finally when logged out:
The current version on nightly has basically no text at all.
See merge request !25
2015-10-10 20:35:36 +00:00
mmn
77951647ce
Merge branch 'oauth-default-icon' into 'nightly'
...
Add default icon to OAuth apps
When MySQL runs in strict mode, it doesn't seem possible to add a new OAuth app.
This is because:
* The 'icon' field has no defaults and also has NOT NULL constraint.
* GS uploads/sets the icon[1] (if provided) after the SQL insert[2]
The easiest fix seemed to be to provide a default icon value.
This change sets the default to the "blue peg" default avatar from the base theme.
[1]
7f30e61402/actions/newapplication.php (L176)7f30e61402/actions/newapplication.php (L186)!29
2015-10-10 20:34:22 +00:00
mmn
238d2a3876
Merge branch 'link-atom-fix' into 'nightly'
...
atom: <link> urls should be attr, not content
Some activities (ex: repeats and follows) have <link>s like this:
<link rel="alternate" type="text/html">http://example.org </link>
This commit changes them to:
<link rel="alternate" type="text/html" href="http://example.org "/>
See merge request !30
2015-10-10 20:33:58 +00:00
Mikael Nordfeldth
fe9457daea
Syntax and minor fixes
...
Deleted_notice and Bookmark getByPK assocative array for example.
2015-10-10 22:23:24 +02:00
Mikael Nordfeldth
174586bd51
Some code aligning for consistency
2015-10-10 22:09:51 +02:00
Mikael Nordfeldth
cae43344ec
Start reworking Bookmark plugin for more modern code
2015-10-10 21:56:02 +02:00
Mikael Nordfeldth
18f07a48e8
Using some Managed_DataObject::getByPK calls for consistency
2015-10-10 21:40:02 +02:00
Mikael Nordfeldth
37f2da03e1
newUri might as well be put in Managed_DataObject
2015-10-10 21:31:26 +02:00
Mikael Nordfeldth
45bc192625
If that $options key wasn't set, this won't change anything anyway
2015-10-10 21:22:07 +02:00
Mikael Nordfeldth
a793d211d2
Match parent class definition of clientError
2015-10-10 20:51:53 +02:00
Mikael Nordfeldth
b4c51b2d39
Use an atom:link to ApiMediaUpload response instead of mediahref
...
'cause why not?
2015-10-10 20:41:14 +02:00
Mikael Nordfeldth
9728270acd
Add mediahref in our incredibly arbitrary response
2015-10-10 17:15:29 +02:00
Mikael Nordfeldth
5d91c9a820
Don't send multiple error responses in ApiMediaUpload :)
2015-10-10 17:12:44 +02:00
Mikael Nordfeldth
2ad7c4313d
Search engine fix because Directory did a 'join'
...
Colliding columns with a very lacking error message from DB ;)
2015-10-10 12:16:12 +02:00
Mikael Nordfeldth
6376b78a80
I think I have made the delete verb generate proper AS
...
ActivityStreams had a different/better definition than me
in how to define the Delete verb data:
http://wiki.activitystrea.ms/w/page/23541872/Delete
2015-10-10 11:08:17 +02:00
Hannes Mannerheim
a9f879c2ba
better explanation
2015-10-10 00:20:32 +02:00
Hannes Mannerheim
b24191f9f9
convert activity stream RFC3339 dates to mysql datetime format when saving remote event dates to db
2015-10-10 00:11:54 +02:00
mmn
3154302b53
Merge branch 'master' into 'nightly'
...
make events federate
See merge request !33
2015-10-09 14:43:45 +00:00
Hannes Mannerheim
61ed36e446
make event urls federate
2015-10-09 16:22:47 +02:00
Mikael Nordfeldth
dd149a76f3
AtomPub should work now, at least for post/note
2015-10-09 16:19:26 +02:00
Mikael Nordfeldth
2dfd34b12d
Post verb default type is 'note'
2015-10-09 16:18:12 +02:00
Hannes Mannerheim
55655ba319
make event location federate
2015-10-09 16:16:13 +02:00
Hannes Mannerheim
827dffb94c
make event dates federate
2015-10-09 16:00:33 +02:00
Mikael Nordfeldth
2d3f1ef520
You don't have to push objects as references
2015-10-09 15:45:23 +02:00
Mikael Nordfeldth
0bdbb32f3b
Consistent camelcasing
2015-10-09 15:45:05 +02:00
Mikael Nordfeldth
5dc718c54d
Make Bsaic Auth work properly with RW actions
2015-10-09 15:43:17 +02:00
