Brion Vibber
db4d69f099
Quick hack to discard twitter broadcast queue items on failure *IF* config option 'twitter' 'ignore_errors' is on:
...
$config['twitter']['ignore_errors'] = true;
A longer-term solution is to patch up the indirect retry handling to count retries better, or delay for later retry sensibly.
2010-12-07 12:11:37 -08:00
Brion Vibber
b4fc54c308
Flush router cache when saving Twitter admin settings: adding/removing keys can enable/disable some actions. This avoids having users' Twitter settings unreachable after adding your keys to an installation with TwitterBridge on but not pre-configured.
2010-11-30 12:46:33 -08:00
Brion Vibber
94f2f96f2e
Ticket #2724 : gracefully handle attempts to delete or fave/unfave a remote Twitter notice if a failure occurs.
...
Most annoying error case being where the notice was already faved or deleted on Twitter! :)
Such errors will now just fail out and log a note to the syslog -- the rest of what we were doing will continue on unhindered, so you can still delete, favorite, etc and it just won't sync the info over in that case.
2010-11-19 15:51:08 -08:00
Brion Vibber
6291e8201f
Fix for failure edge case in TwitterBridge outgoing repeat/retweets.
...
When the retweet failed with a 403 error (say due to it being a private tweet, which can't be retweeted) we would end up mishandling the return value from our internal error handling.
Instead of correctly discarding the message and closing out the queue item, we ended up trying to save a bogus twitter<->local ID mapping, which threw another exception and lead the queue system to re-run it.
- Fixed the logic check and return values for the retweet case in broadcast_twitter().
- Added doc comments explaining the return values on some functions in twitter.php
- Added check on Notice_to_status::saveNew() for empty input -- throw an exception before we try to actually insert into db. :)
2010-11-12 13:06:41 -08:00
Siebrand Mazeland
7a564276a9
Localisation updates from http://translatewiki.net .
2010-10-28 01:58:43 +02:00
Siebrand Mazeland
1545c1228b
Localisation updates from http://translatewiki.net .
2010-10-23 20:50:55 +02:00
Brion Vibber
e292d8fb65
Fix for 140-char replies being unexpectedly cropped when bridged to Twitter.
...
This drops the '@' -> ' @' hack for CURL meta-chars in outgoing Twitter bridge, added in commit 04b95c25
back in the day.
The Twitter bridge has since been switched from using direct CURL calls to using HTTPClient, which even with the CURL backend enabled doesn't trigger this issue, as POST parameters are formatted directly.
Prepending the space before we did the message cropping was leading to 140-char messages getting cropped unnecessarily, which was confusing:
Examples of broken messages:
http://identi.ca/notice/57172587 vs http://twitter.com/marjoleink/status/28398050691
http://identi.ca/notice/57172878 vs http://twitter.com/marjoleink/status/28398492563
2010-10-22 12:10:11 -07:00
Siebrand Mazeland
e6df1b19df
Localisation updates from http://translatewiki.net
2010-10-18 22:03:29 +02:00
Siebrand Mazeland
5215423ea9
Localisation updates from http://translatewiki.net .
2010-10-09 16:15:48 +02:00
Brion Vibber
67dc78b621
Merge branch 'fatals' into 0.9.x
2010-10-08 11:28:51 -07:00
Brion Vibber
5fe59322bc
Check for Twitter foreign link actually existing before trying to delete it; friendlier error message in TwittersettingsAction
2010-10-08 11:12:36 -07:00
Siebrand Mazeland
458512aafd
Localisation updates from http://translatewiki.net
2010-10-03 22:46:38 +02:00
Siebrand Mazeland
08054e85fe
Localisation updates from http://translatewiki.net .
2010-10-01 22:34:59 +02:00
Brion Vibber
1acc7d66c6
Always specify UTF-8 targt charset for html_entity_decode(); default is 8-bit ISO-8859-1 which causes things to break when we later pass them through things that expect to work with UTF-8. For instance, running through preg_replace() with the /u option results in NULL, leading to problems with OStatus and SubMirror generating their plaintext versions and doing length-cropping.
2010-09-30 11:29:31 -07:00
Siebrand Mazeland
ec7ab3af4d
Localisation updates from http://translatewiki.net
...
* first export of L10n for languages other than English. Could use some testing/QA.
2010-09-28 01:09:29 +02:00
Siebrand Mazeland
870be512d2
Update POT files for plugins.
2010-09-23 00:37:16 +02:00
Evan Prodromou
78ed0348b0
Merge remote branch 'gitorious/0.9.x' into 0.9.x
2010-09-21 14:07:48 -04:00
Siebrand Mazeland
c932c0fdc1
Update pot files for plugins.
2010-09-19 17:44:29 +02:00
Siebrand Mazeland
ecafae8472
* Remove trailing newline in e-mail message.
...
* Superfluous whitespace removed.
2010-09-19 15:52:53 +02:00
Siebrand Mazeland
8135f7d960
Update pot files for plugins.
2010-09-19 00:24:48 +02:00
Siebrand Mazeland
02299d5bd7
* i18n/L10n updates.
...
* add FIXMEs for bad i18n.
* add translator hints.
2010-09-19 00:06:21 +02:00
Siebrand Mazeland
16d234f9af
Remove superfluous whitespace
2010-09-18 23:49:49 +02:00
Siebrand Mazeland
ba6538ed78
* i18n/L10n updates
...
* whitespace updates.
2010-09-18 17:45:18 +02:00
Evan Prodromou
b2abae433d
Merge remote branch 'gitorious/0.9.x' into 0.9.x
2010-09-15 15:57:41 -04:00
Siebrand Mazeland
db1d348135
Update/add pot files for plugins.
2010-09-15 01:16:45 +02:00
Evan Prodromou
398df867de
use capturing parens for matching at-mentions in twitterstatusfetcher
2010-09-10 09:21:01 -04:00
Evan Prodromou
deb8f2a38b
make our own twitter links if Twitter doesn't give us entities
2010-09-10 09:10:53 -04:00
Evan Prodromou
42f1ec85ea
change the event we use for deleting a linked status on Twitter
2010-09-08 16:40:37 -04:00
Evan Prodromou
e40ed1fd56
move notice_to_status initialization code to run-once script
2010-09-08 16:10:07 -04:00
Evan Prodromou
5c98dfd58c
text substitution is Unicode-aware for twitterstatusfetcher
2010-09-07 15:54:06 -04:00
Evan Prodromou
2d18963b4c
Fix pkeyget call
...
Fix the pkeyget call in Twitter_synch_Status
2010-09-07 15:34:10 -04:00
Evan Prodromou
b6440a206d
staticGet -> pkeyGet in Twitter_synch_status
2010-09-07 15:29:36 -04:00
Evan Prodromou
d37f0da077
debug statements for setting/getting last id
2010-09-07 11:53:26 -04:00
Evan Prodromou
9793e4ceb4
Store foreign ID for synch info, not user ID
2010-09-07 10:53:11 -04:00
Evan Prodromou
21bea14140
remove data dump of retrieved statuses
2010-09-07 04:42:23 -04:00
Evan Prodromou
8facfdcfee
Correct DB_DataObject constant in Twitter_synch_status
2010-09-07 04:35:14 -04:00
Evan Prodromou
98e9fa19c8
Missing comma in column list in Twitter_synch_status
2010-09-07 04:33:28 -04:00
Evan Prodromou
49af35b44d
add modified column to twitter_synch_status
2010-09-07 04:32:01 -04:00
Evan Prodromou
e53e152d6f
use and save since_id parameter for home_timeline
2010-09-07 04:22:55 -04:00
Evan Prodromou
86b6d7b722
save synch status for different timelines
2010-09-07 04:17:36 -04:00
Evan Prodromou
a46ba0b548
save Twitter mentions as StatusNet replies
2010-09-07 04:00:59 -04:00
Evan Prodromou
c2c6acbfd2
add back in # and @ for links
2010-09-07 04:00:59 -04:00
Evan Prodromou
2de6d0b03d
add Twitter-approved links to Twitter statuses
2010-09-07 04:00:59 -04:00
Evan Prodromou
28fecf70b9
better handling of params in oauthget
2010-09-07 04:00:59 -04:00
Evan Prodromou
a844aaaea6
better param handling in hometimeline
2010-09-07 04:00:59 -04:00
Evan Prodromou
86d37ba59c
include entities in the results of home_timeline
2010-09-07 04:00:59 -04:00
Evan Prodromou
b059a19e0f
delete Twitter notice if it was posted from here
2010-09-07 04:00:59 -04:00
Evan Prodromou
ba8a24073f
Notify Twitter when StatusNet user faves/disfaves a Twitter notice
2010-09-07 04:00:59 -04:00
Evan Prodromou
5944fe57e6
using null variable in twitter_status_id()
2010-09-07 04:00:59 -04:00
Evan Prodromou
a5554bc11e
check status_id before trying to retweet it
2010-09-07 04:00:59 -04:00